From: Mark Brown <broonie@kernel.org>
To: Jeremy Linton <jeremy.linton@arm.com>
Cc: herbert@gondor.apana.org.au, catalin.marinas@arm.com,
linux-kernel@vger.kernel.org, ardb@kernel.org,
linux-crypto@vger.kernel.org, will@kernel.org,
davem@davemloft.net, linux-arm-kernel@lists.infradead.org
Subject: Re: [BUG][PATCH] crypto: arm64: Avoid indirect branch to bti_c
Date: Tue, 6 Oct 2020 11:35:08 +0100 [thread overview]
Message-ID: <20201006103508.GA5259@sirena.org.uk> (raw)
In-Reply-To: <20201006034854.2277538-1-jeremy.linton@arm.com>
[-- Attachment #1.1: Type: text/plain, Size: 424 bytes --]
On Mon, Oct 05, 2020 at 10:48:54PM -0500, Jeremy Linton wrote:
> The AES code uses a 'br x7' as part of a function called by
> a macro. That branch needs a bti_j as a target. This results
> in a panic as seen below. Instead of trying to replace the branch
> target with a bti_jc, lets replace the indirect branch with a
> bl/ret, bl sequence that can target the existing bti_c.
Reviewed-by: Mark Brown <broonie@kernel.org>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2020-10-06 10:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-06 3:48 [BUG][PATCH] crypto: arm64: Avoid indirect branch to bti_c Jeremy Linton
2020-10-06 8:27 ` Will Deacon
2020-10-06 10:01 ` Dave Martin
2020-10-06 10:21 ` Will Deacon
2020-10-06 10:25 ` Catalin Marinas
2020-10-06 10:43 ` Dave Martin
2020-10-06 12:33 ` Catalin Marinas
2020-10-06 12:36 ` Ard Biesheuvel
2020-10-06 13:45 ` Jeremy Linton
2020-10-06 10:35 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201006103508.GA5259@sirena.org.uk \
--to=broonie@kernel.org \
--cc=ardb@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jeremy.linton@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).