From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8327EC41604 for ; Tue, 6 Oct 2020 17:10:59 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1E51C206DD for ; Tue, 6 Oct 2020 17:10:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="JOkxArzJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1E51C206DD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pq+RWEbBX/7tcW3TZP8jrS/g1aZTa5T9ltxRYNDT6z0=; b=JOkxArzJptsCMyJ29L3a7C/lT VPWvN/IQUh1fE2wyREtIGsLBrUS9TWV/0hQ6HaMy//QYBidhRifTd/r/wJ7Y3G9RWw01jwvxUilqb i/yQBU/NYh263jtAHnm0roihDobTgkIERaHcoLdo8WcQP7f2bm0iev1SNFdybyyEZ3WsSOiPCwKDm BbJL39XZuDe9fDTQmTIp3sloQuMmHBdLy4AmsuZx3+IWJ73p5Q12yR4+/C61LYD2NRs5ZlFPCvP5U hpSDggI/QuuEIsxRtGcReDylzo2xXr2WdWdFqbFVkj/sXzBx+kcU3Sz4D4DtK+4NfH0UX9Q6/KIwm 3irACOGVw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kPqSr-0002QI-8M; Tue, 06 Oct 2020 17:09:25 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kPqSo-0002Pv-MV for linux-arm-kernel@lists.infradead.org; Tue, 06 Oct 2020 17:09:23 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0BC15D6E; Tue, 6 Oct 2020 10:09:18 -0700 (PDT) Received: from localhost (e108754-lin.cambridge.arm.com [10.1.199.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9F8133F66B; Tue, 6 Oct 2020 10:09:17 -0700 (PDT) Date: Tue, 6 Oct 2020 18:09:16 +0100 From: Ionela Voinescu To: Viresh Kumar Subject: Re: [PATCH 1/2] cpufreq,arm,arm64: restructure definitions of arch_set_freq_scale() Message-ID: <20201006170916.GB17897@arm.com> References: <20200924123016.13427-1-ionela.voinescu@arm.com> <20200924123016.13427-2-ionela.voinescu@arm.com> <20201006070551.kokmnsuzyzqxqbq5@vireshk-i7> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201006070551.kokmnsuzyzqxqbq5@vireshk-i7> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201006_130922_790561_F482578C X-CRM114-Status: GOOD ( 16.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, catalin.marinas@arm.com, rjw@rjwysocki.net, linux@armlinux.org.uk, valentin.schneider@arm.com, sudeep.holla@arm.com, will@kernel.org, dietmar.eggemann@arm.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Viresh, On Tuesday 06 Oct 2020 at 12:35:51 (+0530), Viresh Kumar wrote: > On 24-09-20, 13:30, Ionela Voinescu wrote: > > diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c > > index 2ea245a6c0c0..f34d3a3d5ba6 100644 > > --- a/drivers/cpufreq/cpufreq.c > > +++ b/drivers/cpufreq/cpufreq.c > > @@ -160,13 +160,6 @@ u64 get_cpu_idle_time(unsigned int cpu, u64 *wall, int io_busy) > > } > > EXPORT_SYMBOL_GPL(get_cpu_idle_time); > > > > -__weak void arch_set_freq_scale(const struct cpumask *cpus, > > - unsigned long cur_freq, > > - unsigned long max_freq) > > -{ > > -} > > -EXPORT_SYMBOL_GPL(arch_set_freq_scale); > > - > > Why can't we have this anymore ? Because it is a macro now instead of a routine > for ARM ? Yes, instead of having a strong counterpart in arch_topology.c to be used for both arm64 and arm, I separated the definitions of the arch_set_freq_scale symbol in each architecture's topology.h in order to be filtered if needed (as is the case for arm's BL_SWITCHER). I could have kept either this weak stub definition or the stub that is now in cpufreq.h under "#ifndef arch_set_freq_scale", but I chose the latter as it's more aligned with the other architectural functions referenced in the commit message. So this patch has both the purpose of enabling a nicer filtering of frequency invariance for BL_SWITCHER but also follows the definition pattern of the other functions so we don't keep having two mindsets when working with them. Thanks, Ionela. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel