From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB64AC47095 for ; Tue, 6 Oct 2020 19:30:48 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 54513205F4 for ; Tue, 6 Oct 2020 19:30:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MjzFsmN0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 54513205F4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=AKWO55vyDtRRMaAEid1cICMJEy/fBEAijAHjHJgYurs=; b=MjzFsmN0AuoQQ/ZqsCGnPVxTR vuOCA7TMUkftofqCZVPZD5PdAaqzKGnkOHICflw5K8f14ZDSZVhfKEhr3kqC6EfMCmZyJwjJmqTnY w2Cnpfex45GU5fj4lLTJ162oVZhVcdEJvE7x0HUwJEG6Qbh3WZXBct6oE4RKkogJmtZSfl9nywCTC 4rfFpZFUCj4PbHQajPsxvEoXR5et2yZRK3dI2MvaQJUIBF3G7JQzooAKF3sBZgqJ9wZpg13ioxiZ0 0RkJAkEdl8yqwdrW8gWSAZ4JXN5uR67zUow6bUaQiX+OpesovBmuw19OcbwBZHEI7lkMg3u40TKBH ItvZBD6eA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kPseC-0000u0-A8; Tue, 06 Oct 2020 19:29:16 +0000 Received: from mail-ot1-f68.google.com ([209.85.210.68]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kPse8-0000tQ-3j for linux-arm-kernel@lists.infradead.org; Tue, 06 Oct 2020 19:29:13 +0000 Received: by mail-ot1-f68.google.com with SMTP id l4so9910723ota.7 for ; Tue, 06 Oct 2020 12:29:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=1XFxPruWwKJTlwaZYxVkA0YAtY/aY5Lm02Tmq9V8o9g=; b=gwt0NM4mqdKaJjPBlLLB0msf5OGFptL0UHX5krl60UeEKTNsmnzuWh1J4rmjnd+du2 4Z+5SvY9GwyCApH6r7z6KhHwejx4tOxK1TYSXmjh5lMNzH9AsSjJ2pLcFRc5kVU3wyZD jdL0sJ0VTXN1bHFCzFZLGrrDlY+KPbbmxkvUa08S69GnodZS3lKLAca62FLuR5IqAp94 tlUgLfUZkii39wDGbrJPzmbZjtlJMDk2lMaSo9uYXc73wBTFmZ2z8CrjwIVt9NXA6mvu UwK9wxP6Pu4mhVsy/MMr21q0b8NX+m9LtPtutD9mb9ilk+abJR/qdjn8mwjcRIZHo8bg Q3Mw== X-Gm-Message-State: AOAM531BPiMKjCQCMDnBwM05kTvO/jF7jkqSTbF9E7KDnPU5K+aYHGdF fndPnTKSg3up/21BMl01YLDILMFqbHhN X-Google-Smtp-Source: ABdhPJzN70sKNq6AWYw5I/4l2/htND8DBMBQd6RK7AYtdHUnC8ift9ywySUFzD8ao+7o/oEAElsc2w== X-Received: by 2002:a9d:5a0b:: with SMTP id v11mr3874682oth.347.1602012550950; Tue, 06 Oct 2020 12:29:10 -0700 (PDT) Received: from xps15 (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id u125sm1625491oif.21.2020.10.06.12.29.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Oct 2020 12:29:10 -0700 (PDT) Received: (nullmailer pid 2687025 invoked by uid 1000); Tue, 06 Oct 2020 19:29:09 -0000 Date: Tue, 6 Oct 2020 14:29:09 -0500 From: Rob Herring To: Peter Ujfalusi Subject: Re: [PATCH 09/18] dt-bindings: dma: ti: Add document for K3 BCDMA Message-ID: <20201006192909.GA2679155@bogus> References: <20200930091412.8020-1-peter.ujfalusi@ti.com> <20200930091412.8020-10-peter.ujfalusi@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200930091412.8020-10-peter.ujfalusi@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201006_152912_161393_346A306A X-CRM114-Status: GOOD ( 28.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nm@ti.com, devicetree@vger.kernel.org, vigneshr@ti.com, lokeshvutla@ti.com, linux-kernel@vger.kernel.org, t-kristo@ti.com, vkoul@kernel.org, ssantosh@kernel.org, dmaengine@vger.kernel.org, dan.j.williams@intel.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Sep 30, 2020 at 12:14:03PM +0300, Peter Ujfalusi wrote: > New binding document for > Texas Instruments K3 Block Copy DMA (BCDMA). > > BCDMA is introduced as part of AM64. > > Signed-off-by: Peter Ujfalusi > --- > .../devicetree/bindings/dma/ti/k3-bcdma.yaml | 183 ++++++++++++++++++ > 1 file changed, 183 insertions(+) > create mode 100644 Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml > > diff --git a/Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml b/Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml > new file mode 100644 > index 000000000000..c84fb641738f > --- /dev/null > +++ b/Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml > @@ -0,0 +1,183 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/dma/ti/k3-bcdma.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Texas Instruments K3 DMSS BCDMA Device Tree Bindings > + > +maintainers: > + - Peter Ujfalusi > + > +description: | > + The Block Copy DMA (BCDMA) is intended to perform similar functions as the TR > + mode channels of K3 UDMA-P. > + BCDMA includes block copy channels and Split channels. > + > + Block copy channels mainly used for memory to memory transfers, but with > + optional triggers a block copy channel can service peripherals by accessing > + directly to memory mapped registers or area. > + > + Split channels can be used to service PSI-L based peripherals. > + The peripherals can be PSI-L native or legacy, non PSI-L native peripherals > + with PDMAs. PDMA is tasked to act as a bridge between the PSI-L fabric and the > + legacy peripheral. > + > + PDMAs can be configured via BCDMA split channel's peer registers to match with > + the configuration of the legacy peripheral. > + > +allOf: > + - $ref: /schemas/dma/dma-controller.yaml# > + > +properties: > + "#dma-cells": > + const: 3 > + description: | > + cell 1: type of the BCDMA channel to be used to service the peripheral: > + 0 - split channel > + 1 - block copy channel using global trigger 1 > + 2 - block copy channel using global trigger 2 > + 3 - block copy channel using local trigger > + > + cell 2: parameter for the channel: > + if cell 1 is 0 (split channel): > + PSI-L thread ID of the remote (to BCDMA) end. > + Valid ranges for thread ID depends on the data movement direction: > + for source thread IDs (rx): 0 - 0x7fff > + for destination thread IDs (tx): 0x8000 - 0xffff > + > + Please refer to the device documentation for the PSI-L thread map and > + also the PSI-L peripheral chapter for the correct thread ID. > + if cell 1 is 1 or 2 (block copy channel using global trigger): > + Unused, ignored > + > + The trigger must be configured for the channel externally to BCDMA, > + channels using global triggers should not be requested directly, but > + via DMA event router. > + if cell 1 is 3 (block copy channel using local trigger): > + bchan number of the locally triggered channel > + > + cell 3: ASEL value for the channel > + > + compatible: > + enum: > + - ti,am64-dmss-bcdma > + > + "#address-cells": > + const: 2 > + > + "#size-cells": > + const: 2 > + > + reg: > + maxItems: 5 > + > + reg-names: > + items: > + - const: gcfg > + - const: bchanrt > + - const: rchanrt > + - const: tchanrt > + - const: ringrt > + > + msi-parent: true > + > + ti,sci: > + description: phandle to TI-SCI compatible System controller node > + allOf: > + - $ref: /schemas/types.yaml#/definitions/phandle > + > + ti,sci-dev-id: > + description: TI-SCI device id of BCDMA > + allOf: > + - $ref: /schemas/types.yaml#/definitions/uint32 We have a common definition for these. > + > + ti,asel: > + description: ASEL value for non slave channels > + allOf: You no longer need 'allOf' here. > + - $ref: /schemas/types.yaml#/definitions/uint32 > + > + ti,sci-rm-range-bchan: > + description: | > + Array of BCDMA block-copy channel resource subtypes for resource > + allocation for this host > + allOf: > + - $ref: /schemas/types.yaml#/definitions/uint32-array > + minItems: 1 > + # Should be enough > + maxItems: 255 Are there constraints for the individual elements? > + > + ti,sci-rm-range-tchan: > + description: | > + Array of BCDMA split tx channel resource subtypes for resource allocation > + for this host > + allOf: > + - $ref: /schemas/types.yaml#/definitions/uint32-array > + minItems: 1 > + # Should be enough > + maxItems: 255 > + > + ti,sci-rm-range-rchan: > + description: | > + Array of BCDMA split rx channel resource subtypes for resource allocation > + for this host > + allOf: > + - $ref: /schemas/types.yaml#/definitions/uint32-array > + minItems: 1 > + # Should be enough > + maxItems: 255 > + > +required: > + - compatible > + - "#address-cells" > + - "#size-cells" > + - "#dma-cells" > + - reg > + - reg-names > + - msi-parent > + - ti,sci > + - ti,sci-dev-id > + - ti,sci-rm-range-bchan > + - ti,sci-rm-range-tchan > + - ti,sci-rm-range-rchan > + > +additionalProperties: false > + > +examples: > + - |+ > + cbass_main { > + #address-cells = <2>; > + #size-cells = <2>; > + > + main_dmss { > + compatible = "simple-mfd"; IMO, if it is memory-mapped, then you should be using 'simple-bus'. > + #address-cells = <2>; > + #size-cells = <2>; > + dma-ranges; > + ranges; > + > + ti,sci-dev-id = <25>; > + > + main_bcdma: dma-controller@485c0100 { > + compatible = "ti,am64-dmss-bcdma"; > + #address-cells = <2>; > + #size-cells = <2>; > + > + reg = <0x0 0x485c0100 0x0 0x100>, > + <0x0 0x4c000000 0x0 0x20000>, > + <0x0 0x4a820000 0x0 0x20000>, > + <0x0 0x4aa40000 0x0 0x20000>, > + <0x0 0x4bc00000 0x0 0x100000>; > + reg-names = "gcfg", "bchanrt", "rchanrt", "tchanrt", "ringrt"; > + msi-parent = <&inta_main_dmss>; > + #dma-cells = <3>; > + > + ti,sci = <&dmsc>; > + ti,sci-dev-id = <26>; > + > + ti,sci-rm-range-bchan = <0x20>; /* BLOCK_COPY_CHAN */ > + ti,sci-rm-range-rchan = <0x21>; /* SPLIT_TR_RX_CHAN */ > + ti,sci-rm-range-tchan = <0x22>; /* SPLIT_TR_TX_CHAN */ > + }; > + }; > + }; > -- > Peter > > Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. > Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel