From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54718C41604 for ; Tue, 6 Oct 2020 19:43:53 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E1145206F4 for ; Tue, 6 Oct 2020 19:43:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="FhovTdRy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E1145206F4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fBvNhe9TngBGuS5BPxZMAD/IYIgJeoKFzxxtJZSnrxw=; b=FhovTdRylFiteRVrI5W9kDllP 3qBLMNLZxTLrxmolXV4bXtKfcZwCgS4LtJjFe0QUlqfcFJEFf38XUJP0PkU855i+f3n+OWZEQA9AK x8P/ncFkbOIyPsyinky3h58yB0sX/74wwMHYiG+XHiWcQJH9+3NbJd0Wm8dgKlGsDT68JL8vlgaZz I39hw/UFOYnHAurR+RwaKRlO020vrQw97PyS3x5Ew/Le/0L+ao9AaoSSUwEbda4IcNkG5LuCzUn+K AGBEyilFlSbJMDe8FItk0N3hX5NhmFs3sM/fmq9HY4ciJFc1th/vG2IH+uQbOjnq6u8cfFVFcxqUr Qz4DV6mwA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kPsqq-0003Nd-F5; Tue, 06 Oct 2020 19:42:20 +0000 Received: from mail-ot1-f67.google.com ([209.85.210.67]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kPsqm-0003NC-UM for linux-arm-kernel@lists.infradead.org; Tue, 06 Oct 2020 19:42:17 +0000 Received: by mail-ot1-f67.google.com with SMTP id f10so4901599otb.6 for ; Tue, 06 Oct 2020 12:42:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=oMoNfavxvblIfRmkSezl0TERvE0PCRTDTAkpdHlbN1I=; b=LBisr1I+iNfUt/mzPf9gL0IheNowwazDHgq2BDLjNGaNseeXVAZdGBJLzfzEaFn1pu 0/fD5o2RYnEVapU9nmDXXUh4YQdUij+u2VaI6mPBvhQnhoAAMceqqGjQ7IQHo787p6d7 es4vcoKv4SWO/6MaCT2Gt1zmI84mWnoBsPB3ltIAtqzvX8F9Ke/eqhmQLyWPlw9Nh1PL sS9VFUDNaAw+vLiaDGo5nJTwtrOIWjrjFSXH05go8bmMzB9SYY+Z/xEHXhPpMn0rotbZ HW8Ehe2y4RDQ7wor+Q4IVvXMvHHaWSn2MVE5d64Fj7LBmH9ly1h/CC1HEAMS5/+ZcFut lTNQ== X-Gm-Message-State: AOAM532Wh9hn7B1fTwunguABTxKAhPFSointMc20RWD9wAoOHcp7JAEE 354j+Nfo/NO8mLFtE9Ln4w== X-Google-Smtp-Source: ABdhPJzwxqbKiOvCs5GwsyjAErqx3aN1H/wAhum4+pyyAtGtuPidpk1NMbZG5pXXfWeQkwfbycV2BQ== X-Received: by 2002:a9d:491:: with SMTP id 17mr4064278otm.338.1602013335758; Tue, 06 Oct 2020 12:42:15 -0700 (PDT) Received: from xps15 (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id m7sm1486436otk.74.2020.10.06.12.42.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Oct 2020 12:42:15 -0700 (PDT) Received: (nullmailer pid 2707920 invoked by uid 1000); Tue, 06 Oct 2020 19:42:14 -0000 Date: Tue, 6 Oct 2020 14:42:14 -0500 From: Rob Herring To: Lucas Stach Subject: Re: [PATCH 07/11] soc: imx: gpcv2: add support for optional resets Message-ID: <20201006194214.GA2702908@bogus> References: <20200930155006.535712-1-l.stach@pengutronix.de> <20200930155006.535712-8-l.stach@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200930155006.535712-8-l.stach@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201006_154216_997555_45EC6A68 X-CRM114-Status: GOOD ( 25.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marek Vasut , devicetree@vger.kernel.org, Shawn Guo , Frieder Schrempf , patchwork-lst@pengutronix.de, NXP Linux Team , kernel@pengutronix.de, Fabio Estevam , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Sep 30, 2020 at 05:50:02PM +0200, Lucas Stach wrote: > Normally the reset for the devices inside the power domain is > triggered automatically from the PGC in the power-up sequencing, > however on i.MX8MM this doesn't work for the GPU power domains. > > Add support for triggering the reset explicitly during the power > up sequencing. > > Signed-off-by: Lucas Stach > --- > .../devicetree/bindings/power/fsl,imx-gpcv2.yaml | 6 ++++++ > drivers/soc/imx/gpcv2.c | 13 +++++++++++++ > 2 files changed, 19 insertions(+) > > diff --git a/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml b/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml > index bde09a0b2da3..9773771b9000 100644 > --- a/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml > +++ b/Documentation/devicetree/bindings/power/fsl,imx-gpcv2.yaml > @@ -62,6 +62,12 @@ properties: > > power-supply: true > > + resets: > + description: | > + A number of phandles to resets that need to be asserted during > + power-up sequencing of the domain. > + minItems: 1 What's the max? It's going to default to 1 if you don't say. > + > required: > - '#power-domain-cells' > - reg > diff --git a/drivers/soc/imx/gpcv2.c b/drivers/soc/imx/gpcv2.c > index db93fef0c76b..76aa8a67d8a7 100644 > --- a/drivers/soc/imx/gpcv2.c > +++ b/drivers/soc/imx/gpcv2.c > @@ -15,6 +15,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -112,6 +113,7 @@ struct imx_pgc_domain { > struct regulator *regulator; > struct clk *clk[GPC_CLK_MAX]; > int num_clks; > + struct reset_control *reset; > > unsigned int pgc; > > @@ -167,6 +169,8 @@ static int imx_pgc_power_up(struct generic_pm_domain *genpd) > } > } > > + reset_control_assert(domain->reset); > + > if (domain->bits.pxx) { > /* request the domain to power up */ > regmap_update_bits(domain->regmap, GPC_PU_PGC_SW_PUP_REQ, > @@ -189,6 +193,8 @@ static int imx_pgc_power_up(struct generic_pm_domain *genpd) > GPC_PGC_CTRL_PCR, 0); > } > > + reset_control_deassert(domain->reset); > + > /* request the ADB400 to power up */ > if (domain->bits.hskreq) { > regmap_update_bits(domain->regmap, GPC_PU_PWRHSK, > @@ -577,6 +583,13 @@ static int imx_pgc_domain_probe(struct platform_device *pdev) > domain->voltage, domain->voltage); > } > > + domain->reset = devm_reset_control_array_get_optional_exclusive(domain->dev); > + if (IS_ERR(domain->reset)) { > + if (PTR_ERR(domain->reset) != -EPROBE_DEFER) > + dev_err(domain->dev, "Failed to get domain's reset\n"); > + return PTR_ERR(domain->reset); > + } > + > ret = imx_pgc_get_clocks(domain); > if (ret) { > if (ret != -EPROBE_DEFER) > -- > 2.20.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel