From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69077C4363C for ; Wed, 7 Oct 2020 06:55:03 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BD4EF20797 for ; Wed, 7 Oct 2020 06:55:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="k8ptcYYB"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="jH04N95L" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BD4EF20797 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DC/WK/3buFqURKp/xGpeKgBUNPjV0hHoVy7R3LyI614=; b=k8ptcYYBA1FrXP8KMl/OpZiQo 71h6OG9qs19I3LnStuZ4PLeo1gIyJJNiyZ2iBrdDy4cYWatcROWXnb6DjDVFoTo07z8597NPvXzr9 oSp6zQ7ij0A+ggx/7Q18kqlTpGFF//BRg0yPjtCzcE9+DjB0xzPRMiwGX62nsbvArA3Ql+/mXOcuo xRO/bZ73RV6xMWZmIZKuooH9kG5jIpusi7pP2JDMz7hPjGaJA+YVfNvMugQi98C0pzvY7EbTHngly mB84nrydRv0KDVyWwY4X5u1MIyxhCxqM7xvFudWtnSk5BDlpTTkNDIfzjkNRpax/8TyY2QXAVR2it UFu5sktoQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQ3K6-0000qA-H5; Wed, 07 Oct 2020 06:53:14 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQ3K3-0000pR-AM for linux-arm-kernel@lists.infradead.org; Wed, 07 Oct 2020 06:53:12 +0000 Received: from localhost (unknown [122.171.222.162]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C1E2E20797; Wed, 7 Oct 2020 06:53:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602053589; bh=WnCyc7OlZxbrj4ooSfvmm2cyBE+u5+4ecYnYdEioJ5Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jH04N95LiL9SC7lL5ocCE3Bv68tKklB00kTumCRPl6x4PHGbNv+acOvCODjj8bdq8 Oimv2htRf8ZyrnCaad5EdTMVAQpy8YfbiUc5R/4IkVsfYJZr1PbktQUVy+W3Rf7GG7 y5LMeKN+Ymqnz90N7EjPMJh++fkupnSRc5WvJ4a4= Date: Wed, 7 Oct 2020 12:23:05 +0530 From: Vinod Koul To: Peter Ujfalusi Subject: Re: [PATCH 07/18] dmaengine: ti: k3-udma-glue: Add function to get device pointer for DMA API Message-ID: <20201007065305.GS2968@vkoul-mobl> References: <20200930091412.8020-1-peter.ujfalusi@ti.com> <20200930091412.8020-8-peter.ujfalusi@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200930091412.8020-8-peter.ujfalusi@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201007_025311_535233_CA23029F X-CRM114-Status: GOOD ( 17.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nm@ti.com, devicetree@vger.kernel.org, vigneshr@ti.com, lokeshvutla@ti.com, linux-kernel@vger.kernel.org, t-kristo@ti.com, robh+dt@kernel.org, ssantosh@kernel.org, dmaengine@vger.kernel.org, dan.j.williams@intel.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 30-09-20, 12:14, Peter Ujfalusi wrote: > Glue layer users should use the device of the DMA for DMA mapping and > allocations as it is the DMA which accesses to descriptors and buffers, > not the clients > > Signed-off-by: Peter Ujfalusi > --- > drivers/dma/ti/k3-udma-glue.c | 14 ++++++++++++++ > drivers/dma/ti/k3-udma-private.c | 6 ++++++ > drivers/dma/ti/k3-udma.h | 1 + > include/linux/dma/k3-udma-glue.h | 4 ++++ > 4 files changed, 25 insertions(+) > > diff --git a/drivers/dma/ti/k3-udma-glue.c b/drivers/dma/ti/k3-udma-glue.c > index a367584f0d7b..a53bc4707ae8 100644 > --- a/drivers/dma/ti/k3-udma-glue.c > +++ b/drivers/dma/ti/k3-udma-glue.c > @@ -487,6 +487,13 @@ int k3_udma_glue_tx_get_irq(struct k3_udma_glue_tx_channel *tx_chn) > } > EXPORT_SYMBOL_GPL(k3_udma_glue_tx_get_irq); > > +struct device * > + k3_udma_glue_tx_get_dma_device(struct k3_udma_glue_tx_channel *tx_chn) How about.. struct device * k3_udma_glue_tx_get_dma_device(struct k3_udma_glue_tx_channel *tx_chn) > +{ > + return xudma_get_device(tx_chn->common.udmax); > +} > +EXPORT_SYMBOL_GPL(k3_udma_glue_tx_get_dma_device); Hmm why would you need to export this device.. Can you please outline all the devices involved here... why not use dmaI_dev->dev or chan->dev? -- ~Vinod _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel