From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93399C4363C for ; Wed, 7 Oct 2020 10:12:11 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 27DD220782 for ; Wed, 7 Oct 2020 10:12:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="cojwVoiZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 27DD220782 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=PGM289YfJSIMjBPf4/yUMBMQHJkgh6/BGgWsIAmrDAU=; b=cojwVoiZopRjmOiLIGuKIzX0O E48CkulYJBGJhNctUTkg8sPMLczMRmBwrVj6AA54Uwr10P6MVtO0ni2w9qE84eyjXBRMk6UrPmLv/ xAE4Nhsdl0BYwY6DjymwrZKYNivgHVpxuha/A8TT8kAPEOz4zS5pvGF3L858AOFTcjiPyX0ICLeW0 n+hWvA/cudOAayqEArXsx+P25wgMGacKOp0u83c5HGEi9YmKSbQi8I0wqJotzOu6XYfKMW6N6Wr71 3M2iZHovpdEhz/tGnQ7w2/8oGxF11sWCzzWNlyH19WWPIYe6ox/AiLIW2eC9uDprHpQzzCQA9Vdtg 7Ukjql6bQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQ6PN-0001gH-QV; Wed, 07 Oct 2020 10:10:54 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQ6PK-0001dh-8H for linux-arm-kernel@lists.infradead.org; Wed, 07 Oct 2020 10:10:51 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 37806113E; Wed, 7 Oct 2020 03:10:47 -0700 (PDT) Received: from bogus (unknown [10.57.54.133]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 938913F71F; Wed, 7 Oct 2020 03:10:44 -0700 (PDT) Date: Wed, 7 Oct 2020 11:10:38 +0100 From: Sudeep Holla To: Michal Simek Subject: Re: [PATCH v3 2/2] firmware: Keem Bay: Add support for Arm Trusted Firmware Service call Message-ID: <20201007101038.ec7ymdhiaf7rhyrm@bogus> References: <20201006155549.3595-1-muhammad.husaini.zulkifli@intel.com> <20201006155549.3595-3-muhammad.husaini.zulkifli@intel.com> <4677c614-ac00-fb69-d22c-54f9015249f4@xilinx.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4677c614-ac00-fb69-d22c-54f9015249f4@xilinx.com> User-Agent: NeoMutt/20171215 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201007_061050_515541_03CAF141 X-CRM114-Status: GOOD ( 25.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ulf.hansson@linaro.org, arnd@arndb.de, lakshmi.bai.raja.subramanian@intel.com, linux-mmc@vger.kernel.org, adrian.hunter@intel.com, linux-kernel@vger.kernel.org, wan.ahmad.zainie.wan.mohamad@intel.com, Sudeep Holla , muhammad.husaini.zulkifli@intel.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Oct 07, 2020 at 10:20:21AM +0200, Michal Simek wrote: > Hi, > > 1. Keem Bay: in subject is wrong. Tools are working with it and you > should just use keembay: instead. > > 2. This should come first before actual change to keep the tree bisectable. > > On 06. 10. 20 17:55, muhammad.husaini.zulkifli@intel.com wrote: > > From: Muhammad Husaini Zulkifli > > > > Add header file to handle API function for device driver to communicate > > with Arm Trusted Firmware. > > > > Signed-off-by: Muhammad Husaini Zulkifli > > --- > > .../linux/firmware/intel/keembay_firmware.h | 46 +++++++++++++++++++ > > 1 file changed, 46 insertions(+) > > create mode 100644 include/linux/firmware/intel/keembay_firmware.h > > > > diff --git a/include/linux/firmware/intel/keembay_firmware.h b/include/linux/firmware/intel/keembay_firmware.h > > new file mode 100644 > > index 000000000000..9adb8c87b788 > > --- /dev/null > > +++ b/include/linux/firmware/intel/keembay_firmware.h > > @@ -0,0 +1,46 @@ > > +/* SPDX-License-Identifier: GPL-2.0 */ > > +/* > > + * Intel Keembay SOC Firmware API Layer > > + * > > + * Copyright (C) 2020-2021, Intel Corporation > > + * > > + * Muhammad Husaini Zulkifli > > + */ > > + > > +#ifndef __FIRMWARE_KEEMBAY_SMC_H__ > > +#define __FIRMWARE_KEEMBAY_SMC_H__ > > + > > +#include > > + > > +/** > > This is not a kernel doc comment. Just use /* > > > + * This file defines API function that can be called by device driver in order to > > + * communicate with Arm Trusted Firmware. > > + */ > > + > > +/* Setting for Keem Bay IO Pad Line Voltage Selection */ > > +#define KEEMBAY_SET_SD_VOLTAGE_FUNC_ID 0x8200ff26 > > Sudeep: Don't we have any macros for composing these IDs? > nit: IMHO composing these IDs from macros would make more sense to me. > Yes we do. Refer include/linux/arm-smccc.h I expect something like below, which also indicated you are using wrong OWNER space. You can't be 0 which is reserved for CPU ARCH. You need to be SIP(0x2) #define ARM_SMCCC_SIP_KEEMBAY_SET_SD_VOLTAGE \ ARM_SMCCC_CALL_VAL(ARM_SMCCC_FAST_CALL, \ ARM_SMCCC_SMC_32, \ ARM_SMCCC_OWNER_SIP, \ 0xFF26) -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel