From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A695C47095 for ; Wed, 7 Oct 2020 17:14:03 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D61822168B for ; Wed, 7 Oct 2020 17:14:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="SWwvr6Uy"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="VjwWYWnb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D61822168B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=q8O//dT9clz+N9rV5LUR2vF0+PdB0e3czFqBdUjzZIA=; b=SWwvr6Uydt1GIrw5hgldaTJsZ0 TKQFh9c837/UzHfou95NhKBVDIRiGTjY4oPKHQLLM6ZS81fxgLx+QLySN160uxSVMaw4BcEKLW9lL e+sFTBKV91nh+nbDqi0zfbu6Z2I5ygA2uLGPYE2tDINMvWNsn4yLZnOwM+T5QcEAiG+QsotUHAijf RcZtJadfW7qhUtMW9QK7rVL9I6kaIYmgiYO1ihKvQp/Iwfi2dGqYnbpzeIUGvnMAREd19Vhh8aXLT d2Pn5aZkkfXl4au1/VBSpQ1GnZOyWLHObSdlmwbGBk89lmeYous2TzSQL8kwRiCMbOEnWAxGV24MP SilPp3tw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQCze-0006MI-3Y; Wed, 07 Oct 2020 17:12:46 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQCzY-0006JO-8e for linux-arm-kernel@lists.infradead.org; Wed, 07 Oct 2020 17:12:41 +0000 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9FB332168B; Wed, 7 Oct 2020 17:12:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602090758; bh=RdKVJPn57764S/1lhXSnPJ5wHG6Bb92edA+gsowlZK4=; h=From:To:Cc:Subject:Date:From; b=VjwWYWnbfDma/H9aHDZIv3+NtnOJgoUQEiEuQKWsNis7sfHhMp5douYIhuMQaAasb K+PrsAQsPTkgfoJAoi7kK8dSJVk9K/6arr3+SGVEUZeLNW6b+Ep6j1GwLceEj2wx5x Njm6yEVYmrvEZTmvXwQeA46BfL9J7xdNBhN1cNAQ= From: Mark Brown To: Catalin Marinas , Will Deacon Subject: [PATCH] arm64: stacktrace: Clarify documentation of EL0 entry frame skipping Date: Wed, 7 Oct 2020 18:11:38 +0100 Message-Id: <20201007171138.36015-1-broonie@kernel.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-Patch-Hashes: v=1; h=sha256; g=ee14487ed41ac0c8bde45b30b2c44d0c111bfef5; i=lMmYin7PW8t5d6s522nZM1LWeLGdoTthjFEXByiyL1M=; m=thzwfWXm3PTAhiZsBqYns69wvUjVA4i2frapWFzBwdQ=; p=xXdQGeiyeZijXiOiZ3JNfUGSQyrBNG12mWQJ2g60Zvo= X-Patch-Sig: m=pgp; i=broonie@kernel.org; s=0xC3F436CA30F5D8EB; b=iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl999goACgkQJNaLcl1Uh9Armgf/b6X 4ivGUgdGm+xl7tQfwyQsu99cozTkUWoj1fvOfuAS/Stk9IYXnncS3KyzzlCZcxJwJ/b48KZfH5G5l pQy1PMWN15HWX4f7LoPdu9A52xxwW1bQ3J3mhRNihdQtPf1T9NJ+PkWwxj1ljg1dAkYut5SwpN6GR P3+ZcqS7/2SEEdrKvMnpFw9UJ4uM+FTDZcSJGXgd9pJxqIji2tx9gkLefjV+OSGHYJJOIhwL6eiln eHNNnU+X6izZKqtlRQ9B1pX8NaFOA3+mg+DK3mQk+Crm4HEZD3WZK9J/vhlXCTFZ0lsuRbIIBzuYg mTEqOLrS5C0Aq+BjXzZaloiRUPAQKxA== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201007_131240_418352_9451AB0C X-CRM114-Status: GOOD ( 13.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Mark Brown , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The unwinder suppresses reporting of frames created on entry from EL0 where both FP and PC are NULL in order to avoid having the final NULL PC cluttering traces and potentially creating confusion. There is a comment explaining this which doesn't explicitly call out the case where we have a valid PC but NULL FP, do so in order to ensure that things are as clear as possible to readers unfamiliar with the code. Signed-off-by: Mark Brown --- arch/arm64/kernel/stacktrace.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/arm64/kernel/stacktrace.c b/arch/arm64/kernel/stacktrace.c index fa56af1a59c3..0c474d81d4e9 100644 --- a/arch/arm64/kernel/stacktrace.c +++ b/arch/arm64/kernel/stacktrace.c @@ -107,8 +107,9 @@ int notrace unwind_frame(struct task_struct *tsk, struct stackframe *frame) /* * Frames created upon entry from EL0 have NULL FP and PC values, so * don't bother reporting these. Frames created by __noreturn functions - * might have a valid FP even if PC is bogus, so only terminate where - * both are NULL. + * might have a valid FP even if PC is bogus and the last frame in a + * normal stack will have a valid PC but NULL FP, so only terminate + * early where both are NULL. */ if (!frame->fp && !frame->pc) return -EINVAL; -- 2.20.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel