From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44CACC43467 for ; Thu, 8 Oct 2020 11:16:28 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AF9782145D for ; Thu, 8 Oct 2020 11:16:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="V/1DrMMl"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="JAW1IrAu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AF9782145D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=VB17tbAeXdgKWx6/ymG+/ng6oOEpLQmJxf/zpApWH+8=; b=V/1DrMMlPvexSQdxGtf2K5PZH 8jE3YtjiI+mwAd1mOYu7Sg3Me/nF3FksD72cb3gCG2rLiBXy3ZLzE05Vcx77j8sGDwWivwg0FD2Xx 8bikloiXCOxy3ahkH5dK90kMc/fV4Uj8cvwD+dvKclRuC22EpiLJgxM9cvOxvO3nPgkz+3uWzvF7I slde7eJaLIRgpsvEbWZTp9R8/+BBNzl/jyppSjvSXH8Q9mV3QZPbcphGvjKzLFw1ZR/O/9ox7/FiE agrYJZoXjufPwBFy0ZZyZAnZFgWBRv84+rQx6NFcKP79cPmiOzKeHaiQdDMUxyyZJ0GlnFM2SGhpJ dazlJUkZg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQTt2-0000Ip-3p; Thu, 08 Oct 2020 11:15:04 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQTsz-0000He-Lb for linux-arm-kernel@lists.infradead.org; Thu, 08 Oct 2020 11:15:02 +0000 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3A6B520714; Thu, 8 Oct 2020 11:15:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602155700; bh=awmyRTd4zT/uI2ZMLGJtbFfSLNB1qFI/a4p9XWTLzNI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JAW1IrAucKBJVKMHPkPz9TU3lh113poRMU/FLHNRaSxvLCsynruiLB8bYc3yxdZ05 ZtqmDY6ou/awgTtsjrJb5EUjhVZsmH7RuL0yJdFMoIeom6nyKxn53YuW2vbCP5DC2K x3fFYj/g1BGXF5tRooMnP0z/qbkJFC9AMTMbA6zE= Date: Thu, 8 Oct 2020 12:14:57 +0100 From: Mark Brown To: Mark Rutland Subject: Re: [PATCH] arm64: stacktrace: Clarify documentation of EL0 entry frame skipping Message-ID: <20201008111457.GA6481@sirena.org.uk> References: <20201007171138.36015-1-broonie@kernel.org> <20201008101558.GA72325@C02TD0UTHF1T.local> MIME-Version: 1.0 In-Reply-To: <20201008101558.GA72325@C02TD0UTHF1T.local> X-Cookie: Serving suggestion. User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201008_071501_838127_E936992E X-CRM114-Status: GOOD ( 17.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Catalin Marinas , Will Deacon , Ard Biesheuvel , linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============1001677455166351790==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============1001677455166351790== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="82I3+IH0IqGh5yIs" Content-Disposition: inline --82I3+IH0IqGh5yIs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Oct 08, 2020 at 11:15:58AM +0100, Mark Rutland wrote: > I reckon we should remove the special case entirely rather than trying > to shore up the comment here -- the related comment in entry.S is stale > and misleading, and this will be a mystery to unfamiliar readers anyhow. That works too, so long as the check isn't really doing anything it can just be deleted and the comment with it - it's certainly one less weird special case. So long as all the things relying on it are already gone. > Does the below patch look ok to you? I suspect the explicit check for the > terminal case may help with the reliable stacktrace stuff? e.g. we could > make that return -ENOENT to distinguish a terminal case from a broken > frame record. That's almost exactly what I've got in my reliable stacktrace queue, down to the choice of -ENOENT for reporting the end of an intact stack. I'll pick this up for my changes if it doesn't get picked up separately. --82I3+IH0IqGh5yIs Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl9+9LAACgkQJNaLcl1U h9Bgbwf/Zd2399RyuXkEDLNOHWW/58mR6tS9HsKFeqEGRczhBNZ2xa2tjvdyGpfi r28KEQD4qOXcQh9raGADJagyF207xUv8ViKfkYmlmdayggZIVzhQBgCnz13jgnWh PMEWgOSUCLUNysz8B6VWtlF/mmRHv89fRwds1S6NTzspKFIaphguKmE0lVz3pK1d C9DN0PEI8wv740LYK+P8O4lL4wH3GHFNu/BvzDMX6dy8c0WPlqxSxqUSLmKEPGeS fvFmQUWf1u6oPLXmaAOXLpMf3fjAOWA40rpEdsmFnfOtI/R5MmH6sq5akMnVa5+I ZkjJmkQwzo+/tJWMXiPKpltHSNhFmw== =IpGi -----END PGP SIGNATURE----- --82I3+IH0IqGh5yIs-- --===============1001677455166351790== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============1001677455166351790==--