From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAFCBC43467 for ; Thu, 8 Oct 2020 11:37:49 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 59A98206E7 for ; Thu, 8 Oct 2020 11:37:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="QRe4E/MB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 59A98206E7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=eg99cvW0zjjr6WBFzG4iNaNGV3dbQJeVvKg9zmA1AUg=; b=QRe4E/MB1SgqFRZBEdB9PH9jo Frs9tysAD6n8ph4bnBGqQyNVuTwV2XigC6s6exkWukCAuBW1W6Yp5nK0iW3GT5mqhJxLYwRChH5OT LyHXEZ/ox0xSA9lTIXaGHxCzo4vj19+E/bO2CSdRVDE/0kxVhAH4KqXuR1bHcnmxX3EEo26ArwniY 2V24/Nt9PcayqqLaoGNB5Z5mNAqfKuECmPlO4Kg+YHsx3EeMZrfbalpPN1Wwse0x0wJlBMSI2scLd PAxTkHnsrl/HuAZylF3QJ+qd4umxamnwkTjrYuAsXwCcd1CRZbD9L79AR3iG4z6y7z4syRjrkcfwU yQWCNX7Tw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQUDm-0003za-Lv; Thu, 08 Oct 2020 11:36:30 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQUDk-0003z3-PO for linux-arm-kernel@lists.infradead.org; Thu, 08 Oct 2020 11:36:29 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E1982D6E; Thu, 8 Oct 2020 04:36:21 -0700 (PDT) Received: from e121166-lin.cambridge.arm.com (e121166-lin.cambridge.arm.com [10.1.196.255]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 911463F71F; Thu, 8 Oct 2020 04:36:20 -0700 (PDT) Date: Thu, 8 Oct 2020 12:36:14 +0100 From: Lorenzo Pieralisi To: Jisheng Zhang Subject: Re: [PATCH v5 0/2] PCI: dwc: fix two MSI issues Message-ID: <20201008113614.GA1226@e121166-lin.cambridge.arm.com> References: <20200930091205.792d6c7c@xhacker.debian> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200930091205.792d6c7c@xhacker.debian> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201008_073628_876935_C5AF3DB3 X-CRM114-Status: GOOD ( 18.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , Jingoo Han , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Kishon Vijay Abraham I , Gustavo Pimentel , Bjorn Helgaas , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Sep 30, 2020 at 09:12:05AM +0800, Jisheng Zhang wrote: > Fix two MSI issues. One to skip PCIE_MSI_INTR0* programming if MSI is > disabled, another to use an address in the driver data for MSI address, > to fix the MSI page leakage during suspend/resume. > > Since v4: > - fix pci-dra7xx.c > > Since v3: > - add Acked-by tag > - change patch2 commit msg to make it clear > - map the MSI msg with dma_map_single_attrs() for some platforms > which either has seperate addrs for dma and phy or has mem access > limitation for the PCIe. > > Since v2: > - add Acked-by tag > - use an address in the driver data for MSI address. Thank Ard and Rob > for pointing out this correct direction. > - Since the MSI page has gone, the leak issue doesn't exist anymore, > remove unnecessary patches. > - Remove dw_pcie_free_msi rename and the last patch. They could be > targeted to next. So will send out patches in a separate series. > > Since v1: > - add proper error handling patches. > - solve the msi page leakage by moving dw_pcie_msi_init() from each > users to designware host > > > Jisheng Zhang (2): > PCI: dwc: Skip PCIE_MSI_INTR0* programming if MSI is disabled > PCI: dwc: Fix MSI page leakage in suspend/resume > > drivers/pci/controller/dwc/pci-dra7xx.c | 18 +++++++++- > .../pci/controller/dwc/pcie-designware-host.c | 34 +++++++++---------- > drivers/pci/controller/dwc/pcie-designware.h | 2 +- > 3 files changed, 35 insertions(+), 19 deletions(-) Hi, can you rebase this series against my pci/dwc branch please ? Thanks, Lorenzo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel