From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E469C433DF for ; Fri, 9 Oct 2020 07:41:09 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A19B322277 for ; Fri, 9 Oct 2020 07:41:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="q1NYjAdO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A19B322277 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=NI4wUqyNtucThFeuzBPriJf/ntnviqpxrDCY/vcP3uU=; b=q1NYjAdOC9Awe4gG3bCS8rkMb XD710vMN21zVKQfCl3hRzDXRy0sb0NS7saSv/zge7X/hDiO/DOMlHdAjHdcJZBVXpbjV8BypXcZDW QMeMdJ87+SXCMNe3F3qt/H8CFzl4TwqKyqlDWtxJ0K4hpMcSaDB8gj8MToucMvxqqpw/LM6ieJgwD QTo5gg37OpxkLp6IS1L3YO5IWYkCR+P6kbeP2F9qaQdHbtirkMk4Qd+Gt2hGJQk0q0dwLNw+T9eGm scDtLTVwyAeMS1o07Hda4b06+w0m1s5/GXYUFbEkeHopfRfqVcEevtkOJ10JdT7r8CUaBuxwjX1jA oPVkIeNlg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQn0M-0005g2-EP; Fri, 09 Oct 2020 07:39:54 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQn0J-0005fP-Jp for linux-arm-kernel@lists.infradead.org; Fri, 09 Oct 2020 07:39:52 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kQn0E-0000mG-3U; Fri, 09 Oct 2020 09:39:46 +0200 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1kQn0C-0006xe-TL; Fri, 09 Oct 2020 09:39:44 +0200 Date: Fri, 9 Oct 2020 09:39:44 +0200 From: Sascha Hauer To: Christian Eggers Subject: Re: [PATCH] spi: imx: Revert "spi: imx: enable runtime pm support" Message-ID: <20201009073944.GA11648@pengutronix.de> References: <20201009042738.26602-1-ceggers@arri.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201009042738.26602-1-ceggers@arri.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 09:30:15 up 232 days, 15:00, 151 users, load average: 0.66, 0.48, 0.40 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201009_033951_655573_3302F9C8 X-CRM114-Status: GOOD ( 12.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Shawn Guo , linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Mark Brown , NXP Linux Team , Pengutronix Kernel Team , Fabio Estevam , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Oct 09, 2020 at 06:27:38AM +0200, Christian Eggers wrote: > This reverts commit 525c9e5a32bd7951eae3f06d9d077fea51718a6c. > > If CONFIG_PM is disabled, the system completely freezes on probe as > nothing enables the clock of the SPI peripheral. Instead of reverting it, why not just fix it? Normally the device should be brought to active state manually in probe before pm_runtime takes over, then CONFIG_PM disabled doesn't hurt. Using pm_runtime to put the device to active state initially has the problem you describe. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel