From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36DB8C433DF for ; Fri, 9 Oct 2020 08:14:03 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B56BD22227 for ; Fri, 9 Oct 2020 08:14:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="vWe+Jdh8"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="jJbw6jKa"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="ve8cCGYk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B56BD22227 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ASC6vA6aAnCQSMSMFbD9clv+ymcV888s27YFRdCp1aw=; b=vWe+Jdh8IqUkBly6ckzFR/eKf EFmAOPM49u7uaOUeZHuSS95+s5ab/242A1QthgxHvmq1WRn4U2ek9boEP7YjsAUo01DoctVPRzyLz ei5pOuKVteF4IGN5mclYd94dHKSVbW6gcmJd85d0rY+z8+yQoyogloBJblb8tGBw5O0BUfmkWQJ/h 4gO+uNY1Lzuv7evjAXYoBzXvC1xk8f3gN1eKhxwGqFT/gYH1d/GsnVpah71obnBWJkqxTbKgKCfjj Ti+g51MOxQDdJm9b8pSF/9CwVSjlC77eBX4wWDXsngcW1FyW/Qyb40gFhAEOVw4ymY+arFWkY1qgt eT1Vo3jOQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQnVy-0008WS-CL; Fri, 09 Oct 2020 08:12:34 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQnVv-0008VU-D9 for linux-arm-kernel@merlin.infradead.org; Fri, 09 Oct 2020 08:12:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=kEaJrhB49jY9ylGi747PC2d3zrqsG3GTNHlV2nr1xSo=; b=jJbw6jKaknNE+DQkHhBvG5S1sD ahTYqpSsQ/oXlpjmx2jx78zs0Y4KkkmMzW/96y5aE5H+ZnyVOBkC3/l7GSCRX8YBojW5O7qKfcAhO fRUkXw3l2KK+dSenf1iEOaq7Hl8acjbCZ8DNIZVj9c5hUoqxoxLMV34jH6j9X654eZrro9r/qzYdL oFWu2kEbPRO/n1rcPc7HGLVEIIOtZVWmSIogUOF9pQlGhXDFswPUGxgp1gt8mfKr/Puj4aBrmD51d UAIFqzSdM50HKO55pfWFaDZhOzJK2lHPKt5T2PLRY3RBTPMp8O0hmgg120hslETSO2D5cHXGReil0 QFGQ5VlQ==; Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by casper.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQnVr-0007SP-Pu for linux-arm-kernel@lists.infradead.org; Fri, 09 Oct 2020 08:12:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=kEaJrhB49jY9ylGi747PC2d3zrqsG3GTNHlV2nr1xSo=; b=ve8cCGYklFqGLKtG5GkwJljNv a3hbBRQkLbNvUxGBvRLjfgm8UYZTG64wt/m0NgpJL8GTh+fmKL5e1YuiE6RUMJY5IHvRBitFMV07P VuNeBlLoz8yJ1U/X7/zi8hIcCw40aQddMK62i2TCOL5Zfzf9AZm9SaKhMGUJ/L4wa/s+hpbT/geGr 6znwoJ9jU6CJGyPnlmntqiuNeh9en5i/iQG4MSe6taT2anM9hRQKfv7pj9V8W5032KYMHT69wpH8d xZYErn38o1U5L5szCdPa0oEpo3tZl2PwQz13EyumuR3WeGrImdHMt1pDLD9Xu8UkpPKcV+audPxof qWK9gP5hA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:43798) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kQnSR-0007iv-PC; Fri, 09 Oct 2020 09:08:55 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1kQnSM-0002VN-ES; Fri, 09 Oct 2020 09:08:50 +0100 Date: Fri, 9 Oct 2020 09:08:50 +0100 From: Russell King - ARM Linux admin To: Xiaoming Ni Subject: Re: [PATCH] arm:traps: Don't print stack or raw PC/LR values in backtraces Message-ID: <20201009080849.GM1551@shell.armlinux.org.uk> References: <20201009075957.110017-1-nixiaoming@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201009075957.110017-1-nixiaoming@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201009_091228_085342_4C0A9F08 X-CRM114-Status: GOOD ( 13.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: wangle6@huawei.com, walken@google.com, amanieu@gmail.com, dima@arista.com, bigeasy@linutronix.de, vincent.whitchurch@axis.com, linux-kernel@vger.kernel.org, mingo@kernel.org, ben.dooks@codethink.co.uk, tglx@linutronix.de, viro@zeniv.linux.org.uk, jpoimboe@redhat.com, luohaizheng@huawei.com, akpm@linux-foundation.org, ldufour@linux.ibm.com, will@kernel.org, christian.brauner@ubuntu.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Oct 09, 2020 at 03:59:57PM +0800, Xiaoming Ni wrote: > Printing raw pointer values in backtraces has potential security > implications and are of questionable value anyway. > > This patch follows x86 and arm64's lead and removes the "Exception stack:" > dump from kernel backtraces: > commit a25ffd3a6302a6 ("arm64: traps: Don't print stack or raw > PC/LR values in backtraces") > commit 0ee1dd9f5e7eae ("x86/dumpstack: Remove raw stack dump") > commit bb5e5ce545f203 ("x86/dumpstack: Remove kernel text > addresses from stack dump") > > Signed-off-by: Xiaoming Ni I am really not happy about this - it hurts at least my ability to debug the kernel when people post oopses to the mailing list. If people wish to make the kernel harder to debug, and are prepared to be told "your kernel is undebuggable" then this patch is fine. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel