From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EFCAC433E7 for ; Fri, 9 Oct 2020 08:50:59 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3CF3C22275 for ; Fri, 9 Oct 2020 08:50:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="xxXM/0/k" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3CF3C22275 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=OFrGSluPXop12kNky4eX1XyeTcw79Cb91KF1ANwkimY=; b=xxXM/0/kCZC1AVV5MH6B+HtK7 gFfsSpQYIXZHMlC+nB0dRtlcDBUuQHt+lO71CidMzLl4LH+j+HhglYKFOYfUiHHvwcC4Hgo/R/kAt hbhsiyT95Q0HJe0UseO4rWJ0+XjMytjrEvSrThntVU80pgR6VKR+O/oeQrOIg6ZX+WGWJe/5qsOYE 7jk8BrD14Em/EkQYcO343s85z1PLegii+7vMkxrjvoDNWr7wcDey0kgSQvBBRnI3VKyRdAYURC+to GfA25zuGNsO7ougRZ6cCVWA9UW9xIxr18N4407e/K8MnTm6sQqmDDaRfuTUjIWZUYbhi93SnBwdYK qcjZ3hihg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQo5Y-0006Rz-MD; Fri, 09 Oct 2020 08:49:20 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQo5W-0006RS-VM for linux-arm-kernel@lists.infradead.org; Fri, 09 Oct 2020 08:49:19 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 19159D6E; Fri, 9 Oct 2020 01:49:11 -0700 (PDT) Received: from e121166-lin.cambridge.arm.com (e121166-lin.cambridge.arm.com [10.1.196.255]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BBED43F66B; Fri, 9 Oct 2020 01:49:09 -0700 (PDT) Date: Fri, 9 Oct 2020 09:49:05 +0100 From: Lorenzo Pieralisi To: Jisheng Zhang Subject: Re: [PATCH v7 0/2] PCI: dwc: fix two MSI issues Message-ID: <20201009084904.GA16200@e121166-lin.cambridge.arm.com> References: <20201009155311.22d3caa5@xhacker.debian> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201009155311.22d3caa5@xhacker.debian> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201009_044919_059200_128A830C X-CRM114-Status: GOOD ( 18.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , Jingoo Han , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Kishon Vijay Abraham I , Gustavo Pimentel , Bjorn Helgaas , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Oct 09, 2020 at 03:53:11PM +0800, Jisheng Zhang wrote: > Fix two MSI issues. One to skip PCIE_MSI_INTR0* programming if MSI is > disabled, another to use an address in the driver data for MSI address, > to fix the MSI page leakage during suspend/resume. > > Since v6: > - Keep the IS_ENABLED(CONFIG_PCI_MSI) check in dw_pcie_msi_init(). > > Since v5: > - rebase on pci/dwc branch > - add Acked-by tag > > Since v4: > - fix pci-dra7xx.c > > Since v3: > - add Acked-by tag > - change patch2 commit msg to make it clear > - map the MSI msg with dma_map_single_attrs() for some platforms > which either has separate addrs for dma and phy or has mem access > limitation for the PCIe. > > Since v2: > - add Acked-by tag > - use an address in the driver data for MSI address. Thank Ard and Rob > for pointing out this correct direction. > - Since the MSI page has gone, the leak issue doesn't exist anymore, > remove unnecessary patches. > - Remove dw_pcie_free_msi rename and the last patch. They could be > targeted to next. So will send out patches in a separate series. > > Since v1: > - add proper error handling patches. > - solve the msi page leakage by moving dw_pcie_msi_init() from each > users to designware host > > Jisheng Zhang (2): > PCI: dwc: Skip PCIE_MSI_INTR0* programming if MSI is disabled > PCI: dwc: Fix MSI page leakage in suspend/resume > > drivers/pci/controller/dwc/pci-dra7xx.c | 18 +++++++++- > .../pci/controller/dwc/pcie-designware-host.c | 35 ++++++++++--------- > drivers/pci/controller/dwc/pcie-designware.h | 2 +- > 3 files changed, 37 insertions(+), 18 deletions(-) Applied to pci/dwc, thanks. Lorenzo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel