From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 211CFC433E7 for ; Fri, 9 Oct 2020 10:14:13 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8C7362226B for ; Fri, 9 Oct 2020 10:14:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="b0YIUPhp"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JIxKJHC3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8C7362226B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=iveTOiyh8LfBQYmbZPPrdtRwsWFL05sQhF0LNkqG61A=; b=b0YIUPhptlLqnGIAxlS7aC1Nh RVT7qkxZ6GXo7uujYnKH69Ao7cZRbI1tPXgEd/QwsRtBHh4KVE1CVtoqgNB78ecvwloejw6oyoE2q +5Y2y4NYLlZlII+7MvnAh8/pKj+tRB+211Ug9KWVhfvgZPLvpb4UQSmIyCcASVxamML+y+4nfbm/6 5CCt8zflvKXy9uycp3hFQ74EaZENmYcYs1pN+fpg8t5RH4UfRPA4pKHWhH1mZTQ2YQZV80sOefY6C SjCASkI7j3snXR5Vb3Qs4PlG8HwJ+SusE6ejazM5zvxWSxvKcs5NvzBkYgQep/4Fslztdpb/sVeQ1 Ku6ccCuOQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQpOJ-00088w-8B; Fri, 09 Oct 2020 10:12:47 +0000 Received: from mail-ej1-x642.google.com ([2a00:1450:4864:20::642]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQpOH-00088U-90 for linux-arm-kernel@lists.infradead.org; Fri, 09 Oct 2020 10:12:46 +0000 Received: by mail-ej1-x642.google.com with SMTP id h24so12264846ejg.9 for ; Fri, 09 Oct 2020 03:12:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Pu6uFYl5g3lWcF1Rf0VrnUrLJTa6VGuUqdl8E16TQmI=; b=JIxKJHC35w3/PF+7f04UAQOW8ZrXMCY89C4aZn0BU9wOCIWohsh5nFBNPbceAsv575 NUTUL6jIkD5JaokEejtHZPzRyCgHo77espaNNIsydVTc29T1Osv0+ZLqfKyny7E717t+ taqqYZylTX9LbGRW1tSCmHk/wOJBEvzEl4Prdq2hWQf05uB4Gs3Mivn22QdyVZNSO7IF k4ruanWe3DRCjzlRhHytK+RMOHhvKc9O+Q5rrbcWN7M5b2pFb8g1Rbh3BQ1BmSvl4eQg YlDL6b9DJso2CKzuotE7JFYusQbJ/BDFRzf5/n/FtO6l6RM+Bt+sQea7vgWhM8lJpjLs 1uow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Pu6uFYl5g3lWcF1Rf0VrnUrLJTa6VGuUqdl8E16TQmI=; b=HHOcGBpPNqL8Iz7YdHHS5p/c8b0UGn2IEirORG8bxQLwgBtQ6JB2XlbnYLMZalPlyE 9RDFEDI8LrHgSWpbwLSWRzH8Zh7vuFoBqkY6ebGDrlp67SFPHeYkZi6WxmTyS5Z5vEt3 BU/PEpkHvxnLzYCqelffg8SRo/sE7Uj04tIpx0qYGRfqT5ANozDMUsyjtHqEOhQGznLk +vD4hPGwaW1ruKBJjuDEQnOhMZhWEv3MTiOf1FFjwJLhcfXQXySihidocTE3Ze8re3Df 3NTLty+qvK5qOJRhl75A4J6ELY5g8UeHdbomEXcK/xuInhy7VAHxMI/iNlBBfXihVNjr LaBQ== X-Gm-Message-State: AOAM530mn6QxdaYqVJF9UrvjY7bdExz7HND/iSzBLiZJ5Z6x5RmsqQYW lOZiLG+Yqzmk+YBKbHhVsQc= X-Google-Smtp-Source: ABdhPJxp66T3ofOaQiKnvkErLduT7emZPOyZINsZU/nAVBl8G5RKHaZy40JF3sEcWbbrqCq6CWTBcg== X-Received: by 2002:a17:906:bc91:: with SMTP id lv17mr13978607ejb.249.1602238364034; Fri, 09 Oct 2020 03:12:44 -0700 (PDT) Received: from skbuf ([188.26.229.171]) by smtp.gmail.com with ESMTPSA id n22sm6012278eji.106.2020.10.09.03.12.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Oct 2020 03:12:43 -0700 (PDT) Date: Fri, 9 Oct 2020 13:12:41 +0300 From: Vladimir Oltean To: John Keeping Subject: Re: [PATCH] net: stmmac: Don't call _irqoff() with hardirqs enabled Message-ID: <20201009101241.qr6blbfyamtuzrwy@skbuf> References: <20201008162749.860521-1-john@metanate.com> <20201008234609.x3iy65g445hmmt73@skbuf> <20201009105945.432de706.john@metanate.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201009105945.432de706.john@metanate.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201009_061245_330001_48549236 X-CRM114-Status: GOOD ( 13.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Torgue , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, Jose Abreu , Maxime Coquelin , Giuseppe Cavallaro , Jakub Kicinski , "David S. Miller" , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Oct 09, 2020 at 10:59:45AM +0100, John Keeping wrote: > No, it's not, although I would have saved several days debugging if it > was! I backported the lockdep warning to prove that it caught this > issue. > > The evidence it is possible to see on vanilla 5.4.x is: > > $ trace-cmd report -l > irq/43-e-280 0....2 74.017658: softirq_raise: vec=3 [action=NET_RX] > > Note the missing "d" where this should be "0d...2" to indicate hardirqs > disabled. Cool, makes sense. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel