From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0F2AC433E7 for ; Fri, 9 Oct 2020 12:04:11 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5FFB622276 for ; Fri, 9 Oct 2020 12:04:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="xyhqJ/kk"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YfbEAEbo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5FFB622276 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=kL8jYbYaugRKzVLLBAlZiH0HF8GM2SGAr3tYTMFax6w=; b=xyhqJ/kkv6AmhhakVPHkqgz6s OSPYi8m0NYXgFOqLFkbIfqNUKFZ3NZg6g5bM8wGO3KXM3fI4h+h+ZBpCF3BzKogZ0GS2Ek+/Ik22q ipXK2RdIbg3ojdeNZIdozilm9TiO64P43SK6qR/ewp15bOVLQnfdFh4fXlJ+HB39VgBLEZmI8cbSD X5Q5OtnpRHelx5VyysNBLjenfTS7C9I2m8L/j5o9qJecDmg9cE8FYHhFsWsUVVbOShpcR0YVuok+A vqbFSM6o6F9gJs0w2AVtsk/g5VMlvrDUnRpvOmDeUAaUlirx4zJVoOIh52PxLJURM/tR7o5c9vImW W3u/QGHVg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQr6l-00058b-Fx; Fri, 09 Oct 2020 12:02:47 +0000 Received: from mail-ej1-x642.google.com ([2a00:1450:4864:20::642]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQr6j-00057i-GQ for linux-arm-kernel@lists.infradead.org; Fri, 09 Oct 2020 12:02:46 +0000 Received: by mail-ej1-x642.google.com with SMTP id md26so12663676ejb.10 for ; Fri, 09 Oct 2020 05:02:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=zolN42psdma9cgyAkYUk4jF1xLz7WxwwG5U5VW/benQ=; b=YfbEAEboe0LlibywYsM/2e1qf+oxGBVKypANBwYng7mBjrhtYCtROcCmXsFbvhD4gR GKSRsQGFfBnhdQcST9MR2IygYyPwQmfEJPdhFh9WOaz7RT2lZhNoaTm/ocoAc4C9yVy3 MEHk/ZrTaSq97VnaPY5Z4IowxWg4LXANXmEf6M8Id8fUj6FjoicFuiREIbssZNX41t2o NPWZHzsEu0rgPIPTJG4c9tIDWuHDaQ9pCb67B6eAosqlACPc1pfm1U+Vxmz0EKg+0BN0 3uWcqgS4vGs+XxhH9I4GNgGg1l0tIDzZELsqg23s/Q2sJcZoIO1+FrCs9rzlylh2xxAO Ym4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=zolN42psdma9cgyAkYUk4jF1xLz7WxwwG5U5VW/benQ=; b=HhQtaPVDkHnSkolf3iEY3BduQRoh5RsC4uXzCKmp3JCNEqKkbgzN6Gfc68S0bNGhgR jKQItI6cX91oGBCR2F23TlQtX26uAebAG3exHsz1pe/1hkE09VYu3lfjuhI5PTs6PUJx b5Bdz4YqsfDp7TvCgep7D7v+A+DIZExhxDtqLxM7g8QORTTeTr88HKfbF4+LSe7LgOsJ xtS9MmXG8egoy01I/2qiwUnfuVEhcuWUL6igVvQ6YTfpoqIlkXkWh/Sg5Xuof/nPpdu7 f+FC62jBtltb2l7CdxTrcM9CWuu/MTd5WlUINJ7GKdTX5Gug2J1DAqyyD8SpKCUCFI84 tP/A== X-Gm-Message-State: AOAM531WVzK0MW1SF8VPZ5UhJ6LtxBk/k/VAGcUqhbet2Y0DXyuqW7d/ a6vtTRgEdLKtZIpJulyG5VU= X-Google-Smtp-Source: ABdhPJyOOtJoZI+kdY3U7L8qipzhH3999ed2szrahFoKOii/NYr+woIDNUnOd1bDjNRyeni9sZXXWA== X-Received: by 2002:a17:906:f11:: with SMTP id z17mr14335685eji.88.1602244962713; Fri, 09 Oct 2020 05:02:42 -0700 (PDT) Received: from localhost ([217.111.27.204]) by smtp.gmail.com with ESMTPSA id h26sm20991edr.71.2020.10.09.05.02.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Oct 2020 05:02:41 -0700 (PDT) Date: Fri, 9 Oct 2020 14:02:39 +0200 From: Thierry Reding To: Krzysztof Kozlowski , Rob Herring Subject: Re: [PATCH] dt-bindings: pwm: imx: document i.MX compatibles Message-ID: <20201009120239.GA450876@ulmo> References: <20200925212609.23093-1-krzk@kernel.org> <20200926132217.xr3rhv7o2o2yc2l7@pengutronix.de> <20200926134157.GA4730@kozik-lap> MIME-Version: 1.0 In-Reply-To: <20200926134157.GA4730@kozik-lap> User-Agent: Mutt/1.14.7 (2020-08-29) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201009_080245_553357_5C2200DB X-CRM114-Status: GOOD ( 27.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pwm@vger.kernel.org, Philipp Zabel , devicetree@vger.kernel.org, Fabio Estevam , Sascha Hauer , linux-kernel@vger.kernel.org, NXP Linux Team , Pengutronix Kernel Team , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Lee Jones , Shawn Guo , linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============4015498678546500285==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============4015498678546500285== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="LZvS9be/3tNcYl/X" Content-Disposition: inline --LZvS9be/3tNcYl/X Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Sep 26, 2020 at 03:41:57PM +0200, Krzysztof Kozlowski wrote: > On Sat, Sep 26, 2020 at 03:22:17PM +0200, Uwe Kleine-K=C3=B6nig wrote: > > On Fri, Sep 25, 2020 at 11:26:09PM +0200, Krzysztof Kozlowski wrote: > > > Document all ARMv5, ARMv6 and ARMv7 i.MX compatibles to fix dtbs_check > > > warnings like: > > >=20 > > > arch/arm/boot/dts/imx6dl-colibri-eval-v3.dt.yaml: pwm@2080000: comp= atible:0: > > > 'fsl,imx6q-pwm' is not one of ['fsl,imx8mm-pwm', 'fsl,imx8mn-pwm'= , 'fsl,imx8mp-pwm', 'fsl,imx8mq-pwm'] > > >=20 > > > Signed-off-by: Krzysztof Kozlowski > > > --- > > > Documentation/devicetree/bindings/pwm/imx-pwm.yaml | 11 +++++++++++ > > > 1 file changed, 11 insertions(+) > > >=20 > > > diff --git a/Documentation/devicetree/bindings/pwm/imx-pwm.yaml b/Doc= umentation/devicetree/bindings/pwm/imx-pwm.yaml > > > index 473863eb67e5..379d693889f6 100644 > > > --- a/Documentation/devicetree/bindings/pwm/imx-pwm.yaml > > > +++ b/Documentation/devicetree/bindings/pwm/imx-pwm.yaml > > > @@ -25,6 +25,17 @@ properties: > > > - fsl,imx27-pwm > > > - items: > > > - enum: > > > + - fsl,imx25-pwm > >=20 > > The driver actually used fsl,imx27-pwm to bind ... >=20 > Yes, most of i.MX drivers use only few compatibles but DTSes and > bindings use multiple of them. I was convinced during various talks > that the specific compatibles (so "fsl,imx6q-pwm, fsl,imx27-pwm") are > preferred than generic ones (so only "fsl,imx27-pwm"). NXP took it > to the another level creating compatibles for absolutely every flavor of > their CPU. And they mainlined it in DTSes... >=20 > The PWM is this crazy examples where, as you say, only two compatibles > are actually used for binding but DTSes uses more. Yeah, these new compatible strings all seem to be used in the kernel, so we might as well document them. That said, I did want to apply this patch, but that fails. Am I missing some other patch that you have sent out that touches this file? Actually it looks like this is because you've based this patch on linux-next, or perhaps the devicetree tree, because that contains commit d058717bdff4 ("dt-bindings: pwm: imx-pwm: Add i.MX 8M compatibles") from you that adds a couple more compatible strings. Probably best for Rob to pick this up, then: Acked-by: Thierry Reding Rob, here's a patchwork link for you if you need one: https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20200925212= 609.23093-1-krzk@kernel.org/ Although, looking at the devicetree-bindings instance version of that patch, I see that it's got a failing check attached (which looks like it can be ignored) and it's marked "Changes Requested", but no comments saying so. Not sure if you want anything done here? Thierry --LZvS9be/3tNcYl/X Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAl+AUV0ACgkQ3SOs138+ s6GruA//Q7r7bNJZL47x1vSaTR4zkcAYsKCuqYy6PqiK0Q6pBhnqexL/uIoWYnBY 5DIdnKQ5pvqothENJqYdE2shjDPiryZRUGxWK/49r5GijYFHYaVaohcRG2uPOYeA yETDTXkXAnU0iJntJ6Vpn8FI38GOHThVPJLZ+MCsEVz4FLWtUpKWjHA8EIPhuLpB 6S/N1q1HZYiSUYwp6lAusxQ3Vjt+miVapKPib9U70sBfUi8ay3aaZPoYQlCp4/PW o05A3xZ5805jWfESWnQPFaQdeV742LttOI5RKxhAabj0SC9vOKycSp6xC12K9pH5 O60NFmbJLSm8jush3Wcy/6CrqHyXwEtbArxHf39sb2bGwVqWNrgjZ6o/O96Qv0dy EF0yZ+1XgPaVujtRGS/wa4moO7T6MaqxnJE6/CsTGnwBtLRg0qXTenzvP00TSptT lS/qNG2+qsCIkOpcJmiHjJVNHVWfPvHfIbapXYs9nixF5YBuPnB1nJiqRIUQW5kA 51X4WlrXfcxyX6HQt8/OucDqfUpIgP1tXW6rzmtGYZnx+QQWdsFwFHuX0OAXWNlO f38ix6JcF7YX1iV9tCs+OlrQq0Dc9JQrOwrEd1Q0SBX8T2NcWw269DOVwQOYoEO7 gpbc6UNU5cd6Br6PSbY2ccD7X1vu3VZ6G7EQOcMXh5Eyzzp1LdU= =AcBK -----END PGP SIGNATURE----- --LZvS9be/3tNcYl/X-- --===============4015498678546500285== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============4015498678546500285==--