From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABFEFC433E7 for ; Sat, 10 Oct 2020 11:11:09 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 604612222E for ; Sat, 10 Oct 2020 11:11:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="NWLQ6Kcj"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="0z0W8fNw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 604612222E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ONHoWn4cSk7bFA3neIavzO7iMkjlyP0BiCvNy5UWPC8=; b=NWLQ6KcjEWXmecaSR9PSnlQ9e BkYz0z9ZG/NpR8r2i/96hj361X6+N/oYiCZ/IFinM4cadybYDckZpOU52AbwAQkGObE4/yCY8+nac BjsQ0GW6Gae6Zquidm+hAuzvmL4j28H8Fh5cx4Nu0/R/7QRzpdghL7HaBXVlMGNI5CFJ+1HtWxrph VqeE2IvvZOf95AAwSDeoMoupo2EYg4qGVpYLdqjqZcslt1EIa5daaPsQlsVOu4Qn+hvDUe0Slshdu Z4r9arZpyRli5lTpUvhJ965a9yFK2MyjnXq69BXE8NhXBpbDPuDUMU68b14WVuFVg4gs6J8/cmfqR isGAaA9FQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kRCl3-0003XD-0N; Sat, 10 Oct 2020 11:09:49 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kRCkz-0003Vr-T7 for linux-arm-kernel@lists.infradead.org; Sat, 10 Oct 2020 11:09:46 +0000 Received: from localhost (p5486c996.dip0.t-ipconnect.de [84.134.201.150]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4FAFF221FC; Sat, 10 Oct 2020 11:09:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602328185; bh=uQHAiDa6UwVzkeCNcXIht55Jnp6noC/hcJNuIPqmHCI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=0z0W8fNw4fEhhciSCnPL+grc2lVTijBpwyFLBjDvdKH1g6Hsfviwtw9WzcLRa8erQ iz5uYhPXdUa49k98N/TQOkCKLoULKVqwnSWpSLfxlJLrkTynwPe1yrBx+nC9AYyhWL 80JkjDpLcPpXIy8QCbKnQl0xJqEPFoxyRL0Pj0lM= Date: Sat, 10 Oct 2020 13:09:37 +0200 From: Wolfram Sang To: Christian Eggers Subject: Re: [PATCH v6 3/3] i2c: imx: Don't generate STOP condition if arbitration has been lost Message-ID: <20201010110937.GD4669@ninjato> References: <20201009110320.20832-1-ceggers@arri.de> <20201009110320.20832-4-ceggers@arri.de> MIME-Version: 1.0 In-Reply-To: <20201009110320.20832-4-ceggers@arri.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201010_070946_026786_617203F8 X-CRM114-Status: GOOD ( 14.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fabio Estevam , Sascha Hauer , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Oleksij Rempel , Oleksij Rempel , David Laight , NXP Linux Team , Pengutronix Kernel Team , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , stable@vger.kernel.org, Shawn Guo , linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org Content-Type: multipart/mixed; boundary="===============0248654847143976954==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============0248654847143976954== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Km1U/tdNT/EmXiR1" Content-Disposition: inline --Km1U/tdNT/EmXiR1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 09, 2020 at 01:03:20PM +0200, Christian Eggers wrote: > If arbitration is lost, the master automatically changes to slave mode. > I2SR_IBB may or may not be reset by hardware. Raising a STOP condition > by resetting I2CR_MSTA has no effect and will not clear I2SR_IBB. >=20 > So calling i2c_imx_bus_busy() is not required and would busy-wait until > timeout. >=20 > Signed-off-by: Christian Eggers > Tested (not extensively) on Vybrid VF500 (Toradex VF50): > Tested-by: Krzysztof Kozlowski > Acked-by: Oleksij Rempel > Cc: stable@vger.kernel.org # Requires trivial backporting, simple remove > # the 3rd argument from the calls to > # i2c_imx_bus_busy(). Applied to for-next, thanks! --Km1U/tdNT/EmXiR1 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAl+BlnEACgkQFA3kzBSg KbZqtw//b4hEFkfLFb1etf0/EeQm4uXhVbUaXFusSVs5rfpiSQo73CrMk4DoL2uv K3QyXs4hXYVx9n976MRbAHGF3Epo74HnVyij6RxIgdQYLzmYHdy5XnDRJCvFFZIm nQzSPaQ67CNOgxn4+r7tpFeX9Ap094ewIpms/OjJbv0JKDuBWuoBf52e+UAuqtpw FnfKMJtA6zsC/cbWW1O7kwJylxVdExChZ2x+yByeDV+p4y+M4xL6dUGkz13uVorX OTxnCfQgsgouhwrxC+cWvb7y37hbu4zGwmTjTsKHYSR/IhQ/NRCDq6x94nXauYT6 CpaqqikT+aqeq6reO5wCd/ci3IiZOlAwAXBQdsaJav0N9dsvzxOetggM/uXAvkIH C+HDyMiZJib2pFGkdmmF4P+mdgmqCuXwWdvnOO2mqnk17VHva8js/FhJPgW84bA+ O4bMbofkVJNeOLTnXvnikVwXNVz02C/XUiAPq4PEhMPWNGLgaoHuBngDwghxQR2K 8GaGrQ968GAkimnTsMl8wIsimxUkFiwGTxHKm6p1cs4Ekmr14aeiVmXOmFzRKmLa aJQ/uy/U+mo+YMoBobROlomjAZP/GfplxgWtCIu79apQg6fZZ5ivnG8XEG/CD3zX KS9MkYPdTSd7fXqBMUkIoIUa+sllE87Yr6prvHiRaxrAPVf2tKg= =+4FV -----END PGP SIGNATURE----- --Km1U/tdNT/EmXiR1-- --===============0248654847143976954== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============0248654847143976954==--