From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0379AC433E7 for ; Sun, 11 Oct 2020 14:11:22 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A12892074F for ; Sun, 11 Oct 2020 14:11:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="U//49JV2"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="rNjTBjkw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A12892074F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hf2Gi1Xinu6HlIlLmXMqChFfiDxtHopVYFL8ebckTlE=; b=U//49JV2MsnHn7vwvLdPMnMKE dk0D6wBNU3Ehyn2RdY03tYMZqcQJYENEahgxn7EDZlQfk+nPQ8WAjWclVkyskqZrROEb9j2SIcRxc KRAMb++VmYZrmb25WBTsmMKqyPROaEc9ZoPS+nEhMKD1cxE6VEGyu4U51Xv2Ub+ca8drFNWd3D9y5 k5LI//Jz8uwDp/DReIrU+0NrufItE97mXQKF+g5BrEPBTE4DBs0GaIqp24c6bxNR8NUCtXcaxFCWk pRVySIrcbUOo8MSwrXsZxcZz75s7gMmgwYpsm8pdKc7oACcwnr3CJo+q96TZvcGtDqrgTCz+9Shpo jEQXboJQA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kRc30-0007Mx-7d; Sun, 11 Oct 2020 14:10:02 +0000 Received: from mail-pf1-x444.google.com ([2607:f8b0:4864:20::444]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kRc2w-0007Lj-IG for linux-arm-kernel@lists.infradead.org; Sun, 11 Oct 2020 14:09:59 +0000 Received: by mail-pf1-x444.google.com with SMTP id b26so11042230pff.3 for ; Sun, 11 Oct 2020 07:09:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=2E9XTdrHAfZUqvjslXmJY0A7DhqJxtr460qjTU+91kY=; b=rNjTBjkwz+MbIKTFKdCIdDRH1DaFfybQie5gGjmzEgrOqp80k4jIFZUgsm8hcbA932 v7U9yZ9lPF6rEyK1R4M8Wj0kuPCs1U9sbn8EYBjnpj4Jm9LbCC2pKAvkmCzZI1uigpdv A7etPkqlwyJr5JQTvU6Ji5pVqnxsYZD5Nbp7M1rVaPBY5dfgWUNtqX94nw/z+9JDuI4k XgoKMV0F8xSdPsmKkCxPL/RQqys2dqWCUYqgodTyAqfDN/Ka1nNyEAAsJ8WBasuWjXUe /Op8H3lupaUa7c/viBSsxSK6JDqTWdt8FYgzQlZC/r9MptfuURZzKdDiM1eLom4S9N7f ELEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=2E9XTdrHAfZUqvjslXmJY0A7DhqJxtr460qjTU+91kY=; b=qY67IU+bkXfaYZSUdRkhsdSfyCbD5JSWCndK/MovDVe4n/bTn2Xwm/iRJRCIW13qsO azRf+44KWbqjybobLaL141aD2pKHJ1jAhVvGpa+YVsA0U8IM+I1/Qt1hbxocdjC+799z JTkkFOzCZA1bswrTLnkTZUxynd8pOms/AWO2aByFJXFmU7Bao5etOzY2rLrKVZQQYAk8 DbfM8edo6NXXjmGk4dL+awHBDsXwfqdSQ3Fmhw/VhaZdiN3s0ZBOfQtinvqWmIXFFvlB cZQJjCFwiZOaE8sK0++U39eD5Gyi5Ew/HrQZuiuGG01LWRTR6WutAjc/SgKRsBBnsj58 YTgQ== X-Gm-Message-State: AOAM53101f4UYHwuY9n9r09Gx4TBJaA22uMD+H4Wx2ZAnZetZ6wU11/N rpN1V1MZuoFOeBccy0gbtg6W X-Google-Smtp-Source: ABdhPJyXI0tF8lDCqKYKUSLlQfExO7ycqASahIKocXscd1x1LxKbXNxhA3FyHuqn/MEzsmKx44yucQ== X-Received: by 2002:a62:b417:0:b029:142:2501:35dc with SMTP id h23-20020a62b4170000b0290142250135dcmr19479541pfn.60.1602425396445; Sun, 11 Oct 2020 07:09:56 -0700 (PDT) Received: from Mani-XPS-13-9360 ([2409:4072:28d:c562:841e:ecfd:8468:c018]) by smtp.gmail.com with ESMTPSA id gi20sm19355467pjb.28.2020.10.11.07.09.51 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 11 Oct 2020 07:09:55 -0700 (PDT) Date: Sun, 11 Oct 2020 19:39:48 +0530 From: Manivannan Sadhasivam To: Cristian Ciocaltea Subject: Re: [PATCH 1/3] i2c: owl: Clear NACK and BUS error bits Message-ID: <20201011140948.GC4971@Mani-XPS-13-9360> References: <6ee573f2904c001ab07e30b386815257c05f6308.1602190168.git.cristian.ciocaltea@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <6ee573f2904c001ab07e30b386815257c05f6308.1602190168.git.cristian.ciocaltea@gmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201011_100958_665345_961500F8 X-CRM114-Status: GOOD ( 19.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org, Peter Rosin , Wolfram Sang , linux-i2c@vger.kernel.org, Andreas =?iso-8859-1?Q?F=E4rber?= , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Oct 09, 2020 at 12:44:39AM +0300, Cristian Ciocaltea wrote: > When the NACK and BUS error bits are set by the hardware, the driver is > responsible for clearing them by writing "1" into the corresponding > status registers. > > Hence perform the necessary operations in owl_i2c_interrupt(). > > Fixes: d211e62af466 ("i2c: Add Actions Semiconductor Owl family S900 I2C driver") > Reported-by: Manivannan Sadhasivam > Signed-off-by: Cristian Ciocaltea Reviewed-by: Manivannan Sadhasivam Thanks, Mani > --- > drivers/i2c/busses/i2c-owl.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/i2c/busses/i2c-owl.c b/drivers/i2c/busses/i2c-owl.c > index 672f1f239bd6..a163b8f308c1 100644 > --- a/drivers/i2c/busses/i2c-owl.c > +++ b/drivers/i2c/busses/i2c-owl.c > @@ -176,6 +176,9 @@ static irqreturn_t owl_i2c_interrupt(int irq, void *_dev) > fifostat = readl(i2c_dev->base + OWL_I2C_REG_FIFOSTAT); > if (fifostat & OWL_I2C_FIFOSTAT_RNB) { > i2c_dev->err = -ENXIO; > + /* Clear NACK error bit by writing "1" */ > + owl_i2c_update_reg(i2c_dev->base + OWL_I2C_REG_FIFOSTAT, > + OWL_I2C_FIFOSTAT_RNB, true); > goto stop; > } > > @@ -183,6 +186,9 @@ static irqreturn_t owl_i2c_interrupt(int irq, void *_dev) > stat = readl(i2c_dev->base + OWL_I2C_REG_STAT); > if (stat & OWL_I2C_STAT_BEB) { > i2c_dev->err = -EIO; > + /* Clear BUS error bit by writing "1" */ > + owl_i2c_update_reg(i2c_dev->base + OWL_I2C_REG_STAT, > + OWL_I2C_STAT_BEB, true); > goto stop; > } > > -- > 2.28.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel