From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C85FC433DF for ; Sun, 11 Oct 2020 19:05:11 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 223DC2078A for ; Sun, 11 Oct 2020 19:05:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="h1v++H+v"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ecUzN/Y2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 223DC2078A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2wV+Nt0Y3YitwxkKE/5TCnYgDa/XB8kvWJYq6kJS8cE=; b=h1v++H+vq4Vsig5HPBQcTqAc7 bAWL0R2v5bhWzgSxaIvwRWFuTPW2b/5e6nlbbYBkTJtvG+lGSKCyTShbiZLriFIzwyKgHhAXT8J6Z cHymqO7LMqA2Cos5C2vsh1CZrOgTFvBSlVn7fXQa8peyNfM6B6Mq7OcuAGwvgApeh+FZEH3FCv8OM Qw26mpc9L74Ebh5BzUI/oyDY+2ifO9uc3kzrk05wfJ96dFTM9dCRqy7FK0B3S28BhOMMtG0X6tsKQ a2B+tpIMsq9NfdYI4p/+OlEgq+Ql1X78/xc28GhsRdnwAd2udyyRP1iWA+QltgWJB32iZOK2ax5fc QV5M+sg+A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kRgd6-0007Ca-17; Sun, 11 Oct 2020 19:03:36 +0000 Received: from mail-oi1-x242.google.com ([2607:f8b0:4864:20::242]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kRgd3-0007C2-Fr for linux-arm-kernel@lists.infradead.org; Sun, 11 Oct 2020 19:03:34 +0000 Received: by mail-oi1-x242.google.com with SMTP id t77so16424421oie.4 for ; Sun, 11 Oct 2020 12:03:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=yHtnE/V52IDcckuvY5tih+ml1RcygXz06+BOJ8YunTE=; b=ecUzN/Y2fFPyBq+CAonoTQZAp6EbypqdGrCG6p9IGiSPQyvL6noOfEmT6mqUU/FJhw SR/IDio/HsqH/uzorc+KYbGr1WcxnGEmiqdjHwI8qOQfvgBhCgKCUvnjVWK6LAR2Pd/a AbfyznsanNLBaViUHKxCQ9hLxwRcB5DPvmNWKZqG+1E3mvRFD91thtuKwUgwMMLdxIzM 7WyLXcF8kPzzzfL26D3bknQ/rTRJnvyRa/IKhDPpqxMOj349yQi+0pNHMHJEEMR28MJk IQMXxuWQXtWOkERCevrHHFU6xx9wgZWnuNFP2mHVI7bS5Z7yFUjCoo09gi0xkP0qjK0O UKUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=yHtnE/V52IDcckuvY5tih+ml1RcygXz06+BOJ8YunTE=; b=RN+vmBzePcIMZHdyDPM7cCSk+jJjoQY1s46TChirW6uwgj7mGW6iATMIo/tcYl6FoA fGIE0SigfASqAlRLwUA4l00dxL3BlcJcCVM34HBe5wCann1Bb3iY/XEZzSgpB7V0jaHw D1PFT+03gDgDLFs/3RFs4rHdrwfsqF3conDCLG2fzU5Qvk5KYw9ORDwQI47XLm3/QaJV SZf3ZJrTQCOnu3fs79TgPDVPBnpM+L0V81VXRdLxJ5GIU1ryz13V8NuvCFLsE8Sy/Qug 1UI92ML9MBycUJPbon8CGKA0pdbG4gqz18Htey+MV4/QONTrCUq3JBp6hUqfbwy7zo1N cYtQ== X-Gm-Message-State: AOAM532BFkv6GgQ3atNHYpy9kqEHruFERjSV54FwbfmBTS/yML4t8R7k dInYywSlXCZIn48XAP//TlM= X-Google-Smtp-Source: ABdhPJxBGMHIkKKvYUBtQUiqyp9AUxBqpVne/JRhUcwYjxDxZlXHUWWkLGZ8oz6q1A7KEs/0lXltsA== X-Received: by 2002:a05:6808:3bc:: with SMTP id n28mr6705173oie.171.1602443011771; Sun, 11 Oct 2020 12:03:31 -0700 (PDT) Received: from localhost ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id d22sm8882591oij.53.2020.10.11.12.03.30 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 11 Oct 2020 12:03:31 -0700 (PDT) Date: Sun, 11 Oct 2020 12:03:29 -0700 From: Guenter Roeck To: Anson Huang Subject: Re: [PATCH V3 1/4] gpio: mxc: Support module build Message-ID: <20201011190329.GA119453@roeck-us.net> References: <1600320829-1453-1-git-send-email-Anson.Huang@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1600320829-1453-1-git-send-email-Anson.Huang@nxp.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201011_150333_573699_6472A9C9 X-CRM114-Status: GOOD ( 26.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peng.fan@nxp.com, geert+renesas@glider.be, catalin.marinas@arm.com, linus.walleij@linaro.org, bjorn.andersson@linaro.org, oleksandr.suvorov@toradex.com, michael@walle.cc, will@kernel.org, hverkuil-cisco@xs4all.nl, linux@armlinux.org.uk, krzk@kernel.org, bgolaszewski@baylibre.com, andreas@kemnade.info, joel@jms.id.au, Linux-imx@nxp.com, s.hauer@pengutronix.de, prabhakar.mahadev-lad.rj@bp.renesas.com, lkundrak@v3.sk, festevam@gmail.com, linux-arm-kernel@lists.infradead.org, aisheng.dong@nxp.com, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, leoyang.li@nxp.com, vkoul@kernel.org, kernel@pengutronix.de, olof@lixom.net, shawnguo@kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 17, 2020 at 01:33:46PM +0800, Anson Huang wrote: > Change config to tristate, add module device table, module author, > description and license to support module build for i.MX GPIO driver. > > As this is a SoC GPIO module, it provides common functions for most > of the peripheral devices, such as GPIO pins control, secondary > interrupt controller for GPIO pins IRQ etc., without GPIO driver, most > of the peripheral devices will NOT work properly, so GPIO module is > similar with clock, pinctrl driver that should be loaded ONCE and > never unloaded. > > Since MXC GPIO driver needs to have init function to register syscore > ops once, here still use subsys_initcall(), NOT module_platform_driver(). > > Signed-off-by: Anson Huang This patch made it into linux-next, but none of the other patches in the series did. This results in a variety of boot failures in -next. Not that it is my concern, but "without GPIO driver, most of the peripheral devices will NOT work properly" makes me wonder if building this driver as module is really expected to work anywhere. Guenter > --- > no change. > --- > drivers/gpio/Kconfig | 2 +- > drivers/gpio/gpio-mxc.c | 6 ++++++ > 2 files changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig > index 5cfdaf3..c7292a5 100644 > --- a/drivers/gpio/Kconfig > +++ b/drivers/gpio/Kconfig > @@ -397,7 +397,7 @@ config GPIO_MVEBU > select REGMAP_MMIO > > config GPIO_MXC > - def_bool y > + tristate "i.MX GPIO support" > depends on ARCH_MXC || COMPILE_TEST > select GPIO_GENERIC > select GENERIC_IRQ_CHIP > diff --git a/drivers/gpio/gpio-mxc.c b/drivers/gpio/gpio-mxc.c > index 64278a4..643f4c55 100644 > --- a/drivers/gpio/gpio-mxc.c > +++ b/drivers/gpio/gpio-mxc.c > @@ -15,6 +15,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -158,6 +159,7 @@ static const struct of_device_id mxc_gpio_dt_ids[] = { > { .compatible = "fsl,imx7d-gpio", .data = &mxc_gpio_devtype[IMX35_GPIO], }, > { /* sentinel */ } > }; > +MODULE_DEVICE_TABLE(of, mxc_gpio_dt_ids); > > /* > * MX2 has one interrupt *for all* gpio ports. The list is used > @@ -604,3 +606,7 @@ static int __init gpio_mxc_init(void) > return platform_driver_register(&mxc_gpio_driver); > } > subsys_initcall(gpio_mxc_init); > + > +MODULE_AUTHOR("Shawn Guo "); > +MODULE_DESCRIPTION("i.MX GPIO Driver"); > +MODULE_LICENSE("GPL"); _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel