From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A7C6C433DF for ; Mon, 12 Oct 2020 09:33:47 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9CD0620776 for ; Mon, 12 Oct 2020 09:33:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qMUbGaCA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9CD0620776 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=roWRFkE7D/NxNYf8e7m+898C399v2QKZoV/sv3x1RdE=; b=qMUbGaCAYvar5KJ8rVQ1MNF3r sNNcFxaueNlP3VfCpKRtdaiM0mYGqG3EvJmA2EKcrQl95Pu4UIY9xC5YP2Nqc/uLgOuOGqrauVr4v J1eGD/scSXKvzlBAuMUrq12LGJUoqImMCLOwqWqTBXcQcLs/YdpjyIQXwdtb1Ddeut+5FMx9lDlm7 Y3zHUUdbNEpV8JBV6POZcUfJHiTO1nJWvaKTbXst0Tbt6FvvMc4UVHLG/NQ/9i2VJ8Cu2JyQ91GEG 0XcL8xd8ZIIXCBYdRO+KfjXOCNyA6gT70R+dDKxXS+BNuOUPKmIxoEnzbYjEJAmMb0/CnVqPQykfF VlmSg69Rg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kRuBx-0002Vw-Mf; Mon, 12 Oct 2020 09:32:29 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kRuBu-0002Ux-Ag for linux-arm-kernel@lists.infradead.org; Mon, 12 Oct 2020 09:32:27 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 71F7D31B; Mon, 12 Oct 2020 02:32:25 -0700 (PDT) Received: from bogus (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 58E223F66B; Mon, 12 Oct 2020 02:32:24 -0700 (PDT) Date: Mon, 12 Oct 2020 10:32:12 +0100 From: Sudeep Holla To: Etienne Carriere Subject: Re: [PATCH 1/5] firmware: arm_scmi: always initialize protocols Message-ID: <20201012092827.GB16519@bogus> References: <20201008143722.21888-1-etienne.carriere@linaro.org> <20201008191727.ht26r5dnh3iwqj5n@bogus> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201012_053226_415989_38F1D02B X-CRM114-Status: GOOD ( 23.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Souvik Chakravarty , linux-kernel@vger.kernel.org, "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , Sudeep Holla , Vincent Guittot , Cristian Marussi Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Oct 09, 2020 at 02:31:55PM +0200, Etienne Carriere wrote: > On Thu, 8 Oct 2020 at 21:17, Sudeep Holla wrote: > > > > On Thu, Oct 08, 2020 at 04:37:18PM +0200, Etienne Carriere wrote: > > > Remove the IDR replacement that prevent initializing an SCMI protocol > > > when it has already been initialized. This is needed when there are > > > several SCMI agents that do implement a given SCMI protocol unless > > > what only the related SCMI protocol communication is initialized only > > > for first probed agent. > > > > > > > Can you please elaborate on your usecase please. What do you mean by several > > SCMI agents here. OSPM is the only agent we are interested here. What > > other agents is this driver supposed to handle here. We allocate memory > > in init and calling init multiple times messes up the allocated and > > initialised structures. > > > > So NACK for this patch as it needs more work if we need this at all. > > > > Hello Sudeep, > > Considering a device with several SCMI servers spread over several co-processor > and possibly also in the Arm TZ secure world, each of these servers > uses a specific SCMI channel. Without this change, each SCMI protocol gets > initialized only for the first agent device that is probed. > Fair enough, but it also adds complexity. Do you have a master SCMI server implementation in that case. As some protocols like system might need to be broadcast to all servers and master server needs to take appropriate action. > My setup is also a bit specific. My device has several secure configuration > features that can individually be enabled or not. For example, configuring > domain X as secure makes some clocks reachable by Linux only through SCMI, > and configuring domain Y as secure makes other clocks reachable by Linux > only through SCMI. For flexibility, I expose domain X resources (here clocks) > to an Linux agent whereas domain Y resources (here clocks also) are > exposed to another agent, each agent with its specific transport/channel. > Enabling each agent node in the Linux FDT allows to define which SCMI clocks > get exposed and hence registered in the kernel. > Without the change proposed here, I cannot get the clocks exposed to both > agents when enabled as the SCMI clock protocol is initialized only for the 1st > probbed agent device. > OK, as Cristian has already mentioned we need to clean up a bit on these initcalls and Cristian has some WIP patches, I would like to wait and look at them instead of breaking other usecases with patch(multiple devices per protocol within one scmi server) -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel