From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 602AEC433DF for ; Mon, 12 Oct 2020 13:06:11 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DD2902073A for ; Mon, 12 Oct 2020 13:06:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lpu+fMIG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DD2902073A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=sauKNTdtsZE71Aoc/vrqpIN3oB8Vo7pTIF/m9LzM8jM=; b=lpu+fMIGty+6Vb+E1Lef8oWGe K/z0jUEzfbgjfDtJJd3mPsKJvk/J4yHj+ggb0vcjb9m56hq1zFlU6omHBe5FGwAz97oT70LztvhWu aN/Id3KGzd3bJojOp1yr9e1fodDXixy/hi0lkidH0tWsnEs8vmc8jg074S9fCFb7oS1MJJ1jJTiuF t69RZlOBE/xe7I5RqF+thRQlQshyKSdGgFRiODrPgD8kPiTOckT8GeWvRQ/+0C5ZKPNjaCafdspnE DedkCpuvHccr2jJ4rxmQVV0JQ9ewoGhUr/cti3AVEnSDlMiASpljWKfN1Qa/OsQiiy5uzmOAlC1o9 fow0o8mBQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kRxVS-0001PZ-Kx; Mon, 12 Oct 2020 13:04:50 +0000 Received: from mail-ej1-f65.google.com ([209.85.218.65]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kRxVP-0001P4-Tt for linux-arm-kernel@lists.infradead.org; Mon, 12 Oct 2020 13:04:48 +0000 Received: by mail-ej1-f65.google.com with SMTP id c22so23103193ejx.0 for ; Mon, 12 Oct 2020 06:04:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=mBSC1L14aODojvS84MshxRPw6wp9K3Se6pbpNxJH76o=; b=DoAYYZoOnn1ZEaoQZNOcccVxtKmxEEQN7+PNrzD4sWvssP8L+G9OuBtv5ns0nI8WM5 +YPhSFi/T8e0cIeLTua/Pk0NUgI/mlwneJGsQUp+tW+1RZI3grGt3ixoXx/UYgog2IMr 5GAuIrLrBB9Ue/9qn2LoxEdvtsbIDyXKTmpg3OHcnCu6gzIseHJMBH5qy/6zC3b6LwEE 25fOLAsBnoi9EyZVjRTUmes8eHt9SYRoEcfmrTx7kIqLQlMPmOHvCZ6tfdVG2kDKfXnU TO+f3S0K/uURr2dlBZfKRapNuCCqHpXDZr8soMC2EV7YO3KO93hIeDAcasBbAHdkC8Ef aquA== X-Gm-Message-State: AOAM533lR/4S4E3paBNZBRT8fGLFvXNhb6eN1f9Y8oA3Q1KrGoci6E1h QbcgDBEl7RctxN95IpMxhcE= X-Google-Smtp-Source: ABdhPJyrBRuKfwAvIEb0BAfwEfuiA4d9/Ym01zd/j4aP5SQ43xyQOlj21q/KSm2l3xcMXWDjeRkEmg== X-Received: by 2002:a17:907:20e6:: with SMTP id rh6mr27243130ejb.169.1602507885060; Mon, 12 Oct 2020 06:04:45 -0700 (PDT) Received: from kozik-lap ([194.230.155.215]) by smtp.googlemail.com with ESMTPSA id v23sm10502289edq.86.2020.10.12.06.04.41 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 12 Oct 2020 06:04:43 -0700 (PDT) Date: Mon, 12 Oct 2020 15:04:40 +0200 From: Krzysztof Kozlowski To: Anson Huang Subject: Re: [PATCH V2 1/3] arm64: dts: imx8mm: Correct WDOG_B pin configuration Message-ID: <20201012130440.GA6468@kozik-lap> References: <1602506642-5262-1-git-send-email-Anson.Huang@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1602506642-5262-1-git-send-email-Anson.Huang@nxp.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201012_090447_978675_B314B6D3 X-CRM114-Status: GOOD ( 17.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: daniel.baluta@nxp.com, peter.chen@nxp.com, abel.vesa@nxp.com, devicetree@vger.kernel.org, festevam@gmail.com, s.hauer@pengutronix.de, linux-kernel@vger.kernel.org, Linux-imx@nxp.com, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de, l.stach@pengutronix.de, shawnguo@kernel.org, yibin.gong@nxp.com, aford173@gmail.com, shengjiu.wang@nxp.com, alifer.wsdm@gmail.com, jun.li@nxp.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Oct 12, 2020 at 08:44:00PM +0800, Anson Huang wrote: > Different revision of i.MX8MM EVK boards may have different external > pull up registor design, some are enabled while some are NOT, to make > sure the WDOG_B pin works properly, better to enable internal pull up > resistor. Since enabling internal pull up resistor is NOT harmful and > having benefit of flexibility on different board design, just enable > it for all i.MX8MM boards; And schmitt input is NOT necessary for this > WDOG_B output pin, so remove it; Open drain outputs provide more > flexibility to a designer as they can be pulled-up to any voltage found > in the system, so enable it as well. > > Signed-off-by: Anson Huang > --- > Changes since V1: > - Provide more explanation of removing schmitt input and enabling open drain in commit msg. > --- > arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi | 2 +- > arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi | 2 +- > arch/arm64/boot/dts/freescale/imx8mm-var-som.dtsi | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel