From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E60FFC43457 for ; Mon, 12 Oct 2020 14:03:35 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A8EF2206F4 for ; Mon, 12 Oct 2020 14:03:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="xPILH0m6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A8EF2206F4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=allwinnertech.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=c2VA3CXHKYR2/6fGqJze9IZoiDv5nnxu60UMIKpqg68=; b=xPILH0m6iJAho2sSp6ZrsVCkSM /Kaw8809Q0fqcXMjfxEldG8wobXWTthOPKhEFva/A/z4VpsloXiGRpHHmVOTE/tOdjQR/qbqnDMkt K6NBVmiQinjb8tSjRz/1CFEX9HCYw+Z/EqtEm+1kDm5gOFtraiwBivmkBmgjI9M4w5vnUGZD6q+Hg TzjRCx9TCREBd7XpR83728Ltwit7CaXaV+fpfMmNjG+e+g9IyjUIT17eYI5W8h0JLdGMlLSp/F73D yLhsUp/0XXwvH9k8IashRgn46b6SwmlWpUk0PTlYUezGRn1EFnjP9O4/Sipx9aqrCsXYS8ZLneN/3 710KRgNA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kRyP2-0006PG-0D; Mon, 12 Oct 2020 14:02:16 +0000 Received: from smtp2207-205.mail.aliyun.com ([121.197.207.205]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kRyOx-0006M3-58 for linux-arm-kernel@lists.infradead.org; Mon, 12 Oct 2020 14:02:14 +0000 X-Alimail-AntiSpam: AC=CONTINUE; BC=0.11137|-1; CH=green; DM=|CONTINUE|false|; DS=CONTINUE|ham_system_inform|0.00991924-0.0257103-0.96437; FP=0|0|0|0|0|-1|-1|-1; HT=ay29a033018047187; MF=frank@allwinnertech.com; NM=1; PH=DS; RN=8; RT=8; SR=0; TI=SMTPD_---.IiEJW-V_1602511313; Received: from allwinnertech.com(mailfrom:frank@allwinnertech.com fp:SMTPD_---.IiEJW-V_1602511313) by smtp.aliyun-inc.com(10.147.40.7); Mon, 12 Oct 2020 22:01:57 +0800 From: Frank Lee To: patrice.chotard@st.com, rjw@rjwysocki.net, viresh.kumar@linaro.org, tiny.windzz@gmail.com Subject: [PATCH] cpufreq: sti-cpufreq: fix mem leak in sti_cpufreq_set_opp_info() Date: Mon, 12 Oct 2020 22:01:41 +0800 Message-Id: <20201012140141.20296-1-frank@allwinnertech.com> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201012_100211_954831_52411475 X-CRM114-Status: UNSURE ( 9.45 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Yangtao Li , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Yangtao Li Use dev_pm_opp_put_prop_name() to avoid mem leak, which free opp_table. Signed-off-by: Yangtao Li Signed-off-by: Yangtao Li --- drivers/cpufreq/sti-cpufreq.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/cpufreq/sti-cpufreq.c b/drivers/cpufreq/sti-cpufreq.c index a5ad96d29adc..9668a48dad33 100644 --- a/drivers/cpufreq/sti-cpufreq.c +++ b/drivers/cpufreq/sti-cpufreq.c @@ -222,7 +222,8 @@ static int sti_cpufreq_set_opp_info(void) opp_table = dev_pm_opp_set_supported_hw(dev, version, VERSION_ELEMENTS); if (IS_ERR(opp_table)) { dev_err(dev, "Failed to set supported hardware\n"); - return PTR_ERR(opp_table); + ret = PTR_ERR(opp_table); + goto err_put_prop_name; } dev_dbg(dev, "pcode: %d major: %d minor: %d substrate: %d\n", @@ -231,6 +232,10 @@ static int sti_cpufreq_set_opp_info(void) version[0], version[1], version[2]); return 0; + +err_put_prop_name: + dev_pm_opp_put_prop_name(opp_table); + return ret; } static int sti_cpufreq_fetch_syscon_registers(void) -- 2.28.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel