From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFE85C433E7 for ; Mon, 12 Oct 2020 21:09:42 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3037C206CA for ; Mon, 12 Oct 2020 21:09:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="brem94dU"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="aKY2mjZq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3037C206CA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jayb877dyWhiLOxVWN9/pxN97Z7GJk/zJH8yp6ejofQ=; b=brem94dUKgjLBTe2yS1VcqrgP mW6l4gvLTASBFrDh4e9aUsnH6UNr82E0Zit5k7xjOr54Y808dyaRp9qOT9GDXCdiEdaEm677bTW4O nux7SqzF9QV9M97nMZ4+9qPxvZQMjJFiDBE5HX0su4v3P/b5ss9mFKTEO3B/G8QnPRaHXQTBBS/Ek wIRYY1Ay+fg6ZIs/aYigVIPULxnOfTl/tozI0mG56AP09UI2tN4DXaT3aiKHJpVWhswiKP4qeb2Au c3SK6PjEu7Vp68f2gWjLhEdH0HVsmbLheV5CeXF2zBTCgG6s1bKEadiuc03JUBwjKvx7dxO/hPeV7 8ZkEle1sQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kS53B-00055t-7R; Mon, 12 Oct 2020 21:08:09 +0000 Received: from mail-pf1-x444.google.com ([2607:f8b0:4864:20::444]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kS4xt-0002cY-11 for linux-arm-kernel@lists.infradead.org; Mon, 12 Oct 2020 21:02:49 +0000 Received: by mail-pf1-x444.google.com with SMTP id w21so14783528pfc.7 for ; Mon, 12 Oct 2020 14:02:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=SnB7E0mI9F7Ie4RlS2cFfqKwCDcopSImUj3IgUSKIxI=; b=aKY2mjZqZCjoAe1tt9s9T2FsyHGWEg2r94yXrTIjifMKj+9G5PGXHdmHun7LMLnVVf Iyx0hqwAI4RdNjsS7WRjj36UFpYvhE5Z30RnvNh8wxzPTZqIDq/V6FSJyRhQlm3vqAgv czJMjy/QiJI5hFODJh0hCucbVTQNfJmHuR7Ss= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=SnB7E0mI9F7Ie4RlS2cFfqKwCDcopSImUj3IgUSKIxI=; b=AYYhvKjkmoqZWdyuzY1cy/2qvXdRHGibQuTJwrW488gCRvFMrSvVoZxQo3RdtEc//d f/mM4Pp3cMALCR3Wi3eFcDIlw56/Z5mr1Xa1K2Hrh5Iv67lILe9FfNv4LDTtQUu/v3VY 08i2kFhrsfsR9ZmQO/5/KWyafjtOrodwOO5E3cBDtH/HI98It6QOCOYL0GYg0AQc9OEa pWhKX0mQngublFZvjwpAs5dDbJjgpvcUPB7vLxG0E2z3QAus1GHNneQNpRz80ELVdGeQ lyGhaXtjfJRVoqhKOKPHCz1lTwNJThFufSdJ6jol2YP6WWmNCgk3oiPlWRE1Rk6fknCq 5qxw== X-Gm-Message-State: AOAM531GdBwpZs6VCQtYtQMLuUY3LXwR8t2uILsie8eOHcejLWUSr1UR P6XjXVyCghREUzoJQMRP19lrXQ== X-Google-Smtp-Source: ABdhPJzJnGcA0q8XKKQGw3kIUgQPIXUnpTwBiY6N5ghL0OHEl3zmbEFuNMnAsinW9yZvnNW49rm+aQ== X-Received: by 2002:a63:5a11:: with SMTP id o17mr14040343pgb.287.1602536557163; Mon, 12 Oct 2020 14:02:37 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id 16sm24744149pjl.27.2020.10.12.14.02.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Oct 2020 14:02:36 -0700 (PDT) Date: Mon, 12 Oct 2020 14:02:35 -0700 From: Kees Cook To: Will Deacon Subject: Re: [PATCH v5 25/29] arm64: allow LTO_CLANG and THINLTO to be selected Message-ID: <202010121402.1EB5242@keescook> References: <20201009161338.657380-1-samitolvanen@google.com> <20201009161338.657380-26-samitolvanen@google.com> <20201012083116.GA785@willie-the-truck> <202010121344.53780D8CD2@keescook> <20201012205108.GA1620@willie-the-truck> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201012205108.GA1620@willie-the-truck> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201012_170241_142700_D28A0E0E X-CRM114-Status: GOOD ( 24.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, x86@kernel.org, "Paul E. McKenney" , kernel-hardening@lists.openwall.com, Peter Zijlstra , Greg Kroah-Hartman , Masahiro Yamada , linux-kbuild@vger.kernel.org, Nick Desaulniers , linux-kernel@vger.kernel.org, Steven Rostedt , clang-built-linux@googlegroups.com, Sami Tolvanen , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Oct 12, 2020 at 09:51:09PM +0100, Will Deacon wrote: > On Mon, Oct 12, 2020 at 01:44:56PM -0700, Kees Cook wrote: > > On Mon, Oct 12, 2020 at 09:31:16AM +0100, Will Deacon wrote: > > > On Fri, Oct 09, 2020 at 09:13:34AM -0700, Sami Tolvanen wrote: > > > > Allow CONFIG_LTO_CLANG and CONFIG_THINLTO to be enabled. > > > > > > > > Signed-off-by: Sami Tolvanen > > > > Reviewed-by: Kees Cook > > > > --- > > > > arch/arm64/Kconfig | 2 ++ > > > > 1 file changed, 2 insertions(+) > > > > > > > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > > > > index ad522b021f35..7016d193864f 100644 > > > > --- a/arch/arm64/Kconfig > > > > +++ b/arch/arm64/Kconfig > > > > @@ -72,6 +72,8 @@ config ARM64 > > > > select ARCH_USE_SYM_ANNOTATIONS > > > > select ARCH_SUPPORTS_MEMORY_FAILURE > > > > select ARCH_SUPPORTS_SHADOW_CALL_STACK if CC_HAVE_SHADOW_CALL_STACK > > > > + select ARCH_SUPPORTS_LTO_CLANG > > > > + select ARCH_SUPPORTS_THINLTO > > > > > > Please don't enable this for arm64 until we have the dependency stuff sorted > > > out. I posted patches [1] for this before, but I think they should be part > > > of this series as they don't make sense on their own. > > > > Oh, hm. We've been trying to trim down this series, since it's already > > quite large. Why can't [1] land first? It would make this easier to deal > > with, IMO. > > I'm happy to handle [1] along with the LTO Kconfig change when the time > comes, if that helps. I just don't want to merge dead code! Okay, understood. Thanks! > > Will > > > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/will/linux.git/log/?h=rwonce/read-barrier-depends -- Kees Cook _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel