From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A2E8C433DF for ; Mon, 12 Oct 2020 18:57:01 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D8FB120878 for ; Mon, 12 Oct 2020 18:57:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="AS7VBXvI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D8FB120878 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=e4uJELqSIXhPtMYg3Q+ZjotySYmlAdGoqez7bzXkB7U=; b=AS7VBXvIe5zpvJuasc20Rn5l9 J13SIXnK5WkSEtOQACnvtUa4to+iOSl6RPqC2cFYKTobcQllY6X1UrsxSWhWZZhPahGLkfZ/+O0Ja eOirmQ+S16lO4h5ZD0739Uy4JdvrI5uiK/TB5SJP6+dPLaDVyo4Hx1OGezah5VPt93nj+Wx7FNeTZ RctknG8q69GnIUVf1r+G7vYGmoHXsHIVd2S6deVtJcdKeViWyzOehqYlF8sOo9VwMFkQz/132vqjE P3b0blmz6f0HHoolIUR2xLhxQkgSzXyiGMUnA2W5KeAbqrTeR9FKVgp1FnsWvb9aJJg1WwRya6YO2 NL5iwCoFQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kS2z1-0007hQ-O6; Mon, 12 Oct 2020 18:55:43 +0000 Received: from mail-ot1-f67.google.com ([209.85.210.67]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kS2yx-0007ga-Ur for linux-arm-kernel@lists.infradead.org; Mon, 12 Oct 2020 18:55:41 +0000 Received: by mail-ot1-f67.google.com with SMTP id 32so3593615otm.3 for ; Mon, 12 Oct 2020 11:55:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=5fVAIseMnsnT90XiyJbBgJRxx/Jq3jfkvLK/AZmt1dA=; b=S5EKgJcMp1ZnBrSnUUz//iyJrKtXkSL6qyGqy6DJWE2u9KrbdUo/0DjMSv4AWP9Zoy TvRHwQskDqhhFOdiaQB9a4PbYYl53f30f4jdwtU97uKAUnbKtm9BtjgvW6av0DZHSew0 +XuUoF/qU9M3jLPRFXNVAIwhGhtQgj2qa8pNvMmMRiUxw89iNAUk6dE/fuEym0k9fBt2 htTzUiGJJFtHrMKk+wUU2Oa5rLXpKCJOObb+f3QL53q7Lmad/LOM8x52L8K2KVa0ZUN0 k78Nxic+VaUOqbpnzKNpSikGFvYv3c7Bby0OD7qtUZXp7HW/gzX4HvQYBA5it9WutDru Q7JQ== X-Gm-Message-State: AOAM5336JoGEbUIkmwZ3cZuPoCU13FNn+1rQhKsdhhqVVyqFqR6ev/gD RXzB4r0tawcgXX5tVxAUIhAhAgNDz9hl X-Google-Smtp-Source: ABdhPJzXa+bi5zHTxRpC5b5rVaVCpYGUmlSihkflVQ6s/QzKOgruDIXUaHqEfwygdXx8vVrJr2nTdA== X-Received: by 2002:a05:6830:2092:: with SMTP id y18mr18910537otq.19.1602528939283; Mon, 12 Oct 2020 11:55:39 -0700 (PDT) Received: from xps15 (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id y194sm9979533oie.22.2020.10.12.11.55.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Oct 2020 11:55:38 -0700 (PDT) Received: (nullmailer pid 1905660 invoked by uid 1000); Mon, 12 Oct 2020 18:55:37 -0000 Date: Mon, 12 Oct 2020 13:55:37 -0500 From: Rob Herring To: Lars Povlsen Subject: Re: [PATCH v5 1/3] dt-bindings: pinctrl: Add bindings for pinctrl-microchip-sgpio driver Message-ID: <20201012185537.GA1898766@bogus> References: <20201008130515.2385825-1-lars.povlsen@microchip.com> <20201008130515.2385825-2-lars.povlsen@microchip.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201008130515.2385825-2-lars.povlsen@microchip.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201012_145539_996393_7C118357 X-CRM114-Status: GOOD ( 24.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Alexandre Belloni , Linus Walleij , linux-kernel@vger.kernel.org, Microchip Linux Driver Support , linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Oct 08, 2020 at 03:05:13PM +0200, Lars Povlsen wrote: > This adds DT bindings for the Microsemi/Microchip SGPIO controller, > bindings microchip,sparx5-sgpio, mscc,ocelot-sgpio and > mscc,luton-sgpio. > > Signed-off-by: Lars Povlsen > --- > .../pinctrl/microchip,sparx5-sgpio.yaml | 140 ++++++++++++++++++ > 1 file changed, 140 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pinctrl/microchip,sparx5-sgpio.yaml > > diff --git a/Documentation/devicetree/bindings/pinctrl/microchip,sparx5-sgpio.yaml b/Documentation/devicetree/bindings/pinctrl/microchip,sparx5-sgpio.yaml > new file mode 100644 > index 000000000000..fc41495800ed > --- /dev/null > +++ b/Documentation/devicetree/bindings/pinctrl/microchip,sparx5-sgpio.yaml > @@ -0,0 +1,140 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/pinctrl/microchip,sparx5-sgpio.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Microsemi/Microchip Serial GPIO controller > + > +maintainers: > + - Lars Povlsen > + > +description: | > + By using a serial interface, the SIO controller significantly extend > + the number of available GPIOs with a minimum number of additional > + pins on the device. The primary purpose of the SIO controllers is to > + connect control signals from SFP modules and to act as an LED > + controller. > + > +properties: > + $nodename: > + pattern: "^gpio@[0-9a-f]+$" > + > + compatible: > + enum: > + - microchip,sparx5-sgpio > + - mscc,ocelot-sgpio > + - mscc,luton-sgpio > + > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 0 > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + microchip,sgpio-port-ranges: > + description: This is a sequence of tuples, defining intervals of > + enabled ports in the serial input stream. The enabled ports must > + match the hardware configuration in order for signals to be > + properly written/read to/from the controller holding > + registers. Being tuples, then number of arguments must be > + even. The tuples mast be ordered (low, high) and are > + inclusive. > + $ref: /schemas/types.yaml#/definitions/uint32-matrix > + items: > + items: > + - description: | > + "low" indicates start bit number of range > + minimum: 0 > + maximum: 31 > + - description: | > + "high" indicates end bit number of range > + minimum: 0 > + maximum: 31 > + minItems: 1 > + maxItems: 32 > + > + microchip,sgpio-frequency: > + description: The sgpio controller frequency (Hz). This dictates > + the serial bitstream speed, which again affects the latency in > + getting control signals back and forth between external shift > + registers. The speed must be no larger than half the system > + clock, and larger than zero. > + $ref: /schemas/types.yaml#/definitions/uint32 Perhaps use 'bus-frequency' here. If not, needs unit suffix. Either way, you can drop the type in those cases. With that, Reviewed-by: Rob Herring > + minimum: 1 > + default: 12500000 > + > +patternProperties: > + "^gpio@[0-1]$": > + type: object > + properties: > + compatible: > + const: microchip,sparx5-sgpio-bank > + > + reg: > + description: | > + The GPIO bank number. "0" is designates the input pin bank, > + "1" the output bank. > + maxItems: 1 > + > + gpio-controller: true > + > + '#gpio-cells': > + const: 3 > + > + ngpios: > + minimum: 1 > + maximum: 128 > + > + required: > + - compatible > + - reg > + - gpio-controller > + - '#gpio-cells' > + - ngpios > + > + additionalProperties: false > + > +additionalProperties: false > + > +required: > + - compatible > + - reg > + - clocks > + - microchip,sgpio-port-ranges > + - "#address-cells" > + - "#size-cells" > + > +examples: > + - | > + sgpio2: gpio@1101059c { > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "microchip,sparx5-sgpio"; > + clocks = <&sys_clk>; > + pinctrl-0 = <&sgpio2_pins>; > + pinctrl-names = "default"; > + reg = <0x1101059c 0x100>; > + microchip,sgpio-port-ranges = <0 0>, <16 18>, <28 31>; > + microchip,sgpio-frequency = <25000000>; > + sgpio_in2: gpio@0 { > + reg = <0>; > + compatible = "microchip,sparx5-sgpio-bank"; > + gpio-controller; > + #gpio-cells = <3>; > + ngpios = <96>; > + }; > + sgpio_out2: gpio@1 { > + compatible = "microchip,sparx5-sgpio-bank"; > + reg = <1>; > + gpio-controller; > + #gpio-cells = <3>; > + ngpios = <96>; > + }; > + }; > -- > 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel