From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9105C433DF for ; Tue, 13 Oct 2020 14:53:56 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5FD972489C for ; Tue, 13 Oct 2020 14:53:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KqWoyK04"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="uEYJqkI8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5FD972489C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=m/2TI0FpPYvZgrW6AmScSMFRTPcgpZ/0fUUsFCkmDRA=; b=KqWoyK048//vqvz+LoR6Rcg3J BiYmR6UTr12BEopP9c6eRDq6Q8C/KdFUCh6RSZy7nrrEx4dGkHUto6zcghkPcumgHm+P8GgEGKpBx qcvTiYKLFVd2TEUmthTHeq42X+vHQZs4/2TK99uD+tvHx3CzLi4x481lJBmWRjoQhBq72wUFq1EV+ Od3klH92PKfe5TVe0AKG2vojpg+/Mf7yJsfqeecZkwUPqqEz4ngb901/kIrMVh8l/MLiaEMCd3mBV y47cpLFk0OCpq5Rns9J2mfrmPpsfJNXmvtWeBSCgffCvNydAExCN9gcqMUJOjvo1hnwabniY9cS5u /rbTPwKtg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kSLfN-0007Vq-Bc; Tue, 13 Oct 2020 14:52:41 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kSLfM-0007Vf-Cu for linux-arm-kernel@merlin.infradead.org; Tue, 13 Oct 2020 14:52:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=HJQ0tj9oJ04H11vAjOxVoBmYU/2MYbuirnFYBY1r/44=; b=uEYJqkI8/Tnoj4TsyCr8LC65Ae XerUIzfsXAGt1pXRAyATfd301NeZYI3q4YHzM74DxHDSDdXRupy1kADjSjYZqXnvMqLTiDBO1SkDR hBfS28p3vr8oT/2fB+NC8wpcHCaTVyeeYQr3FjoBWbktm5N7vHrNJJzDso03iONGjDMGdOkUtWgfP W3KFDQynAf7eXsZl9oNNBytBD7Fz0YDta8HT5wonrOO+N8Nxe1xJcZ8Nnqp17ojX8zqndR3ePjCU7 HEP7g6GcSr3Er3KdbJ06J1nJGAU7GGhK3Lb0yx/xoPC6S911xFPa+puGrDsITRoZX3enEFTBhDxRZ a7pI3FaQ==; Received: from [179.97.37.151] (helo=quaco.ghostprotocols.net) by casper.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1kSLfJ-0006QO-TE; Tue, 13 Oct 2020 14:52:39 +0000 Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 5576C4047F; Tue, 13 Oct 2020 11:52:17 -0300 (-03) Date: Tue, 13 Oct 2020 11:52:17 -0300 From: Arnaldo Carvalho de Melo To: Leo Yan Subject: Re: [PATCH 4/5] perf: arm_spe: Decode memory tagging properties Message-ID: <20201013145217.GF1063281@kernel.org> References: <20200922101225.183554-1-andre.przywara@arm.com> <20200922101225.183554-5-andre.przywara@arm.com> <20200927031918.GD9677@leoy-ThinkPad-X240s> <20201013145103.GE1063281@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201013145103.GE1063281@kernel.org> X-Url: http://acmel.wordpress.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Suzuki K Poulose , Peter Zijlstra , Andre Przywara , Jiri Olsa , linux-kernel@vger.kernel.org, Alexander Shishkin , Ingo Molnar , James Clark , Catalin Marinas , Namhyung Kim , Will Deacon , Tan Xiaojun , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Em Tue, Oct 13, 2020 at 11:51:03AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Sun, Sep 27, 2020 at 11:19:18AM +0800, Leo Yan escreveu: > > On Tue, Sep 22, 2020 at 11:12:24AM +0100, Andre Przywara wrote: > > > When SPE records a physical address, it can additionally tag the event > > > with information from the Memory Tagging architecture extension. > > > > > > Decode the two additional fields in the SPE event payload. > > > > > > Signed-off-by: Andre Przywara > > > --- > > > .../util/arm-spe-decoder/arm-spe-pkt-decoder.c | 17 ++++++++++++----- > > > 1 file changed, 12 insertions(+), 5 deletions(-) > > > > > > diff --git a/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c b/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c > > > index 943e4155b246..a033f34846a6 100644 > > > --- a/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c > > > +++ b/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c > > > @@ -8,13 +8,14 @@ > > > #include > > > #include > > > #include > > > +#include > > > > > > #include "arm-spe-pkt-decoder.h" > > > > > > -#define BIT(n) (1ULL << (n)) > > > - > > > #define NS_FLAG BIT(63) > > > #define EL_FLAG (BIT(62) | BIT(61)) > > > +#define CH_FLAG BIT(62) > > > +#define PAT_FLAG GENMASK_ULL(59, 56) > > > > > > #define SPE_HEADER0_PAD 0x0 > > > #define SPE_HEADER0_END 0x1 > > > @@ -447,10 +448,16 @@ int arm_spe_pkt_desc(const struct arm_spe_pkt *packet, char *buf, > > > return snprintf(buf, buf_len, "%s 0x%llx el%d ns=%d", > > > (idx == 1) ? "TGT" : "PC", payload, el, ns); > > > case 2: return snprintf(buf, buf_len, "VA 0x%llx", payload); > > > - case 3: ns = !!(packet->payload & NS_FLAG); > > > + case 3: { > > > + int ch = !!(packet->payload & CH_FLAG); > > > + int pat = (packet->payload & PAT_FLAG) >> 56; > > > + > > > + ns = !!(packet->payload & NS_FLAG); > > > payload &= ~(0xffULL << 56); > > > - return snprintf(buf, buf_len, "PA 0x%llx ns=%d", > > > - payload, ns); > > > + return snprintf(buf, buf_len, > > > + "PA 0x%llx ns=%d ch=%d, pat=%x", > > > + payload, ns, ch, pat); > > > + } > > > > Reviewed-by: Leo Yan > > Thanks, applied. I take that back, I'm applying Leo's series that Andre reviewed instead. - Arnaldo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel