From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 807A3C433E7 for ; Wed, 14 Oct 2020 06:19:19 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E307C2177B for ; Wed, 14 Oct 2020 06:19:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="bnGRJ7Ip" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E307C2177B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MG9CpfLEKpqfKlqROwgHHM2MQfeNO100oB6zdNrXQwc=; b=bnGRJ7IphJRxWIwAlsiNiWsbL u/pahkMc0+y05sYTHHONA+phYyDw/f0PmMoWuX0HHabF+3Sw8wadKZN993FuVf3nPnfD6kfVhMYIM Z+11XSxvAsxLzDiKawI+0BuB0yB/OcmzsmUNt+V6kkdBHHd91JAEycm3Qt9cONMZ9MISiBuGzORXI P0lIyEfpTNveVnOedc2CpU+5pMLR6Ur7/u5sRuDSWaS//+FdDdKwmqeqdvokXmqcm+waC5qYviAd+ NzwDjWjlFVHgX7as9ZG02kSG+pu00Z3oIoELOFbxRFVQEnmbfnd6fmk/hG9XF0lbTXjkoPHtKuW88 Qz88FIRAQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kSa6X-0002nI-O1; Wed, 14 Oct 2020 06:17:41 +0000 Received: from mail-ed1-f68.google.com ([209.85.208.68]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kSa6V-0002mx-0K for linux-arm-kernel@lists.infradead.org; Wed, 14 Oct 2020 06:17:40 +0000 Received: by mail-ed1-f68.google.com with SMTP id x1so1918842eds.1 for ; Tue, 13 Oct 2020 23:17:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=nRETCMUggNgSzB3Ff8f9czD714/ySw0c2TVlidnZhzo=; b=K5vk0aMScaRJE+2BSCO97Fs/uojIQI3yS71eyapdZNNOzpoG49gRc+R7ZNsPOLgOYi 0AtwVyw2SkYvObUUu2x/c1kR5YLydzaOSR2SeRNziBKre3jsvsC/wtpRhchzV9/iqEva TWQd/PTFOyYTJFKfmmyNkfB6Pta5Ec5I1mwcGdY+FC803GsU8L43Qvqcpakf45TVAFHH tJ621HAtpXtEcI8+qstCdiEq8dQ4CtRBhR6rHnIrDLfqf2sY1hY9ueaKFJcjRHmFGzY1 KzJNzjDgdrFYrgfqqWUKkUp9M/I6DAkN3Huy7Kzs75SoPpLP1juz3zylykxTNkYece+r 2WMw== X-Gm-Message-State: AOAM532uKbdKIdECfiR4i0TQprmlqlKl7PMahrbNGYNij4XTJXrOKsdy xgIY6ZY70ay3NHNib6HsRRs= X-Google-Smtp-Source: ABdhPJzCxYhYBVBaZz5jBqPvgupxLdGCqZC1DrVF7ARKbCN/YsQRr9PIxjYmOwWqoaBiMx1/c/FV/Q== X-Received: by 2002:a05:6402:651:: with SMTP id u17mr3419101edx.206.1602656255808; Tue, 13 Oct 2020 23:17:35 -0700 (PDT) Received: from kozik-lap ([194.230.155.240]) by smtp.googlemail.com with ESMTPSA id si13sm1047455ejb.49.2020.10.13.23.17.33 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 13 Oct 2020 23:17:34 -0700 (PDT) Date: Wed, 14 Oct 2020 08:17:32 +0200 From: Krzysztof Kozlowski To: Stephen Boyd Subject: Re: [PATCH 2/2] clk: samsung: exynos-clkout: convert to module driver Message-ID: <20201014061732.GA3672@kozik-lap> References: <20201001165646.32279-1-krzk@kernel.org> <20201001165646.32279-3-krzk@kernel.org> <160264342071.310579.16332243912081691987@swboyd.mtv.corp.google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <160264342071.310579.16332243912081691987@swboyd.mtv.corp.google.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201014_021739_052699_429B8641 X-CRM114-Status: GOOD ( 15.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, Michael Turquette , Tomasz Figa , linux-kernel@vger.kernel.org, Chanwoo Choi , Kukjin Kim , Sylwester Nawrocki , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Marek Szyprowski Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Oct 13, 2020 at 07:43:40PM -0700, Stephen Boyd wrote: > Quoting Krzysztof Kozlowski (2020-10-01 09:56:46) > > diff --git a/drivers/clk/samsung/clk-exynos-clkout.c b/drivers/clk/samsung/clk-exynos-clkout.c > > index 34ccb1d23bc3..68af082d4716 100644 > > --- a/drivers/clk/samsung/clk-exynos-clkout.c > > +++ b/drivers/clk/samsung/clk-exynos-clkout.c > > @@ -28,41 +31,103 @@ struct exynos_clkout { > [...] > > + if (!match) { > > + dev_err(dev, "cannot match parent device\n"); > > + return -EINVAL; > > + } > > + variant = match->data; > > + > > + *mux_mask = variant->mux_mask; > > + dev_err(dev, "MATCH: %x\n", variant->mux_mask); > > Is this a debug print? Debugging left over, thanks for catching this. I'll remove it. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel