From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E120FC433E7 for ; Wed, 14 Oct 2020 22:48:27 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2CD2B2223F for ; Wed, 14 Oct 2020 22:48:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Pf+9SSiX"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="WE3ire40" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2CD2B2223F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qtbUOMfnNH2nGg3/+7prntIhfQNyfEHXsPp0Mwir454=; b=Pf+9SSiXqjZXN+KuThFFqVAhk iaX4NkhoTugcHnB+m1Dg34uTj4QrtPdbMNic+Cw54ehcGYbWRVVH/PdESUllOjajqYDOO6Ek/SRys Aqz6hBKBxZPd03ViqFTbFy/KACOEJxy6vYgPHpbJjye9H9MXS9WfPLbJf1jgC5McdAcdvH+lFqump //x6nJ++i9YzNDjGrf8tgMJ8xcHx4EFSWzl8DBOSPzPsM+mOz5cqQghnDocBhbXDFLqalVXUBlwEv SOEsabu3RpAmLTGr7S0dJH0BDO1fvUs+7Ptl+cdEvT04OdOrMwv3/5QzecNR8cMk8/7HJnPe+hN6s uH4ZfmVmw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kSpY2-0004KT-1A; Wed, 14 Oct 2020 22:47:06 +0000 Received: from mail-pj1-x1043.google.com ([2607:f8b0:4864:20::1043]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kSpXz-0004JL-O0 for linux-arm-kernel@lists.infradead.org; Wed, 14 Oct 2020 22:47:04 +0000 Received: by mail-pj1-x1043.google.com with SMTP id u3so628186pjr.3 for ; Wed, 14 Oct 2020 15:47:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=1ZkeuWYx0x8NcK97W3bc1qXSyhy0ywO9Zu1gztVJSpU=; b=WE3ire40GLinUOppIi7ZcbOVETm0WyX7RLx7xCaymADCWSNOR8y2/RwcPtSnft1aFu 0ChZJ7ygTGlmsX8EVM6bGmei1Zx5q2bj0yebVv+SOHsAiV0uEn+oar9jyVds8dZOPeFt NDilDA6BdcrnvpJnue+wzGel9tWEzsFUzutQ0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=1ZkeuWYx0x8NcK97W3bc1qXSyhy0ywO9Zu1gztVJSpU=; b=XUX1Cf8areVZymalTdfgyGaWuJb83bka5E9e3TnGbfkKk4U/XKTT+44anFXm7A64UY X263V4SGEiHcvQRwT0BZFvBaKG+pCKvKNI6vsETm1JIzqNzo0gWKPGhFzZlK3iQLmNZo Ob6ouv6XQtBspXzlV9s4QlvmhIY52Qx3QZCjCy6r7Ni1rlCwU3tyBwLjueqjcIX7ydEX oJYkG2mBC4RU4Hbc8Fv7tqkcyUcfZTxvASpBKlBDhNgRlavJfHz04MmRz6kjlvCJK7MZ jOrw8uJ34lEhGxmEApvNLxGfh7NGNm9wzbV5xHPti3kOQJ3tcA5xva/v8cGBJEOcon+j 6gTQ== X-Gm-Message-State: AOAM5312O7qDNERokXYSg+78t5+GXnh7pU7C4BFT+oODpbEotz8+hDEz KYsl0m9Ly9uBP+9CtLmNS/bb3Q== X-Google-Smtp-Source: ABdhPJw7BSKlM7cAv8r7/0jhJx32xhaKYpzsb2RiBeH0xy7bNtYmDuLkURklLKzHhQnxbTes9rTU2A== X-Received: by 2002:a17:90a:f0ca:: with SMTP id fa10mr1313834pjb.130.1602715621497; Wed, 14 Oct 2020 15:47:01 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id d9sm591245pjx.47.2020.10.14.15.47.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Oct 2020 15:47:00 -0700 (PDT) Date: Wed, 14 Oct 2020 15:46:59 -0700 From: Kees Cook To: Thomas Gleixner , Josh Poimboeuf Subject: Re: [PATCH v6 22/25] x86/asm: annotate indirect jumps Message-ID: <202010141545.1E2A393C62@keescook> References: <20201013003203.4168817-1-samitolvanen@google.com> <20201013003203.4168817-23-samitolvanen@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201013003203.4168817-23-samitolvanen@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201014_184703_824028_91354F49 X-CRM114-Status: GOOD ( 13.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, x86@kernel.org, "Paul E. McKenney" , kernel-hardening@lists.openwall.com, Peter Zijlstra , Greg Kroah-Hartman , Masahiro Yamada , linux-kbuild@vger.kernel.org, Nick Desaulniers , linux-kernel@vger.kernel.org, Steven Rostedt , clang-built-linux@googlegroups.com, Sami Tolvanen , linux-pci@vger.kernel.org, Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Oct 12, 2020 at 05:32:00PM -0700, Sami Tolvanen wrote: > Running objtool --vmlinux --duplicate on vmlinux.o produces a few > warnings about indirect jumps with retpoline: > > vmlinux.o: warning: objtool: wakeup_long64()+0x61: indirect jump > found in RETPOLINE build > ... > > This change adds ANNOTATE_RETPOLINE_SAFE annotations to the jumps > in assembly code to stop the warnings. > > Signed-off-by: Sami Tolvanen Reviewed-by: Kees Cook This looks like it's an independent fix -- can an x86 maintainer pick up this patch directly? -- Kees Cook _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel