From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51641C433DF for ; Wed, 14 Oct 2020 16:22:10 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AC5C922200 for ; Wed, 14 Oct 2020 16:22:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="SMIrtMSy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AC5C922200 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=rowland.harvard.edu Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3ds/KLxipwMznN78QFYfS5ZCtx6lrXZyptKRVVNdjy0=; b=SMIrtMSyJXXqbjRSNZ3TcE1dR n+HCeUL8kgJ/2JsicB2Yr0xudQlVEs/7l+YcYRvzHT1RETEKU8wJSig0y6k48v2Mi9jhg76qtjAsM QJnvMq/8mPpfU18eRq2T0zRplkhhtav/okSMH+gLq9WsstvqadOmXAjTS1K316H7YXpFNovPo3Qyx PS69+j55XUX8lPKc4zbUO1AMthIqwd3Tc6BlZlo4SVWZ2Aqb7xVMmf82mgok5gY3zJveE5sl6Av8M KubIYvPdWy0Ln+EJBAPE9WLeQzKZDzG/i6CNxViqyG3i5UHwNE4kWbGklfxA4cJ1cZs0JB8NLXy43 ur9s0duoA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kSjW3-0006kT-Lh; Wed, 14 Oct 2020 16:20:39 +0000 Received: from netrider.rowland.org ([192.131.102.5]) by merlin.infradead.org with smtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kSjW0-0006jS-PG for linux-arm-kernel@lists.infradead.org; Wed, 14 Oct 2020 16:20:37 +0000 Received: (qmail 719097 invoked by uid 1000); 14 Oct 2020 12:20:36 -0400 Date: Wed, 14 Oct 2020 12:20:36 -0400 From: Alan Stern To: Thomas Gleixner Subject: Re: [patch 08/12] usb: hosts: Remove in_interrupt() from comments Message-ID: <20201014162036.GC712494@rowland.harvard.edu> References: <20201014145215.518912759@linutronix.de> <20201014145727.957664398@linutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201014145727.957664398@linutronix.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201014_122036_881022_80593F5C X-CRM114-Status: GOOD ( 18.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Felipe Balbi , linux-samsung-soc@vger.kernel.org, Mathias Nyman , Peter Zijlstra , Greg Kroah-Hartman , Sebastian Andrzej Siewior , linux-usb@vger.kernel.org, LKML , Krzysztof Kozlowski , Johan Hovold , Thomas Winischhofer , Kukjin Kim , Valentina Manea , Duncan Sands , "Ahmed S. Darwish" , linux-omap@vger.kernel.org, Shuah Khan , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Oct 14, 2020 at 04:52:23PM +0200, Thomas Gleixner wrote: > From: Ahmed S. Darwish > > The usage of in_interrupt() in drivers is phased out for various reasons. > > Various comments use !in_interrupt() to describe calling context for probe() > and remove() functions. That's wrong because the calling context has to be > preemptible task context, which is not what !in_interrupt() describes. > > Cleanup the comments. While at it add the missing kernel doc argument > descriptors and make usb_hcd_msp_remove() static. > > Signed-off-by: Ahmed S. Darwish > Signed-off-by: Sebastian Andrzej Siewior > Signed-off-by: Thomas Gleixner > Cc: Alan Stern > Cc: Greg Kroah-Hartman > Cc: linux-usb@vger.kernel.org > Cc: linux-omap@vger.kernel.org > Cc: Kukjin Kim > Cc: Krzysztof Kozlowski > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-samsung-soc@vger.kernel.org > > --- > --- a/drivers/usb/host/ehci-pmcmsp.c > +++ b/drivers/usb/host/ehci-pmcmsp.c > @@ -233,7 +236,7 @@ int usb_hcd_msp_probe(const struct hc_dr > * may be called without controller electrically present > * may be called with controller, bus, and devices active > */ > -void usb_hcd_msp_remove(struct usb_hcd *hcd, struct platform_device *dev) > +static void usb_hcd_msp_remove(struct usb_hcd *hcd) Please don't intermix changes to comments with other more substantive changes. > --- a/drivers/usb/host/ohci-omap.c > +++ b/drivers/usb/host/ohci-omap.c > @@ -399,8 +401,7 @@ static int ohci_hcd_omap_probe(struct pl > > /** > * ohci_hcd_omap_remove - shutdown processing for OMAP-based HCDs > - * @dev: USB Host Controller being removed > - * Context: !in_interrupt() > + * @pdev: USB Host Controller being removed > * > * Reverses the effect of ohci_hcd_omap_probe(), first invoking > * the HCD's stop() method. It is always called from a thread You forgot to add the Context comment. Alan Stern _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel