From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40747C433DF for ; Thu, 15 Oct 2020 01:17:37 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D06F322254 for ; Thu, 15 Oct 2020 01:17:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="zhP+7rFC"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IGDdXD8r" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D06F322254 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4gH4ParK0gIEtpYfjUzL+vEi2ls/Ad7cvCqGXrrRTfs=; b=zhP+7rFCmyVk/bHE1c6fSyy+3 4xMrzL3vMwuk6Xip0a1MCbyAAPhBh19cp3/DovFnCguUCGLiqSoNdlia22jckV89qDj1rPPyZFuym hH5lh6xSHRTF8fujGpoFWkjgHtV5FPdJdq/sAEZK/gTbhgCBRpLXUY7dAN+Pm7qAsUbVFi8bTSdkU QVp/rYHQX3EFmmFkJGFdeFchUuIH37eiWxU+iqpxVF02L9sFMbdPSIBqhLiy7WkmHjuDWf5SJ0FKX kGHPA8eRPT+To1aNLE1yx0p3tVcKR6dAlZduwBjaW1csRcrrh4qrh3XouokQKUQmMz5rQK/qojw4V 242o+4isQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kSrsJ-0004gJ-Ua; Thu, 15 Oct 2020 01:16:11 +0000 Received: from mail-io1-xd41.google.com ([2607:f8b0:4864:20::d41]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kSrsH-0004fn-5D for linux-arm-kernel@lists.infradead.org; Thu, 15 Oct 2020 01:16:09 +0000 Received: by mail-io1-xd41.google.com with SMTP id k6so2268304ior.2 for ; Wed, 14 Oct 2020 18:16:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=tVdoKNi6CDA3oy1vcQG9KtgdbV05kDOzZC+L7q8Ac3k=; b=IGDdXD8rRTcME1ZCmTTfJ4lQaP4iI1mFbqYpnWxCGvVGVaYgLhflPiiAS9MIFJ+rLN 8u6s/43uMEnOXFaKOCsAQBfnKoYZpRxUxvRCECUmiSnOaGR0fDd04xHgevlJx3rtyKZp C+YGRVnuxcN/K4EfNaaxmbzvEO6dgwYDNcoiwphItBMXzvOZIC/FV4qlMZ7MdXqwg0m9 2r7Gn1cd0ZiDSGqJ/PelTaaAngsrOYH5EVGs4MKtqBdpx/wqEA2URnzWgTavNZ/gTplw JlMpGhasb6wfHGAfvZofpSXwf92cHfFCmmTf350iMdFsz2OlczvyCtel4j34j+moNgok e32Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=tVdoKNi6CDA3oy1vcQG9KtgdbV05kDOzZC+L7q8Ac3k=; b=WtClxhaosSHC6Dj+18R6+caQyDOXRpEQP1cEgxbCt3oCucYDM+396RAPuuTQzCFPQo WNabtXWftilYekH+63fv5NDQlWt7V9q+WX9fs9kDPhIUuVUOku/l+ZFwWjUZmnTpQjtD GiZkBs6Hf5sveZjJTBxkXHcdwQEaRg9y73csTDv/eBeSqUmRe4RWdUxm/P6q6dLuEc7J gWn/eyph76sLiATr59ijT8Z0MjgFQ5ezZzgcQ4YZBFCO2dSNshZexa0o2l/4DxucewV4 E+qj4u6EQSQmcC4eBNsnd6bwctpwfFA5jdsyXj2eix6NGlX4aHUgnuz+UM1v0FLxfUUw DmVg== X-Gm-Message-State: AOAM533e9emyZj1JBYoYGww7jUH/oqqN/A3sEYqu7eGxig/FXsm4PRhy WstED6kl3wS6kIR7VBy+/g== X-Google-Smtp-Source: ABdhPJyzjy0u4JM0XQEC75drvBuz4Tg9Dl1F4JxQlCjD8m3vu+7kP8DfjFUkkFR7mIXnXbn2t/v1vw== X-Received: by 2002:a05:6638:1189:: with SMTP id f9mr1805122jas.10.1602724567593; Wed, 14 Oct 2020 18:16:07 -0700 (PDT) Received: from gabell (209-6-122-159.s2973.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [209.6.122.159]) by smtp.gmail.com with ESMTPSA id r204sm1408693iod.25.2020.10.14.18.16.05 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 14 Oct 2020 18:16:06 -0700 (PDT) Date: Wed, 14 Oct 2020 21:16:04 -0400 From: Masayoshi Mizuma To: Sumit Garg Subject: Re: [PATCH v5 2/5] irqchip/gic-v3: Enable support for SGIs to act as NMIs Message-ID: <20201015011604.ixmx2e2cbn5zsu5j@gabell> References: <1602673931-28782-1-git-send-email-sumit.garg@linaro.org> <1602673931-28782-3-git-send-email-sumit.garg@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1602673931-28782-3-git-send-email-sumit.garg@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201014_211609_213879_6F646ED0 X-CRM114-Status: GOOD ( 19.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, daniel.thompson@linaro.org, ito-yuichi@fujitsu.com, jason@lakedaemon.net, maz@kernel.org, jason.wessel@windriver.com, dianders@chromium.org, linux-kernel@vger.kernel.org, julien.thierry.kdev@gmail.com, catalin.marinas@arm.com, kgdb-bugreport@lists.sourceforge.net, tglx@linutronix.de, will@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Oct 14, 2020 at 04:42:08PM +0530, Sumit Garg wrote: > Add support to handle SGIs as regular NMIs. As SGIs or IPIs defaults to a > special flow handler: handle_percpu_devid_fasteoi_ipi(), so skip NMI > handler update in case of SGIs. > > Also, enable NMI support prior to gic_smp_init() as allocation of SGIs > as IRQs/NMIs happen as part of this routine. > > Signed-off-by: Sumit Garg > --- > drivers/irqchip/irq-gic-v3.c | 13 +++++++++++-- > 1 file changed, 11 insertions(+), 2 deletions(-) > > diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c > index 16fecc0..5efc865 100644 > --- a/drivers/irqchip/irq-gic-v3.c > +++ b/drivers/irqchip/irq-gic-v3.c > @@ -477,6 +477,11 @@ static int gic_irq_nmi_setup(struct irq_data *d) > if (WARN_ON(gic_irq(d) >= 8192)) > return -EINVAL; > > + if (get_intid_range(d) == SGI_RANGE) { > + gic_irq_set_prio(d, GICD_INT_NMI_PRI); > + return 0; > + } > + > /* desc lock should already be held */ > if (gic_irq_in_rdist(d)) { > u32 idx = gic_get_ppi_index(d); > @@ -514,6 +519,11 @@ static void gic_irq_nmi_teardown(struct irq_data *d) > if (WARN_ON(gic_irq(d) >= 8192)) > return; > > + if (get_intid_range(d) == SGI_RANGE) { > + gic_irq_set_prio(d, GICD_INT_DEF_PRI); > + return; > + } > + > /* desc lock should already be held */ > if (gic_irq_in_rdist(d)) { > u32 idx = gic_get_ppi_index(d); > @@ -1708,6 +1718,7 @@ static int __init gic_init_bases(void __iomem *dist_base, > > gic_dist_init(); > gic_cpu_init(); > + gic_enable_nmi_support(); > gic_smp_init(); > gic_cpu_pm_init(); > > @@ -1719,8 +1730,6 @@ static int __init gic_init_bases(void __iomem *dist_base, > gicv2m_init(handle, gic_data.domain); > } > > - gic_enable_nmi_support(); > - > return 0; > > out_free: > -- Looks good to me. Please feel free to add: Reviewed-by: Masayoshi Mizuma Thanks! Masa _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel