From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B836CC433E7 for ; Thu, 15 Oct 2020 08:37:43 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 253452224A for ; Thu, 15 Oct 2020 08:37:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lqOFCrXN"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Txd/Jrrp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 253452224A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3+ZTHqie1LcVluTZD3R7DcWGPOaLWaShuzrEUtyCVRU=; b=lqOFCrXNOAevU0pA4s1NKHMVP wNGP1uTjeBREobCqaFwQ6lyrSJjqdjwIzJ58Tk9m3L50gv4jH0UvL+GzJ7q21cAXJbyHtBr/jtRqL 6UexZ79OuVJu4Fwh1IWu1/ABkuT3BPci5oiKtPhQjI5nVnLO3DfTyM3T6dCzMhxp0/ohqPxXl/LyH qPWDGPJE9jkWadBoYG6DzI+B1E7QCW5D/w4aX0+wv71b72ho5YQWGX8n7BUK+/CBAqIYer+EUy1/T EDZF+eEnE873GxbQD8qlq0gJ8R7+ic9gjN0+IZgzlKB6UKdMECRZBPC1oqw7tEJKF/gIdYKK8SjKU h7CVGfP/A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kSykC-0007XZ-Ap; Thu, 15 Oct 2020 08:36:16 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kSyk9-0007Ws-Fj for linux-arm-kernel@lists.infradead.org; Thu, 15 Oct 2020 08:36:14 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 576012075B; Thu, 15 Oct 2020 08:36:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602750971; bh=hP94CwWS7xvhTtF8wHiWx81RZLTLeMuk1epq5z2bU60=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Txd/JrrpLD6X5BUFspoeQ16zqYuMvFY/nGUubsShJbaDZD/vXpFyWkRVj1Db6IsFt sP2wBydRlaO/qSJTch7wm2jzfKeziqjJgYgqPtA5Z/sPQwdIOEOL6oree26WZRVPbN z3oI29eBZ5kFodoa2KvHQwD5FsU9Q5D0mDLAr5VA= Date: Thu, 15 Oct 2020 09:36:05 +0100 From: Will Deacon To: Sudarshan Rajagopalan Subject: Re: [PATCH v3] arm64/mm: add fallback option to allocate virtually contiguous memory Message-ID: <20201015083605.GA4537@willie-the-truck> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201015_043613_604946_8E6AE01D X-CRM114-Status: GOOD ( 16.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Gavin Shan , Anshuman Khandual , Catalin Marinas , David Hildenbrand , linux-kernel@vger.kernel.org, Steven Price , Andrew Morton , Logan Gunthorpe , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Oct 14, 2020 at 05:51:23PM -0700, Sudarshan Rajagopalan wrote: > When section mappings are enabled, we allocate vmemmap pages from > physically continuous memory of size PMD_SIZE using > vmemmap_alloc_block_buf(). Section mappings are good to reduce TLB > pressure. But when system is highly fragmented and memory blocks are > being hot-added at runtime, its possible that such physically continuous > memory allocations can fail. Rather than failing the memory hot-add > procedure, add a fallback option to allocate vmemmap pages from > discontinuous pages using vmemmap_populate_basepages(). > > Signed-off-by: Sudarshan Rajagopalan > Reviewed-by: Gavin Shan > Reviewed-by: Anshuman Khandual > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Anshuman Khandual > Cc: Mark Rutland > Cc: Logan Gunthorpe > Cc: David Hildenbrand > Cc: Andrew Morton > Cc: Steven Price > --- > arch/arm64/mm/mmu.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) Please can you fix the subject? I have three copies of "PATCH v3" from different days in my inbox. I know it sounds trivial, but getting these little things right really helps with review, especially when it's sitting amongst a sea of other patches. Thanks, Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel