From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5F02C433DF for ; Thu, 15 Oct 2020 12:07:02 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3A4212145D for ; Thu, 15 Oct 2020 12:07:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="RwmPPYbc"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="M9pJeRxW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3A4212145D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=BKsqN4nNRGlzHtrVb1Krr4RizD+ESbg3Y2xAgU9Spp4=; b=RwmPPYbcN2Fq0jROd0ISMcNAh v9yk5zBb0aGjs8g5pexDKsCGRm8J+WrZVH4Q7Euzup3b7Yst3Du+LvXPoo3n4RsSWjST2nXkUvMBA hHh9VPD1Ztv6IvqBqdnvNw74y+i1d/jhpF7Whn7+rPlor8WNy6InzEYIz7iZj0E43GOeW8gmnUO5I 6wMv0uxguI9nvMVAA3XXKo/UPSd44ZaB8gtzky1USyv10bhYqUK5j5eU7hg4bR1dQ9sdncSIwl6l3 yvQzdzgtu6apzZH1He0GjFUZ7uUeCtjzxP5NAtm2gkATyJg2u1FkSMVqfFug8irsO2lHdCN0/J8i0 zfGnqdWjQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kT20M-00047d-Eh; Thu, 15 Oct 2020 12:05:10 +0000 Received: from mail-lj1-x243.google.com ([2a00:1450:4864:20::243]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kT20J-00047B-QP for linux-arm-kernel@lists.infradead.org; Thu, 15 Oct 2020 12:05:08 +0000 Received: by mail-lj1-x243.google.com with SMTP id d24so2843446ljg.10 for ; Thu, 15 Oct 2020 05:05:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=b84hsRMoXS6GSIJgvfo2S0Egn1CWq+Hpix6sK2IAdUE=; b=M9pJeRxWl/yzHIyVox8DH1/36P4oGErk7sMFdyEZekt4dWZSdmimLtSAx+AVZmf29u j+8kssj4JNre8sIqmrLLZElE9YkOeSjXvejl/F1a5MryXWtsdg5I8BgEo+ospPwV+VwC f7NVefdUm+SkIPSkOmoWF5fUjO/Ugjx37AgGm/sVpMVB5J3OsfSXF8RGdzVAFwb50oU1 ZXTRFtX3qtNLgoLtvewOvHwDDY7tPS7dyYA/Yye62dAhp40wo13id8JKWEq8jCkd8D21 RKerY4o82571VLersFP83OuHuOrND8iT1eME1mpPn0B4X+v90jcbB09ont9P3Bf5G1BE baoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=b84hsRMoXS6GSIJgvfo2S0Egn1CWq+Hpix6sK2IAdUE=; b=m16Bna6Kqb32qNrqev01cqyHB9T4P1dI8XtT2MBo3rsyoNYCWUegcOU+hYBvzD1s0S rf7oev6lsEjAjd+Psku/7O5oQy5bjQDKgah5L7BZFXSpEEpHUKVzLmHoVoOuEYxdm1ak JAINudH+VH5W2Lr8vVRnf5ULQivVkbhcAvkJwqeWh9mfvfpzBpBMIQaQZdCZhaJYa0OV gxyTTP+i39aD8RChshwOD9sFp/LNMdDUc8EiNyrjI66ELtY9Zu0uuAzRV18yiRFsDhor MbWm1MbxhV1A88WsSKMwUKnlEffEpxTMTckGUES6HX5cFYd0OV2Wbx/HpVMTwJ6U68jS zzsg== X-Gm-Message-State: AOAM533nVKsJcQwQx8FMYn18yoxyI4E/p3D3c47WZoyps7F44rXSWum4 YoYRqpbWvBagk/sm0A6LLIQ= X-Google-Smtp-Source: ABdhPJwwt3EyjuYq57Lukv1Wqv/KyjW0MQ9OTploRIduCcyLajK657qmY9eO1Kj6MoiwK7QuR74ZqQ== X-Received: by 2002:a2e:864c:: with SMTP id i12mr1075757ljj.396.1602763505518; Thu, 15 Oct 2020 05:05:05 -0700 (PDT) Received: from mobilestation ([95.79.141.114]) by smtp.gmail.com with ESMTPSA id x4sm1213347ljj.62.2020.10.15.05.05.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Oct 2020 05:05:04 -0700 (PDT) Date: Thu, 15 Oct 2020 15:04:57 +0300 From: Serge Semin To: Jisheng Zhang Subject: Re: [PATCH 8/8] dt-bindings: gpio: dw-apb: remove never-used "snps,dw-apb-gpio-port" Message-ID: <20201015120457.qaooft5y5dzl4z7s@mobilestation> References: <20201015115524.24e3c36b@xhacker.debian> <20201015115903.2a782f78@xhacker.debian> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201015115903.2a782f78@xhacker.debian> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201015_080507_928549_8A6D1F79 X-CRM114-Status: GOOD ( 19.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Khuong Dinh , Dinh Nguyen , Linus Walleij , linux-kernel@vger.kernel.org, Wei Xu , Bartosz Golaszewski , Rob Herring , linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, Manivannan Sadhasivam , Hoan Tran , Sebastian Hesselbarth Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Oct 15, 2020 at 11:59:03AM +0800, Jisheng Zhang wrote: > The compatible string is never used. Before sending v2 could you run "make dt_binding_check" for the DT schema modified in this patch? Like this: make -j8 ARCH=mips CROSS_COMPILE=mipsel-baikal-linux- dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml > > Signed-off-by: Jisheng Zhang > --- > Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml b/Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml > index 1240f6289249..76e7b07d592f 100644 > --- a/Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml > +++ b/Documentation/devicetree/bindings/gpio/snps,dw-apb-gpio.yaml > @@ -50,9 +50,6 @@ patternProperties: > "^gpio-(port|controller)@[0-9a-f]+$": > type: object > properties: > - compatible: > - const: snps,dw-apb-gpio-port > - Yep, you've removed the "compatible" property but forgot to do the same from the "required:" property of the sub-nodes schema. That's why the suggested make-command above would have failed during the DT schema examples validation if you ran it. Please, fix it and resend the series. > reg: > maxItems: 1 Yeah. Here I've forgotten to add the "reg" property constraints. Since certainly the controller won't have more than four sub-nodes by design, could you add one in an additional patch of the series since you'll need to resend the patchset anyway? Like this: reg: - maxItems: 1 + minimum: 0 + maximum: 3 -Sergey > > @@ -111,7 +108,6 @@ examples: > #size-cells = <0>; > > porta: gpio-port@0 { > - compatible = "snps,dw-apb-gpio-port"; > reg = <0>; > gpio-controller; > #gpio-cells = <2>; > @@ -123,7 +119,6 @@ examples: > }; > > portb: gpio-port@1 { > - compatible = "snps,dw-apb-gpio-port"; > reg = <1>; > gpio-controller; > #gpio-cells = <2>; > -- > 2.28.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel