From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D2B2C433DF for ; Thu, 15 Oct 2020 18:07:34 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E9C1422240 for ; Thu, 15 Oct 2020 18:07:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="K9ZT3maV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E9C1422240 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=egr88xLp3nOj6ZNpvH8DEFEGwWyTpiIGdybc6c9Een0=; b=K9ZT3maVjVZJDkXAUVo6FhYcP QZofUkXbHjTkK27qX9IKL1aNC3e9yAOhgAdwbBnBvMeVMEOQ27apSExJUxD+tt47YSsqGRZQrhB/U NbxxI+Zde1HiTF4ndVTHjTiQgWsJVgmjxMXfkJ/Ptzh4d8APvkCLvaxvGX9gRbqbh2mQICPTtlQZ9 1xNMU022P+tVFiICmSRPFft/aqJ9AVXj7idJKpgCDHZSqfAKJGa7q/JKKhoSCW/usrEN+e4ZjemHn UpCCABCTyMTT1u/5S9VPklhtfipwTZs50wIIZY6gcf9+nIRVGu9XXSqTIFPtr/dKpW5/Ps8pjziLb 7WdybeyCA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kT7dj-0003EZ-5x; Thu, 15 Oct 2020 18:06:11 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kT7df-0003Dx-Tr for linux-arm-kernel@lists.infradead.org; Thu, 15 Oct 2020 18:06:08 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E7A0E13D5; Thu, 15 Oct 2020 11:06:03 -0700 (PDT) Received: from bogus (unknown [10.57.17.164]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2879D3F71F; Thu, 15 Oct 2020 11:06:01 -0700 (PDT) Date: Thu, 15 Oct 2020 19:05:55 +0100 From: Sudeep Holla To: Viresh Kumar Subject: Re: [PATCH V2 1/2] opp: Allow dev_pm_opp_get_opp_table() to return -EPROBE_DEFER Message-ID: <20201015180555.gacdzkofpibkdn2e@bogus> References: <24ff92dd1b0ee1b802b45698520f2937418f8094.1598260050.git.viresh.kumar@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <24ff92dd1b0ee1b802b45698520f2937418f8094.1598260050.git.viresh.kumar@linaro.org> User-Agent: NeoMutt/20171215 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201015_140608_008758_5AFC43AA X-CRM114-Status: GOOD ( 16.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nishanth Menon , Len Brown , ulf.hansson@linaro.org, linux-samsung-soc@vger.kernel.org, Vincent Guittot , Stephan Gerhold , Kevin Hilman , Stephen Boyd , Greg Kroah-Hartman , linux-pm@vger.kernel.org, "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , nks@flawful.org, Kukjin Kim , Pavel Machek , Sudeep Holla , georgi.djakov@linaro.org, linux-arm-kernel@lists.infradead.org, Viresh Kumar Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Aug 24, 2020 at 02:39:32PM +0530, Viresh Kumar wrote: > From: Stephan Gerhold > > The OPP core manages various resources, e.g. clocks or interconnect paths. > These resources are looked up when the OPP table is allocated once > dev_pm_opp_get_opp_table() is called the first time (either directly > or indirectly through one of the many helper functions). > > At this point, the resources may not be available yet, i.e. looking them > up will result in -EPROBE_DEFER. Unfortunately, dev_pm_opp_get_opp_table() > is currently unable to propagate this error code since it only returns > the allocated OPP table or NULL. > OK, this breaks with SCMI which doesn't provide clocks but manage OPPs directly. Before this change clk_get(dev..) was allowed to fail and --EPROBE_DEFER was not an error. We use dev_pm_opp_add to add OPPs read from the firmware and this change is preventing that. Sorry for checking this so late, but noticed only when this hit mainline. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel