From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96924C433E7 for ; Fri, 16 Oct 2020 11:51:29 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 208282084C for ; Fri, 16 Oct 2020 11:51:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="vkUGWxjY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 208282084C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qFsSNlysBCZGDDxElLKMYSlUWAF2Z5dOV462XF3rGVc=; b=vkUGWxjYE3eMg/Q0RXdLFE+GO NuE4CTn1iyU7CYoF3yLDg8pZaHviESqlT2GG9zLiYipjCHqQHdTnbm8fSvD0IPNeqLAzvtkfjKswd w1I72g0GavP9JW/q2O87o354wqEOYe5W78EoQnahgkXjuEkytmDEG/d5fRjPraAKg9RJZC6x9OqyG w24iGuJovpcHcqjVqGU73FBJwKz7+ZCICsjF0fuBV31eRgaqI/dNfYfWpQEmc+ztebq69edU2f18v OsfVhXn4Fl7jDnNbIE1estE3bt1Ks9/aU+gAO+hALWDsf4DRs+yyWmZnWvYSNoLtU08BNm4ZHoKPp NXaJsIxUQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kTOFQ-0006cz-Gx; Fri, 16 Oct 2020 11:50:12 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kTOFN-0006cb-4a for linux-arm-kernel@lists.infradead.org; Fri, 16 Oct 2020 11:50:10 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7F0ACD6E; Fri, 16 Oct 2020 04:50:07 -0700 (PDT) Received: from e120937-lin (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C96BE3F66B; Fri, 16 Oct 2020 04:50:06 -0700 (PDT) Date: Fri, 16 Oct 2020 12:50:00 +0100 From: Cristian Marussi To: Lukasz Luba Subject: Re: [PATCH -next] firmware: arm_scmi: Add the trace_scmi_xfer_end Message-ID: <20201016114938.GF34395@e120937-lin> References: <20201016090815.28160-1-zhangqilong3@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201016_075009_244679_080C6489 X-CRM114-Status: GOOD ( 21.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Zhang Qilong , linux-arm-kernel@lists.infradead.org, sudeep.holla@arm.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Oct 16, 2020 at 11:32:00AM +0100, Lukasz Luba wrote: > > > On 10/16/20 10:08 AM, Zhang Qilong wrote: > > Missing the trace_scmi_xfer_end in exception path of scmi_do_xfer. > > > > Signed-off-by: Zhang Qilong > > --- > > drivers/firmware/arm_scmi/driver.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c > > index 03ec74242c14..1a8661514a25 100644 > > --- a/drivers/firmware/arm_scmi/driver.c > > +++ b/drivers/firmware/arm_scmi/driver.c > > @@ -368,7 +368,7 @@ int scmi_do_xfer(const struct scmi_handle *handle, struct scmi_xfer *xfer) > > ret = info->desc->ops->send_message(cinfo, xfer); > > if (ret < 0) { > > dev_dbg(dev, "Failed to send message %d\n", ret); > > - return ret; > > + goto out; > > } > > if (xfer->hdr.poll_completion) { > > @@ -396,6 +396,7 @@ int scmi_do_xfer(const struct scmi_handle *handle, struct scmi_xfer *xfer) > > if (info->desc->ops->mark_txdone) > > info->desc->ops->mark_txdone(cinfo, ret); > > +out: > > trace_scmi_xfer_end(xfer->transfer_id, xfer->hdr.id, > > xfer->hdr.protocol_id, xfer->hdr.seq, ret); > > > > I think it makes sense, the 'begin' trace entry will always be paired > with 'end'. For the post processing the trace, it would be easier to > reconstruct such transfer and mark immediately as 'not sent' (avoiding > to bother about entries which only have 'begin'). > > Sudeep, in case you consider to take it, feel free to add: > > Reviewed-by: Lukasz Luba > Looks good to me. Reviewed-by: Cristian Marussi Thanks Cristian > Regards, > Lukasz > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel