From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A2DDC433E7 for ; Fri, 16 Oct 2020 16:32:27 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 97EF8206A1 for ; Fri, 16 Oct 2020 16:32:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rFL5hsBX"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="B37qAKhl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 97EF8206A1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=USq7sIyYW31n+obPDMiNAC++JGKBbJI2BICcTXs3GYs=; b=rFL5hsBXGcOXQi6I2RGOwGIIP Xt2Et1xjdBp/zcEfYW4RbkhXJ/zN0joOp80zCntpX11kO+G+LMR9GMuZLfLJ3QeLfICeNbQmww9LU yJATcVJp8br+qhtgnVbIgMmU3jJ0GLMGWWX5OhrciQ7scbnbMOdwORU+6SXMaXmhHlGe9HoqldPCQ PfcE1tSvVfcigO6s/RLb1dS8RZs5X8zk4NtJ4j2pUzyRvIxHdtTQF32FK0brPTF+FkxHlegFKhZEM cJWJJyokQxu+JE17MafzTErikDlvCon+lTRNkFwBZOsLy5/IGV6kE4f6YQSFlokPuOXBzU8vygbIb vELnZ3Q8w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kTSdN-0007YJ-5F; Fri, 16 Oct 2020 16:31:13 +0000 Received: from mail-pg1-x543.google.com ([2607:f8b0:4864:20::543]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kTSdH-0007VQ-7N for linux-arm-kernel@lists.infradead.org; Fri, 16 Oct 2020 16:31:11 +0000 Received: by mail-pg1-x543.google.com with SMTP id n9so1750579pgf.9 for ; Fri, 16 Oct 2020 09:31:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ngWRzHXgFHPy5i53Ui/ywmmjGuNtNloCNac1FIdeRAQ=; b=B37qAKhlAWHbfyc7bJHH4NB7PG7hWjfgg2r7HF8pl2x9mcbe0N3kd9ohbS/Yr53sJB XN4TqAOuJwRx10ZUi6sVqKGyBbR81Pb5GBHR3rZCqE0ppUKKK2cjKFhnWO2UEMeRFRNs VakhFnf+GkAlFEHBzqofhpavg1HVPLvU46OuzXHCXQMm28d++AtiQbgAN4CgXKzPhe0e yLGTMiLeXVtDjSPXgO7QSB3pLstp8MV5PmcjUX2MZAajSefUcPFCAddWe8HlSApXbpRq +Q3NaL4W4MjC8GvN3lambFerIYVOFfKe0Dk0s7SnSOPu/DLEjOxyoaZUhodWPtI43aHX +dXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ngWRzHXgFHPy5i53Ui/ywmmjGuNtNloCNac1FIdeRAQ=; b=h/IRd0eaMjxAcDaxMi3YghR4FaVYDlhL2SFIKsBVZCb0mUt8eoTfGvTOfypVKXY20w vbnGkYg7Rlos3cQ7X/cQ+rRVnx7rCzE5eF3fB3ZVKIEi8dunUTpfvBhxYWJ7zYDYBbk+ AkIfEY+b2djeULzOTIuLNmNNdv6DnnXymOb/Bh8G+M5xcc7XPpXEguvcXom/1QEXC2aT 1a5NyloidnyqW+pxPAKwHZ9BNWFgcHqrWtiUnALUthmhGn29sKj8ZwqkixTUzqGMgTfX z8alKdhew4iEZCsVSAwHkwrbxyzCnJhkuLEYmVN9q71/OqqnsQVH0uIgmjDo2PaEYrEB Cssg== X-Gm-Message-State: AOAM5319R1bDMagciHqA4Cy3I3vRI3J3FyhqrbcB+6jEdEUIDv/gEAZq fMQ6XIkRWPDt3ntC6N8YpFkFWA== X-Google-Smtp-Source: ABdhPJx8hiTqCuwIz4lbKvJ5Fw1msi/JR77+ht9hPaB0QMoE48DBqyO1UyUGdczGEQelTvD+mdH4tQ== X-Received: by 2002:a63:140e:: with SMTP id u14mr3644528pgl.91.1602865863679; Fri, 16 Oct 2020 09:31:03 -0700 (PDT) Received: from xps15 (S0106002369de4dac.cg.shawcable.net. [68.147.8.254]) by smtp.gmail.com with ESMTPSA id 131sm3314753pfy.5.2020.10.16.09.31.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Oct 2020 09:31:03 -0700 (PDT) Date: Fri, 16 Oct 2020 10:31:01 -0600 From: Mathieu Poirier To: Sai Prakash Ranjan Subject: Re: [PATCH] coresight: etm4x: Skip setting LPOVERRIDE bit for qcom,skip-power-up Message-ID: <20201016163101.GA3885@xps15> References: <20201016101025.26505-1-saiprakash.ranjan@codeaurora.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201016101025.26505-1-saiprakash.ranjan@codeaurora.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201016_123107_315081_DE9FB1CE X-CRM114-Status: GOOD ( 19.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: denik@chromium.org, Suzuki K Poulose , linux-arm-msm@vger.kernel.org, coresight@lists.linaro.org, linux-kernel@vger.kernel.org, Stephen Boyd , linux-arm-kernel@lists.infradead.org, Mike Leach Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Oct 16, 2020 at 03:40:25PM +0530, Sai Prakash Ranjan wrote: > There is a bug on the systems supporting to skip power up > (qcom,skip-power-up) where setting LPOVERRIDE bit(low-power > state override behaviour) will result in CPU hangs/lockups > even on the implementations which supports it. So skip > setting the LPOVERRIDE bit for such platforms. > > Fixes: 02510a5aa78d ("coresight: etm4x: Add support to skip trace unit power up") > Signed-off-by: Sai Prakash Ranjan > --- > drivers/hwtracing/coresight/coresight-etm4x-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hwtracing/coresight/coresight-etm4x-core.c b/drivers/hwtracing/coresight/coresight-etm4x-core.c > index abd706b216ac..6096d7abf80d 100644 > --- a/drivers/hwtracing/coresight/coresight-etm4x-core.c > +++ b/drivers/hwtracing/coresight/coresight-etm4x-core.c > @@ -779,7 +779,7 @@ static void etm4_init_arch_data(void *info) > * LPOVERRIDE, bit[23] implementation supports > * low-power state override > */ > - if (BMVAL(etmidr5, 23, 23)) > + if (BMVAL(etmidr5, 23, 23) && (!drvdata->skip_power_up)) > drvdata->lpoverride = true; > else > drvdata->lpoverride = false; > I have applied your patch. Thanks, Mathieu > base-commit: 3477326277451000bc667dfcc4fd0774c039184c > -- > QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member > of Code Aurora Forum, hosted by The Linux Foundation > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel