From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A882C433E7 for ; Fri, 16 Oct 2020 17:17:41 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C102A20704 for ; Fri, 16 Oct 2020 17:17:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="EJKjovUU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C102A20704 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=OUR9hE2ICzpqQ5tWq+0a7xKZa6ad6YzAi1KjdYPKLPI=; b=EJKjovUUslyQOJ9hPOjKqwZSY zUmLuVUNf3hc0xHy/5l7LYzlZcDAUoI+EFh8xB9clc1lPum6Kxd64jeBgtdCHg5aW5LOHj0gBizql 7WAcZk4QT6ZLC+oMbpvxbB+7Q0NV9qQTiFOIreMtJcxNWVIvAUSSu0iRCeKDF1MStVGGl+GPzxUdL lCyoDHIc1jzxxXEvZpZfdks6jeBwZNO4hOkH0anUNmeeNaxS/Od3wnwWtj/F0EyH17W8p6w1OGS7D E+P6x7cIYDKxAkwTaclbu816bEPTHNPcgBnhp5Pxa1so6kgRQ7f8mCoc26BgCg55Vk3KcXiJhpmlA wbP7AIr+w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kTTL0-0005WD-KN; Fri, 16 Oct 2020 17:16:18 +0000 Received: from mail-ot1-f65.google.com ([209.85.210.65]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kTTKx-0005VQ-Nf for linux-arm-kernel@lists.infradead.org; Fri, 16 Oct 2020 17:16:16 +0000 Received: by mail-ot1-f65.google.com with SMTP id f37so3033922otf.12 for ; Fri, 16 Oct 2020 10:16:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ZmPWxKpDTknAmEe7UdqFdRj8Owf4EcjFeMtD8aGa6yA=; b=nOWMxCD6Q7DqCmvJUveC8Y4z1QbY+MJzSfwZ2JnZUJeHh/HKSPTpJBBfV6QwB8wpCe I3GAzyb7k/3GhP6iB3bJTlLbggYVTuuCRHD8Hr5huoSkyA7JImh6Oqz7mnfUMjpP9wnH /pphhO4erN/iGN+t3UNb0dL0rcR31s2hXetxfSiUv+p9jAjXB4gsSmVwtS11tKTOxeGH mCyTHg7YszgOYXj2AHvNwyoy6BAlfNdbrOWZpYUxc1QaWfLAKknMfX347TpaLVmTxp49 cKSY3NrGd/+sWxJpWxHzqfxiFABXlPi9EUgkaKN+u6LRyBihRQKlOA+t7ocvyaj/Fcyv rFsA== X-Gm-Message-State: AOAM532y7j6OAQXOD+xiJCf1FqOHEcVO6URuNZFrB+jL+4I+6jpVtsyo PYY67JYUbOMtLFWdJ65EcQ== X-Google-Smtp-Source: ABdhPJwNFTc03Dpq8hQaQDs+x9At0y/IfS8Tw88Q4LOwNP/y70SOX0/J9aHLsKBqBo0dt8/jeyr6pw== X-Received: by 2002:a05:6830:13c5:: with SMTP id e5mr3209070otq.319.1602868574593; Fri, 16 Oct 2020 10:16:14 -0700 (PDT) Received: from xps15 (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id p11sm1158258otp.8.2020.10.16.10.16.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Oct 2020 10:16:13 -0700 (PDT) Received: (nullmailer pid 1595441 invoked by uid 1000); Fri, 16 Oct 2020 17:16:12 -0000 Date: Fri, 16 Oct 2020 12:16:12 -0500 From: Rob Herring To: Billy Tsai Subject: Re: [PATCH 3/3] iio: adc: aspeed: Setting ref_voltage in probe Message-ID: <20201016171612.GA1593560@bogus> References: <20201013103245.16723-1-billy_tsai@aspeedtech.com> <20201013103245.16723-4-billy_tsai@aspeedtech.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201013103245.16723-4-billy_tsai@aspeedtech.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201016_131615_792461_A6B45F11 X-CRM114-Status: GOOD ( 20.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, lars@metafoo.de, p.zabel@pengutronix.de, linux-aspeed@lists.ozlabs.org, BMC-SW@aspeedtech.com, andrew@aj.id.au, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, joel@jms.id.au, pmeerw@pmeerw.net, knaack.h@gmx.de, alexandru.ardelean@analog.com, jic23@kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Oct 13, 2020 at 06:32:45PM +0800, Billy Tsai wrote: > At ast2600 ref_voltage becomes configurable and this property is board > dependency. > > Signed-off-by: Billy Tsai > --- > .../devicetree/bindings/iio/adc/aspeed_adc.txt | 16 +++++++++++++++- > 1 file changed, 15 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/iio/adc/aspeed_adc.txt b/Documentation/devicetree/bindings/iio/adc/aspeed_adc.txt > index 034fc2ba100e..0ba1980c4e06 100644 > --- a/Documentation/devicetree/bindings/iio/adc/aspeed_adc.txt > +++ b/Documentation/devicetree/bindings/iio/adc/aspeed_adc.txt > @@ -3,8 +3,11 @@ Aspeed ADC > This device is a 10-bit converter for 16 voltage channels. All inputs are > single ended. > > +At ast2600, this device split into two individual IPs and each contains 8 voltage channels. > + > +Chip level dtsi: > Required properties: > -- compatible: Should be "aspeed,ast2400-adc" or "aspeed,ast2500-adc" > +- compatible: Should be "aspeed,ast2400-adc" or "aspeed,ast2500-adc" or "aspeed,ast2600-adc" > - reg: memory window mapping address and length > - clocks: Input clock used to derive the sample clock. Expected to be the > SoC's APB clock. > @@ -20,3 +23,14 @@ Example: > resets = <&syscon ASPEED_RESET_ADC>; > #io-channel-cells = <1>; > }; > + > +Board level dts: This split is convention, but not relevant to the binding. > +Required properties: > +- ref_voltage: (ast2600 only) s/_/-/ And needs a vendor prefix. > + - Reference voltage in millivolts for the conversions. > + - The range of value is 900 to 2700 mv. > + > +Example: > +&adc0 { > + ref_voltage = <2500>; > +}; > \ No newline at end of file Fix this. > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel