From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7837C433E7 for ; Fri, 16 Oct 2020 18:18:34 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D1FB22083B for ; Fri, 16 Oct 2020 18:18:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Dxq7OiAL"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="W5g+DZ0Y" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D1FB22083B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mqcPSMxtDUeXCdfWEXFYcDopLI2HMLXW70myMQEwB4A=; b=Dxq7OiAL/1zmRAoBsJp5j2dx6 4faUXe4s0bcSlblxMH3SyFNGB9KebEtZ6PRyQZRLB0+6UV8p4JgSLTF1A4AczUfwbOxeHCu30vfhy Zzq8Jd3lR8iagFcbYQtbEADQwM8xC1NXHrdwWiOA2MCvZBZhJDoIzDnPjf0PTgsOUonTV16fROaCZ buMdiJUAiEVWzq7mPN9xuGTo7UliErceTkrIW7t3+juKdOWb8beQ8kiLPk44IhRvTeGfT09LlmwNP e/VjEdCKyQ5f1CvmmO6gDNXM3NPR8K4Yw80ZnxgoHs83PndC/78kGJpGB6epZI1qQHDH1xTvp3eL6 bdHCs2+iA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kTUHd-0005Xf-KB; Fri, 16 Oct 2020 18:16:53 +0000 Received: from mail-ot1-x344.google.com ([2607:f8b0:4864:20::344]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kTUHa-0005Wr-An for linux-arm-kernel@lists.infradead.org; Fri, 16 Oct 2020 18:16:51 +0000 Received: by mail-ot1-x344.google.com with SMTP id d28so3282598ote.1 for ; Fri, 16 Oct 2020 11:16:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=lXUFwXy4CvWitPRBtcqz4P6w54dAmXcel3/G3PMWxJk=; b=W5g+DZ0Y+oLih8JHD8yavPz/uC0IhD0zJoUh59V8GVOd6SaaZhHBMLTt5ePflQ91pd /1kUpypg2gwGTndoH0SOMQ4qGBOfD1mSG1DMPuGMWpbezFoZsdHnDTHT/Upbey6/L7Kz 3GbgLp8aWQrW9HWuXCtjyFqQLxE89a5b7wnqwGUQYZLS+4Jh5eLuKFL8LKEBgTyCo33S U3YHhKl8uN7kEOqUvYujVmRpHlbqNeh6F5yC2ElknhcZQYLtsmAaIwLgKodysE0Y41X3 0qolVLm8P4JKYAIGBsu92Ii6hNPuaG9/tQM1oo7Wn8aGOXh9DQEX2sR00NElZLhkt2Nv BY7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=lXUFwXy4CvWitPRBtcqz4P6w54dAmXcel3/G3PMWxJk=; b=kO63qpgo44IDPi6Z66qZlh+J8o7SQq/y8H1dM0PHJRvo5tdP8/Z2VXZZrF9XCcUFrg S/pXmoTRZcx+I0mPfpFMb1oWyAa5td25jqVL3Grk62KN7eccetyt6KVdIxLNEfnISCCY ab6zxD7881EvSUQDK8pKqldzRaSNkbrk1JsfWfZhSloCOWOR4A8E4t1xY5m78UW9oJGB LNs76gBkLJFEspucZdu+X4cQp7wnvA0Eg2xDR7UDxmvXBYmzqTDVyFnaNyB70rYEgcBL /Rr03NDrZWkJA16trcQ0bbDtNaCVryXgeeOFGhf6nANbRBTl5YxxYCsJosveMjZ14el7 9MwQ== X-Gm-Message-State: AOAM531D2LtnLgPWZ5Mc3dlPQMIqt1XTD/gAYf5VgGAwu7Jkx9K36vhC JEjs6u8JAqiS75x0aw4JROiERJ9lsTR56Q== X-Google-Smtp-Source: ABdhPJxMlYFEmvPd/oJ+AQMXJK2Q7X41clGIcOfyf7fGkqn3XjCTTzI8bIyIQwbfPa70i7PTr009ZA== X-Received: by 2002:a9d:7315:: with SMTP id e21mr3387087otk.372.1602872206412; Fri, 16 Oct 2020 11:16:46 -0700 (PDT) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id e30sm1173034otf.49.2020.10.16.11.16.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Oct 2020 11:16:45 -0700 (PDT) Date: Fri, 16 Oct 2020 13:11:35 -0500 From: Bjorn Andersson To: Ulf Hansson Subject: Re: [PATCH 1/4] power: avs: qcom-cpr: Move the driver to the qcom specific drivers Message-ID: <20201016181135.GB6705@builder.lan> References: <20201006160516.319830-1-ulf.hansson@linaro.org> <20201006160516.319830-2-ulf.hansson@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201006160516.319830-2-ulf.hansson@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201016_141650_378238_8CFEBF0C X-CRM114-Status: GOOD ( 23.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nishanth Menon , Heiko Stuebner , Aaro Koskinen , Tony Lindgren , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, "Rafael J . Wysocki" , linux-kernel@vger.kernel.org, Niklas Cassel , Kevin Hilman , Andy Gross , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue 06 Oct 11:05 CDT 2020, Ulf Hansson wrote: > The avs drivers are all SoC specific drivers that doesn't share any code. > Instead they are located in a directory, mostly to keep similar > functionality together. From a maintenance point of view, it makes better > sense to collect SoC specific drivers like these, into the SoC specific > directories. > > Therefore, let's move the qcom-cpr driver to the qcom directory. > > Cc: Niklas Cassel > Cc: Bjorn Andersson > Cc: Andy Gross > Cc: linux-arm-msm@vger.kernel.org > Signed-off-by: Ulf Hansson Acked-by: Bjorn Andersson Regards, Bjorn > --- > MAINTAINERS | 2 +- > drivers/power/avs/Kconfig | 16 ---------------- > drivers/power/avs/Makefile | 1 - > drivers/soc/qcom/Kconfig | 16 ++++++++++++++++ > drivers/soc/qcom/Makefile | 1 + > drivers/{power/avs/qcom-cpr.c => soc/qcom/cpr.c} | 0 > 6 files changed, 18 insertions(+), 18 deletions(-) > rename drivers/{power/avs/qcom-cpr.c => soc/qcom/cpr.c} (100%) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 4f1a56f6efaa..f51dd1944fe6 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -14337,7 +14337,7 @@ L: linux-pm@vger.kernel.org > L: linux-arm-msm@vger.kernel.org > S: Maintained > F: Documentation/devicetree/bindings/power/avs/qcom,cpr.txt > -F: drivers/power/avs/qcom-cpr.c > +F: drivers/soc/qcom/cpr.c > > QUALCOMM CPUFREQ DRIVER MSM8996/APQ8096 > M: Ilia Lin > diff --git a/drivers/power/avs/Kconfig b/drivers/power/avs/Kconfig > index cdb4237bfd02..089b6244b716 100644 > --- a/drivers/power/avs/Kconfig > +++ b/drivers/power/avs/Kconfig > @@ -12,22 +12,6 @@ menuconfig POWER_AVS > > Say Y here to enable Adaptive Voltage Scaling class support. > > -config QCOM_CPR > - tristate "QCOM Core Power Reduction (CPR) support" > - depends on POWER_AVS && HAS_IOMEM > - select PM_OPP > - select REGMAP > - help > - Say Y here to enable support for the CPR hardware found on Qualcomm > - SoCs like QCS404. > - > - This driver populates CPU OPPs tables and makes adjustments to the > - tables based on feedback from the CPR hardware. If you want to do > - CPUfrequency scaling say Y here. > - > - To compile this driver as a module, choose M here: the module will > - be called qcom-cpr > - > config ROCKCHIP_IODOMAIN > tristate "Rockchip IO domain support" > depends on POWER_AVS && ARCH_ROCKCHIP && OF > diff --git a/drivers/power/avs/Makefile b/drivers/power/avs/Makefile > index 9007d05853e2..a1b8cd453f19 100644 > --- a/drivers/power/avs/Makefile > +++ b/drivers/power/avs/Makefile > @@ -1,4 +1,3 @@ > # SPDX-License-Identifier: GPL-2.0-only > obj-$(CONFIG_POWER_AVS_OMAP) += smartreflex.o > -obj-$(CONFIG_QCOM_CPR) += qcom-cpr.o > obj-$(CONFIG_ROCKCHIP_IODOMAIN) += rockchip-io-domain.o > diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig > index 3dc3e3d61ea3..6a3b69b43ad5 100644 > --- a/drivers/soc/qcom/Kconfig > +++ b/drivers/soc/qcom/Kconfig > @@ -26,6 +26,22 @@ config QCOM_COMMAND_DB > resource on a RPM-hardened platform must use this database to get > SoC specific identifier and information for the shared resources. > > +config QCOM_CPR > + tristate "QCOM Core Power Reduction (CPR) support" > + depends on ARCH_QCOM && HAS_IOMEM > + select PM_OPP > + select REGMAP > + help > + Say Y here to enable support for the CPR hardware found on Qualcomm > + SoCs like QCS404. > + > + This driver populates CPU OPPs tables and makes adjustments to the > + tables based on feedback from the CPR hardware. If you want to do > + CPUfrequency scaling say Y here. > + > + To compile this driver as a module, choose M here: the module will > + be called qcom-cpr > + > config QCOM_GENI_SE > tristate "QCOM GENI Serial Engine Driver" > depends on ARCH_QCOM || COMPILE_TEST > diff --git a/drivers/soc/qcom/Makefile b/drivers/soc/qcom/Makefile > index 93392d9dc7f7..ad675a6593d0 100644 > --- a/drivers/soc/qcom/Makefile > +++ b/drivers/soc/qcom/Makefile > @@ -3,6 +3,7 @@ CFLAGS_rpmh-rsc.o := -I$(src) > obj-$(CONFIG_QCOM_AOSS_QMP) += qcom_aoss.o > obj-$(CONFIG_QCOM_GENI_SE) += qcom-geni-se.o > obj-$(CONFIG_QCOM_COMMAND_DB) += cmd-db.o > +obj-$(CONFIG_QCOM_CPR) += cpr.o > obj-$(CONFIG_QCOM_GSBI) += qcom_gsbi.o > obj-$(CONFIG_QCOM_MDT_LOADER) += mdt_loader.o > obj-$(CONFIG_QCOM_OCMEM) += ocmem.o > diff --git a/drivers/power/avs/qcom-cpr.c b/drivers/soc/qcom/cpr.c > similarity index 100% > rename from drivers/power/avs/qcom-cpr.c > rename to drivers/soc/qcom/cpr.c > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel