From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C6F6C433DF for ; Mon, 19 Oct 2020 05:35:33 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BBD5422243 for ; Mon, 19 Oct 2020 05:35:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ruZmN0a3"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="D5m23CSA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BBD5422243 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=bZdwon+Mb8A1WAyR5g7m83PqOzCLd9Uon+w3QJnKM+M=; b=ruZmN0a3HEVBrgccaDhVr7qWl xWkMRedP1QzVbtkUKnGyqUXkT+V5o/MzLogLEpqEWs+8ucWD2OQRISdELiKBZBWspQe57L1TIceM+ DItmsFmOY296d/8tnPCBzYnD6zmNgw3NbfRwcJquFiD46afYb/MBTGw59ytDwWzCoSMfcqlZ6fJhJ lmuBHywCEq3BL2c6awPSZsgvDq5LNTORfQ4sYcBc9IMIX0rTZpl8AnlyXhRJAmYxeeJ879APB7o3i Hp/Iq3srZzUEhs8n9xtFLYkXEQxXgofJNpokhwRV5MWBejRBJpTupOz4LlvM4OmTJwUv4qszagyM2 cKDTgGUvw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kUNne-0007zl-7M; Mon, 19 Oct 2020 05:33:38 +0000 Received: from mail-pj1-x1043.google.com ([2607:f8b0:4864:20::1043]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kUNnc-0007zG-4V for linux-arm-kernel@lists.infradead.org; Mon, 19 Oct 2020 05:33:36 +0000 Received: by mail-pj1-x1043.google.com with SMTP id gm14so4706483pjb.2 for ; Sun, 18 Oct 2020 22:33:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=KFWrTk4/MZRsh73cemPCA+garm+vxmS38qR0bZiOZMU=; b=D5m23CSAnlxOO264W+obGZxOzdlnF5kbJtbqFPYGXT/1ng15hfHIkYILhDQXXsvy4j zL+zDNS/DuvNsPsob4Nm1eUo22ayfH+h3/i+USeUoR2pkGMl+tfUYgTc6Um04L+dicoe wPFdXJin4rGYOiJmznv8KWU++Lhsmp/dLJ/3BzqUke55Ao/p+yD1RSyew0dnUA/yGzB5 F95ePr1i8cXh8XtkcRaxp09dMDGJUm90GGpWo+uN6XqNEmwI+Br94ux670UWfcGpVdBx oHWPjKSxhqOCkWM9Bac0XZCY34DZcoQ+KP8Iw/+OEShRMBnj8KbT9qXcofaVztOdhNR/ 2LeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=KFWrTk4/MZRsh73cemPCA+garm+vxmS38qR0bZiOZMU=; b=GwsWldz+cEIs8MmsupTdEb9gJXcl85xXa4SIg1dYDdirhZ9Bm2o3zuCLkeclaKphGq 9DamjxWyLy/8XLHGTzIBqO+pCMD7HlqQZVHX5oFiw2WQQi2k+J0oLpN4YEQ7J+6m1HhE 8mLDhAewRaeAvVOl6ACti7ecwYfWYSVUKmRp4cn042cFF55LDpkWd+w6FwULkY2/6S/7 lMkTJyw74MyfwfnsTexfoau8SG196bI0u/HB9Gwy3N9dR+sKTRe/QVBiBand56TLbLtV ZetXrkwblYxsSPzIYTw9cEuFg5EC4a7BPLp2bsKHK4e2o1JlRGplxzeEyuC1HecM9mZj +EsA== X-Gm-Message-State: AOAM531W2DIdRxiXqBPDOksSTEeadFFSKFrMGm9gweWqUTA+9plHPTHV 8UrGbvyjVPE0XU+lRq1bkmw= X-Google-Smtp-Source: ABdhPJxKgO51xEOj5gm51q6eAqM7pKz0IiBuhoU/oD9zmT7Jv0FsRD5MIHf9f2kMRzvcaon12XRAFQ== X-Received: by 2002:a17:90a:f685:: with SMTP id cl5mr15761445pjb.210.1603085612528; Sun, 18 Oct 2020 22:33:32 -0700 (PDT) Received: from taoren-ubuntu-R90MNF91 (c-73-252-146-110.hsd1.ca.comcast.net. [73.252.146.110]) by smtp.gmail.com with ESMTPSA id q6sm10759022pfn.10.2020.10.18.22.33.30 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 18 Oct 2020 22:33:31 -0700 (PDT) Date: Sun, 18 Oct 2020 22:33:25 -0700 From: Tao Ren To: Billy Tsai Subject: Re: [PATCH] gpio: aspeed: fix ast2600 bank properties Message-ID: <20201019053324.GA4300@taoren-ubuntu-R90MNF91> References: <20201019045026.10732-1-billy_tsai@aspeedtech.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201019045026.10732-1-billy_tsai@aspeedtech.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201019_013336_205731_9A982FB6 X-CRM114-Status: GOOD ( 19.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: BMC-SW@aspeedtech.com, linux-aspeed@lists.ozlabs.org, linux-gpio@vger.kernel.org, andrew@aj.id.au, linus.walleij@linaro.org, bgolaszewski@baylibre.com, joel@jms.id.au, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Billy, On Mon, Oct 19, 2020 at 12:50:26PM +0800, Billy Tsai wrote: > GPIO_T is mapped to the most significant byte of input/output mask, and > the byte in "output" mask should be 0 because GPIO_T is input only. All > the other bits need to be 1 because GPIO_Q/R/S support both input and > output modes. > > Signed-off-by: Billy Tsai You may want to add "Fixes" tag if you take it as a bug fix? For example: Fixes: ab4a85534c3e ("gpio: aspeed: Add in ast2600 details to Aspeed driver") > --- > drivers/gpio/gpio-aspeed.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpio/gpio-aspeed.c b/drivers/gpio/gpio-aspeed.c > index d07bf2c3f136..f24754b3f6d1 100644 > --- a/drivers/gpio/gpio-aspeed.c > +++ b/drivers/gpio/gpio-aspeed.c > @@ -1114,6 +1114,7 @@ static const struct aspeed_gpio_config ast2500_config = > > static const struct aspeed_bank_props ast2600_bank_props[] = { > /* input output */ > + {4, 0xffffffff, 0x00ffffff}, /* Q/R/S/T */ Reviewed-by: Tao Ren > {5, 0xffffffff, 0xffffff00}, /* U/V/W/X */ > {6, 0x0000ffff, 0x0000ffff}, /* Y/Z */ > { }, > -- > 2.17.1 > Cheers, Tao _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel