From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC10FC433DF for ; Mon, 19 Oct 2020 16:29:51 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3328B21D81 for ; Mon, 19 Oct 2020 16:29:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="x17mDuDz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3328B21D81 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=rowland.harvard.edu Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Znc3H5+AoMgZ8RcS9GIjqvZsCp4GQOjV61D0Jr3Cdzs=; b=x17mDuDzJl1SMA7OBcQOLoPIv AO5Kef10CnsE6PEE5+LUNGKa2wSjQExCRiy9C3o3iV3pM0Qbj6fzgQetfcndb5tlMET7CTk3JNjr8 jMLhK1OKTsdw+DhV1TbScRdaef/7T29HwnPwylyhq6pJfOnWbHD5kx+Ptv65QN4n7jfWx3koP+G+M 9x5r0BAToNiEGkhmo38w/gbP2zutvLcbvzLpmWd3jZ/ChPlGI8nZMBAXX2n62IaGCJJsR6JcWDBlc aJey6Kd+lBWKfaS7F6k9chpg+qV+6tmN6SM5PHFST6oZtj+95ghsxSL0tI8UAKcTdFvmJj/2dHlvY M0JRF++yA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kUY1J-0002E0-Js; Mon, 19 Oct 2020 16:28:25 +0000 Received: from netrider.rowland.org ([192.131.102.5]) by merlin.infradead.org with smtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kUY1G-0002Ce-5H for linux-arm-kernel@lists.infradead.org; Mon, 19 Oct 2020 16:28:23 +0000 Received: (qmail 902120 invoked by uid 1000); 19 Oct 2020 12:28:19 -0400 Date: Mon, 19 Oct 2020 12:28:19 -0400 From: Alan Stern To: Thomas Gleixner Subject: Re: [patch V2 08/13] usb: hosts: Remove in_interrupt() from comments Message-ID: <20201019162819.GA898631@rowland.harvard.edu> References: <20201019100629.419020859@linutronix.de> <20201019101110.439968251@linutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201019101110.439968251@linutronix.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201019_122822_250155_3F4C5327 X-CRM114-Status: GOOD ( 17.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Felipe Balbi , linux-samsung-soc@vger.kernel.org, Mathias Nyman , Peter Zijlstra , Greg Kroah-Hartman , Sebastian Andrzej Siewior , linux-usb@vger.kernel.org, LKML , Krzysztof Kozlowski , Johan Hovold , Thomas Winischhofer , Kukjin Kim , Valentina Manea , Duncan Sands , "Ahmed S. Darwish" , linux-omap@vger.kernel.org, Shuah Khan , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Oct 19, 2020 at 12:06:37PM +0200, Thomas Gleixner wrote: > From: Ahmed S. Darwish > > The usage of in_interrupt() in drivers is phased out for various reasons. > > Various comments use !in_interrupt() to describe calling context for probe() > and remove() functions. That's wrong because the calling context has to be > preemptible task context, which is not what !in_interrupt() describes. > > Cleanup the comments. While at it add the missing kernel doc argument > descriptors. > > Signed-off-by: Ahmed S. Darwish > Signed-off-by: Sebastian Andrzej Siewior > Signed-off-by: Thomas Gleixner > Acked-by: Krzysztof Kozlowski > Cc: Alan Stern > Cc: Greg Kroah-Hartman > Cc: linux-usb@vger.kernel.org > Cc: linux-omap@vger.kernel.org > Cc: Kukjin Kim > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-samsung-soc@vger.kernel.org > --- > V2: Split out the static change and add a missing comment > --- > drivers/usb/host/ehci-fsl.c | 9 ++++----- > drivers/usb/host/ehci-pmcmsp.c | 11 +++++++---- > drivers/usb/host/ohci-at91.c | 11 ++++++++--- > drivers/usb/host/ohci-omap.c | 9 ++++++--- > drivers/usb/host/ohci-pxa27x.c | 11 ++++++----- > drivers/usb/host/ohci-s3c2410.c | 12 ++++++------ > 6 files changed, 37 insertions(+), 26 deletions(-) Acked-by: Alan Stern _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel