From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7720CC433E7 for ; Mon, 19 Oct 2020 16:29:59 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EFEBA21D81 for ; Mon, 19 Oct 2020 16:29:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ONX3Hrmz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EFEBA21D81 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=rowland.harvard.edu Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0mtcxh61trI+uxetkFTqhx3LcJnIwvq2kOXfCpcc0SM=; b=ONX3HrmzYxsm6p9xVdoaALAQj KQZyBwXpbK/SsVZpRGenYxBvfCMgyaz2sDk45CkFmgxGXzaZQ1o8BJXhEFiIVJR0Gdif+yaBqPpvE 2M9IXcxt6AIucmvjfmmmvOUiQm+7RTcQYuUjlvv36DTsEjldDg/yh2iTwu3U7wt93rLloUIB3CFoQ 4G0Q55UwKV6sJcYea/6eBG8hT7Avb58F/KQbCX5OPIM/S0209z5l70XletlsaXusMyBKjeNTmca/h Qgw6s5rIK1pByACj2p2zypOXOzlg+BiiSyNL6MPfwsVU4lARjCHjeQqlIpHVIYcJY575Vpj24SKrJ 0mCX04PMA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kUY1X-0002IT-SS; Mon, 19 Oct 2020 16:28:39 +0000 Received: from netrider.rowland.org ([192.131.102.5]) by merlin.infradead.org with smtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kUY1U-0002HM-GE for linux-arm-kernel@lists.infradead.org; Mon, 19 Oct 2020 16:28:38 +0000 Received: (qmail 902187 invoked by uid 1000); 19 Oct 2020 12:28:35 -0400 Date: Mon, 19 Oct 2020 12:28:35 -0400 From: Alan Stern To: Thomas Gleixner Subject: Re: [patch V2 11/13] usb: gadget: udc: Remove in_interrupt()/in_irq() from comments Message-ID: <20201019162835.GC898631@rowland.harvard.edu> References: <20201019100629.419020859@linutronix.de> <20201019101110.744172050@linutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201019101110.744172050@linutronix.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201019_122837_260429_6EE3367A X-CRM114-Status: GOOD ( 21.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Felipe Balbi , Thomas Winischhofer , Mathias Nyman , Peter Zijlstra , Greg Kroah-Hartman , Sebastian Andrzej Siewior , linux-usb@vger.kernel.org, LKML , Krzysztof Kozlowski , Johan Hovold , linux-samsung-soc@vger.kernel.org, Kukjin Kim , Valentina Manea , Duncan Sands , "Ahmed S. Darwish" , linux-omap@vger.kernel.org, Shuah Khan , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Oct 19, 2020 at 12:06:40PM +0200, Thomas Gleixner wrote: > From: Ahmed S. Darwish > > The usage of in_irq()/in_interrupt() in drivers is phased out for various > reasons. > > The context description for usb_gadget_giveback_request() is misleading as > in_interupt() means: hard interrupt or soft interrupt or bottom half > disabled regions. But it's also invoked from task context when endpoints > are torn down. Remove it as it's more confusing than helpful. > > Replace also the in_irq() comment with plain text. > > Signed-off-by: Ahmed S. Darwish > Signed-off-by: Sebastian Andrzej Siewior > Signed-off-by: Thomas Gleixner > Cc: Felipe Balbi > Cc: Greg Kroah-Hartman > Cc: linux-usb@vger.kernel.org > > --- > drivers/usb/gadget/udc/core.c | 2 -- > drivers/usb/gadget/udc/dummy_hcd.c | 6 ++++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > --- a/drivers/usb/gadget/udc/core.c > +++ b/drivers/usb/gadget/udc/core.c > @@ -894,8 +894,6 @@ EXPORT_SYMBOL_GPL(usb_gadget_unmap_reque > * @ep: the endpoint to be used with with the request > * @req: the request being given back > * > - * Context: in_interrupt() > - * > * This is called by device controller drivers in order to return the > * completed request back to the gadget layer. > */ > --- a/drivers/usb/gadget/udc/dummy_hcd.c > +++ b/drivers/usb/gadget/udc/dummy_hcd.c > @@ -1754,8 +1754,10 @@ static int handle_control_request(struct > return ret_val; > } > > -/* drive both sides of the transfers; looks like irq handlers to > - * both drivers except the callbacks aren't in_irq(). > +/* > + * Drive both sides of the transfers; looks like irq handlers to both > + * drivers except that the callbacks are invoked from soft interrupt > + * context. > */ > static void dummy_timer(struct timer_list *t) > { For dummy-hcd.c: Acked-by: Alan Stern _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel