From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72943C433E7 for ; Mon, 19 Oct 2020 16:30:07 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EC7A121D81 for ; Mon, 19 Oct 2020 16:30:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="c7L9ocpU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EC7A121D81 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=rowland.harvard.edu Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=J2SWG+45fq5m91kOPBArVDhic6/oYlvSNrFqbjOYlzU=; b=c7L9ocpUTjy2vnCqgtUbWcIX2 cog4A/E/HGFirWxyEVbnzT4rmm4v94+2bmmqgRP/0cEnB0wjS6TIFram0FC4AgIYZiRnfvhv5XhJH xLi3KsoB1n9DdzsRzJfLfTpGgwnjDBKBVBcMMK0rGkXisbbFkxhqQr2o+qa0IlkRorXCgSfemWnMI LplqTguYuILZibWXT7heSVwGgfSmsS1BheNvqdU7Lu6+q8WEIR4ntSP22pq4O4vnidV1SsYFKlmXo 6VmqFRVJ8xknXEqBYUf0gL5SU4p8RW7fipEe/40jIsO8/zvKIuzOCKGzO/SsTaAellA/+l6eH2gJ/ 1q+0iaScw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kUY1j-0002Lk-2Q; Mon, 19 Oct 2020 16:28:51 +0000 Received: from netrider.rowland.org ([192.131.102.5]) by merlin.infradead.org with smtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kUY1Z-0002Iu-2J for linux-arm-kernel@lists.infradead.org; Mon, 19 Oct 2020 16:28:42 +0000 Received: (qmail 902215 invoked by uid 1000); 19 Oct 2020 12:28:40 -0400 Date: Mon, 19 Oct 2020 12:28:40 -0400 From: Alan Stern To: Thomas Gleixner Subject: Re: [patch V2 12/13] usb: core: Replace in_interrupt() in comments Message-ID: <20201019162840.GD898631@rowland.harvard.edu> References: <20201019100629.419020859@linutronix.de> <20201019101110.851821025@linutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201019101110.851821025@linutronix.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201019_122841_234935_C16C6866 X-CRM114-Status: GOOD ( 17.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Felipe Balbi , Thomas Winischhofer , Mathias Nyman , Peter Zijlstra , Greg Kroah-Hartman , Sebastian Andrzej Siewior , linux-usb@vger.kernel.org, LKML , Krzysztof Kozlowski , Johan Hovold , linux-samsung-soc@vger.kernel.org, Kukjin Kim , Valentina Manea , Duncan Sands , "Ahmed S. Darwish" , linux-omap@vger.kernel.org, Shuah Khan , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Oct 19, 2020 at 12:06:41PM +0200, Thomas Gleixner wrote: > From: Ahmed S. Darwish > > The usage of in_interrupt() in drivers is phased out for various reasons. > > Various comments use !in_interrupt() to describe calling context for > functions which might sleep. That's wrong because the calling context has > to be preemptible task context, which is not what !in_interrupt() > describes. > > Replace !in_interrupt() with more accurate plain text descriptions. > > The comment for usb_hcd_poll_rh_status() is misleading as this function is > called from all kinds of contexts including preemptible task > context. Remove it as there is obviously no restriction. > > Signed-off-by: Ahmed S. Darwish > Signed-off-by: Sebastian Andrzej Siewior > Signed-off-by: Thomas Gleixner > Cc: Greg Kroah-Hartman > Cc: linux-usb@vger.kernel.org > --- > V2: Fixup the comments according to review (Alan) > --- > drivers/usb/core/buffer.c | 6 ++++-- > drivers/usb/core/hcd-pci.c | 6 ++++-- > drivers/usb/core/hcd.c | 26 +++++++++++++++++--------- > drivers/usb/core/hub.c | 3 ++- > drivers/usb/core/message.c | 35 ++++++++++++++++++++++------------- > drivers/usb/core/usb.c | 4 ++-- > 6 files changed, 51 insertions(+), 29 deletions(-) Acked-by: Alan Stern _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel