From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9663AC433E7 for ; Mon, 19 Oct 2020 17:26:12 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 078482224D for ; Mon, 19 Oct 2020 17:26:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gbJwjEWZ"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="iG9L1a5a" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 078482224D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=PZ1KBXrw9k2zWUePSkTAlu8RevkyXYSXfeT6CcbwK+M=; b=gbJwjEWZZAqBoEcmHs71Hi5xw /WhDm6ePrzJd79DVqyk3bN+6p7HFAmC9Z0E6ZorFVIQwBsJ6vHChwE/ejpRLqREhr4uEsrYepMAhH O/rnqc4A5215y/SNGZoBofPVVOT1zTkM44L9kTUxTjZY2fcnymPA0FMiAJgAmyqswfBaNQUghDyb3 uFrmYs1gl3JiKvvJs9dZZrHK/eB1OzS7/Bwn1KQ3Zfe7GLiJ8J+6NBeHxnaziSML25KJ+eR7eeKC/ N9F3o7r8hvoyaWOzG4YCaqD9RUCZ4PpFNhkpBwcR10EoWjvMovuMl/Pas84PYZUix4UIt6ha61F3g V1Vf1vzsg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kUYtz-0001Ki-VJ; Mon, 19 Oct 2020 17:24:56 +0000 Received: from mail-pg1-x544.google.com ([2607:f8b0:4864:20::544]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kUYty-0001K7-13 for linux-arm-kernel@lists.infradead.org; Mon, 19 Oct 2020 17:24:54 +0000 Received: by mail-pg1-x544.google.com with SMTP id x13so345900pgp.7 for ; Mon, 19 Oct 2020 10:24:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=DqfFRCqrVOSLRxnsHHHALVeB4MkQYOkvAR6pk7ZJ5hs=; b=iG9L1a5azG8pFVMvirbk0r5UPaFLPHzdlEbiIMlPh5+G+iCGH/YTwYnIscLKYQm1Yj lrhRwsYELQDE3bedtjEJH1wgCrKbAkLPNh02lyGCByQgXHDqqiAJ7Dkq6ZX321dK3lN7 yV3oc12puI3Gre/Cd6v7pSUbfqsTrLdVn1AJZpo/pHZG9QQYhEYF/mJMvGtYUXa8UWYk eNfH0GJC6JLBcn/tnATKrBHCVCxRrzNr+mDMsqvq/0FoHgVJIJq/1QBXcaqro0gC41cb 1+7ieSOMYJ4IBMlcjl43/YQUuE1o3dyLBv+4jybflDTmaagOksgAZhtN8Yyxoxi20fHZ 5yMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=DqfFRCqrVOSLRxnsHHHALVeB4MkQYOkvAR6pk7ZJ5hs=; b=XRHkGx6yJPqucH7Ipk8fDMs1kX5wqe7yN8Bqmg2OetaB2gmfeHJNqBOx101DM/JCIz Kl3oeJO7EdwmcqR2DkTJD91MY+Lm6wGkduHyQ6e3eJs/KU0n+CBONu5tXfajValYdxTZ tIA+Ag+z8QKpcob6heqVgH3cZ67F4cpZbBYdYWXDLr2yXKAeyXQ5Qj3Btn1jVJNO9+7p qz9fkho5d17wGdZXynVNP4MusFS0KhddJe2YhOoWeRwR9BIIwoeZYx5qbJR836GCeeTq GsyTSXz8HYakur3ZBtp3bl2OdwbTGD9eeCJGkjeFQ6wbB0gQOH15Nk3elz8AwYLEfiKQ S++A== X-Gm-Message-State: AOAM532TMmChy5w3zAOqVKxoj0lC7GguYWySBVqoDPIeUmnE+5SFmCXS DC9I1AAqEqfXqHCJHGkWCAe+e+dPp7Ut6w== X-Google-Smtp-Source: ABdhPJyY6NwR7VwUAPGkF7wuxxipgggd0W8n+MrvpHT5KMPGQyoetZI8lpo1g5JwTmnid6uTpowDLw== X-Received: by 2002:aa7:868f:0:b029:155:dcd2:7320 with SMTP id d15-20020aa7868f0000b0290155dcd27320mr1017779pfo.53.1603128291742; Mon, 19 Oct 2020 10:24:51 -0700 (PDT) Received: from xps15 (S0106002369de4dac.cg.shawcable.net. [68.147.8.254]) by smtp.gmail.com with ESMTPSA id e10sm131655pjp.26.2020.10.19.10.24.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Oct 2020 10:24:51 -0700 (PDT) Date: Mon, 19 Oct 2020 11:24:49 -0600 From: Mathieu Poirier To: Peng Fan Subject: Re: [PATCH V2 4/7] remoteproc: imx_rproc: use devm_ioremap Message-ID: <20201019172449.GB496175@xps15> References: <20200927064131.24101-1-peng.fan@nxp.com> <20200927064131.24101-5-peng.fan@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200927064131.24101-5-peng.fan@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201019_132454_187385_F96FD686 X-CRM114-Status: GOOD ( 19.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Zhu , festevam@gmail.com, s.hauer@pengutronix.de, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, bjorn.andersson@linaro.org, o.rempel@pengutronix.de, robh+dt@kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Sep 27, 2020 at 02:41:28PM +0800, Peng Fan wrote: > We might need to map an region multiple times, becaue the region might > be shared between remote processors, such i.MX8QM with dual M4 cores. > So use devm_ioremap, not devm_ioremap_resource. > > Reviewed-by: Oleksij Rempel > Reviewed-by: Richard Zhu > Signed-off-by: Peng Fan > --- > drivers/remoteproc/imx_rproc.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c > index aa5fbd0c7768..48ce09e857ee 100644 > --- a/drivers/remoteproc/imx_rproc.c > +++ b/drivers/remoteproc/imx_rproc.c > @@ -298,9 +298,10 @@ static int imx_rproc_addr_init(struct imx_rproc *priv, > if (b >= IMX7D_RPROC_MEM_MAX) > break; > > - priv->mem[b].cpu_addr = devm_ioremap_resource(&pdev->dev, &res); > + /* Not use resource version, because we might share region*/ s/"region*"/"region *" > + priv->mem[b].cpu_addr = devm_ioremap(&pdev->dev, res.start, resource_size(&res)); > if (IS_ERR(priv->mem[b].cpu_addr)) { > - dev_err(dev, "devm_ioremap_resource failed\n"); > + dev_err(dev, "devm_ioremap %pR failed\n", &res); > err = PTR_ERR(priv->mem[b].cpu_addr); > return err; > } > -- > 2.28.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel