From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1602C433E7 for ; Mon, 19 Oct 2020 21:24:04 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0D23822246 for ; Mon, 19 Oct 2020 21:24:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="cuniXa4G" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0D23822246 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=uOQ3FthGc/R0plNXB7ugcikNp5x09S9Qa8l2UIHfrUs=; b=cuniXa4GYs4tlI9+5gOx5veVw Jx+Q3SFrRkImP4ankfvikIK/wC+sVFy+0FtweGJKREcigg1lKhJQaHYTFymQbWKCZs99bpyYO0oAZ 5L5UZ5jmgtQh/mDVfSj9ZAX23nXRkc5+eC6F40O8Qkr3B8zP/hHQ9RBOyG2w/N8TWeXu1MJE0KblR x2hBTOVzPkVdYdJnBWfnp4CycbyhZuEY6b+WeYZA+BwVVYX7oZcdbF0zcCuXbLTxG9XGxaUdb9Q7t hxdlcJm99i5J6ghptzWBsCsaN+mnIUdUmxug/0wLP+cfH/w2RMhQZg2zmhPZMHhjSg0s3xe+lgpNR cx64r6RTg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kUcc0-0000P3-VF; Mon, 19 Oct 2020 21:22:36 +0000 Received: from mail-ot1-f68.google.com ([209.85.210.68]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kUcby-0000OR-HJ for linux-arm-kernel@lists.infradead.org; Mon, 19 Oct 2020 21:22:35 +0000 Received: by mail-ot1-f68.google.com with SMTP id n11so1217175ota.2 for ; Mon, 19 Oct 2020 14:22:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=kb2FOP10/CSY2+K+fOQqeeT9YIluintmnWiaKshoetI=; b=X0S4TlOfhsh/ipNjpfOdxmuyH0HpQ56GG2ddmV+k6AkLpAlMFBgzg5/WJgcwTPRgCq H5jnhWrrTFfQN3ZaOhJCQWwJW1wewCrZ9Gac0Di0LZE44ibstX/f4IFvWf8hsNn8iXqk XvQdN+6Uiec2aqSqljlphVDNfSHatrcl0TDNTHymF3Gj9oQPQQLMyWEqUeATAWxztGuQ jId0UCNHdNSIW7ImIcPUT0+wjlc65gGytRoOIloQ8A5qgCoF62LC2aeYcXVoHmPAk/JO Xpb2w/AXJtnun9vdvzcenYhfhgws8RS0Ctm5VNJsme2rzzsLKEjhzmexBVdAWdkSh7N+ 4QSw== X-Gm-Message-State: AOAM532WbVtVKDXB2HzrBNuU9bWJahDNOeXWNzYUNYq/MRfjtkcmHVcJ b8qPLFtJL+W96A2HqVuUDg== X-Google-Smtp-Source: ABdhPJyIWuzhsUB3Qe9Fh0vC/maeBOYyf2zyXdqtFSd95qu5nrMOWMpgVAvxAWWAnOy1okFxqHYCKA== X-Received: by 2002:a05:6830:1de6:: with SMTP id b6mr1360403otj.37.1603142553829; Mon, 19 Oct 2020 14:22:33 -0700 (PDT) Received: from xps15 (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id k13sm307564ooi.41.2020.10.19.14.22.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Oct 2020 14:22:33 -0700 (PDT) Received: (nullmailer pid 3624234 invoked by uid 1000); Mon, 19 Oct 2020 21:22:32 -0000 Date: Mon, 19 Oct 2020 16:22:32 -0500 From: Rob Herring To: Billy Tsai Subject: Re: [PATCH 3/3] dt-bindings: Change the meaning of clock-frequency Message-ID: <20201019212232.GA3619458@bogus> References: <20201016062602.20014-1-billy_tsai@aspeedtech.com> <20201016062602.20014-4-billy_tsai@aspeedtech.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201016062602.20014-4-billy_tsai@aspeedtech.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201019_172234_586583_B36AD423 X-CRM114-Status: GOOD ( 19.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, jae.hyun.yoo@linux.intel.com, linux-aspeed@lists.ozlabs.org, BMC-SW@aspeedtech.com, andrew@aj.id.au, vernon.mauery@linux.intel.com, joel@jms.id.au, haiyue.wang@linux.intel.com, james.feist@linux.intel.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Oct 16, 2020 at 02:26:02PM +0800, Billy Tsai wrote: > Integration of the usage of msg-timing and addr-timing to clock-frequency. > User can just set it to adjust the peci work efficient. You're breaking the ABI changing this. > > Signed-off-by: Billy Tsai > --- > .../devicetree/bindings/peci/peci-aspeed.yaml | 56 +++++++++---------- > 1 file changed, 28 insertions(+), 28 deletions(-) > > diff --git a/Documentation/devicetree/bindings/peci/peci-aspeed.yaml b/Documentation/devicetree/bindings/peci/peci-aspeed.yaml > index 0f5c2993fe9b..7c6c895784af 100644 > --- a/Documentation/devicetree/bindings/peci/peci-aspeed.yaml > +++ b/Documentation/devicetree/bindings/peci/peci-aspeed.yaml > @@ -40,31 +40,33 @@ properties: > maxItems: 1 > > clock-frequency: > - # Operation frequency of PECI controller in units of Hz. > - minimum: 187500 > - maximum: 24000000 > - > - msg-timing: > - description: | > - Message timing negotiation period. This value will determine the period > - of message timing negotiation to be issued by PECI controller. The unit > - of the programmed value is four times of PECI clock period. > - allOf: > - - $ref: /schemas/types.yaml#/definitions/uint32 > - - minimum: 0 > - maximum: 255 > - default: 1 > - > - addr-timing: > - description: | > - Address timing negotiation period. This value will determine the period > - of address timing negotiation to be issued by PECI controller. The unit > - of the programmed value is four times of PECI clock period. > - allOf: > - - $ref: /schemas/types.yaml#/definitions/uint32 > - - minimum: 0 > - maximum: 255 > - default: 1 > + # The bit frequency of PECI negotiation stage in units of Hz. > + # Driver will calculate the best divisor setting of msg-timing and > + # addr-timing to meet the value. Use 'description' rather than comments. > + minimum: 2000 > + maximum: 2000000 > + > + # msg-timing: > + # description: | > + # Message timing negotiation period. This value will determine the period > + # of message timing negotiation to be issued by PECI controller. The unit > + # of the programmed value is four times of PECI clock period. > + # allOf: > + # - $ref: /schemas/types.yaml#/definitions/uint32 > + # - minimum: 0 > + # maximum: 255 > + # default: 1 Why is this commented out? > + > + # addr-timing: > + # description: | > + # Address timing negotiation period. This value will determine the period > + # of address timing negotiation to be issued by PECI controller. The unit > + # of the programmed value is four times of PECI clock period. > + # allOf: > + # - $ref: /schemas/types.yaml#/definitions/uint32 > + # - minimum: 0 > + # maximum: 255 > + # default: 1 > > rd-sampling-point: > description: | > @@ -114,9 +116,7 @@ examples: > interrupts = ; > clocks = <&syscon ASPEED_CLK_GATE_REF0CLK>; > resets = <&syscon ASPEED_RESET_PECI>; > - clock-frequency = <24000000>; > - msg-timing = <1>; > - addr-timing = <1>; > + clock-frequency = <2000000>; > rd-sampling-point = <8>; > cmd-timeout-ms = <1000>; > }; > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel