From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E7F1C433E7 for ; Tue, 20 Oct 2020 09:53:37 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D17AE22242 for ; Tue, 20 Oct 2020 09:53:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="taxu02QK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D17AE22242 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=cf/w4m9fzl6oI8RvuFhEDEe46Bl+Xt0mPnh3G2YEEYE=; b=taxu02QKoed7qNY4GTupBsrhX IxafAe1zoob0VffV7iRhB+ytGNwnrsA7hpnVLk85pR52NM6aKcsYEwFP5/CbneMquphkqL9+y05N5 +NvxQjFzHEMwDPg/YlTQ3YiqkuZEsQUt/23GuZfuOVBO7uiSx8Mb5rUfSrzGsZZ/LN6rSjgp85m3Y TGoRV4RO4gN8RrgIxdWutK6p9DU9yLt2mQ4eJYlW3HZi4F/oYZSA2ugDG6/sIhFK2OHDBOsvCy6Le ppDTTaS4bbRMWLB1j1DTijOwBgn3jEK8TyTA4+fehHQj2Evzn4wMVvBRToW+jRck38IDecFJt5xWK SK9xoiqcA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kUoJU-0003jl-Fn; Tue, 20 Oct 2020 09:52:16 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kUoJR-0003j8-Cf for linux-arm-kernel@lists.infradead.org; Tue, 20 Oct 2020 09:52:14 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 47554101E; Tue, 20 Oct 2020 02:52:11 -0700 (PDT) Received: from bogus (unknown [10.57.22.167]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3AB383F66E; Tue, 20 Oct 2020 02:52:08 -0700 (PDT) Date: Tue, 20 Oct 2020 10:52:05 +0100 From: Sudeep Holla To: Viresh Kumar Subject: Re: [PATCH V2 1/2] opp: Allow dev_pm_opp_get_opp_table() to return -EPROBE_DEFER Message-ID: <20201020095205.GB10604@bogus> References: <20201019045827.kl6qnx6gidhzjkrs@vireshk-i7> <20201019091723.GA12087@bogus> <20201019092411.b3znjxebay3puq2j@vireshk-i7> <20201019101241.GB12908@bogus> <20201019103535.ksp5ackoihamam4g@vireshk-i7> <20201019141007.GA6358@bogus> <20201020050557.a3b2nk33eeyxnvl2@vireshk-i7> <20201020055431.ln7d57x76f7z6j5k@vireshk-i7> <20201020093745.GA10604@bogus> <20201020094134.natqnyp4zpfw3p5p@vireshk-i7> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201020094134.natqnyp4zpfw3p5p@vireshk-i7> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201020_055213_517407_2F0613C6 X-CRM114-Status: GOOD ( 25.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nishanth Menon , Len Brown , ulf.hansson@linaro.org, linux-samsung-soc@vger.kernel.org, Vincent Guittot , Stephan Gerhold , Kevin Hilman , Stephen Boyd , Greg Kroah-Hartman , linux-pm@vger.kernel.org, "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , nks@flawful.org, Kukjin Kim , Pavel Machek , Sudeep Holla , georgi.djakov@linaro.org, linux-arm-kernel@lists.infradead.org, Viresh Kumar Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Oct 20, 2020 at 03:11:34PM +0530, Viresh Kumar wrote: > On 20-10-20, 10:37, Sudeep Holla wrote: > > On Tue, Oct 20, 2020 at 11:24:32AM +0530, Viresh Kumar wrote: > > > On 20-10-20, 10:35, Viresh Kumar wrote: > > > > On 19-10-20, 15:10, Sudeep Holla wrote: > > > > > On Mon, Oct 19, 2020 at 04:05:35PM +0530, Viresh Kumar wrote: > > > > > > On 19-10-20, 11:12, Sudeep Holla wrote: > > > > > > > Yes it has clocks property but used by SCMI(for CPUFreq/DevFreq) and not > > > > > > > by any clock provider driver. E.g. the issue you will see if "clocks" > > > > > > > property is used instead of "qcom,freq-domain" on Qcom parts. > > > > > > > > > > > > Okay, I understand. But what I still don't understand is why it fails > > > > > > for you. You have a clocks property in DT for the CPU, the OPP core > > > > > > tries to get it and will get deferred-probed, which will try probing > > > > > > at a later point of time and it shall work then. Isn't it ? > > > > > > > > > > > > > > > > Nope unfortunately. We don't have clock provider, so clk_get will > > > > > never succeed and always return -EPROBE_DEFER. > > > > > > > > Now this is really bad, you have a fake clocks property, how is the > > > > OPP core supposed to know it ? Damn. > > > > > > What about instead of fixing the OPP core, which really is doing the > > > right thing, we fix your driver (as you can't fix the DT) and add a > > > dummy CPU clk to make it all work ? > > > > > > > I really would avoid that. I would rather change the binding as there is > > no single official users of that binding in the upstream tree. > > But how will you solve backward compatibility thing then ? > I am just betting on the fact that no users upstream means no backward compatibility needed. If someone raises issue we need to add backward compatibility with dummy clk as you suggested. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel