From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74175C433DF for ; Tue, 20 Oct 2020 10:01:08 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EB49D22253 for ; Tue, 20 Oct 2020 10:01:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lHS9+Qul"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="CBFdSEfJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EB49D22253 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=YGYzMJX7Usb+0Z0IwZI2MBboRv24GnNAe0ZgkPD3Xes=; b=lHS9+QulB6nxaNktj3Fh47B6k Ya9L8Wl53Os0iF6/Ona8nLEeh7TrcedpiCm+yVEXiTh0becpz10wR+2HYgrJcN3EcaT/HAQRH5Nav ljrTl6NNzATCHzFRMF1hjNVASIHH/o+sMZfCid7+9Oj6sWC04caMgJlj8dC+qsqSN4HPWGNdBuuGW zXv9PwX7jZ9S1LDtVmvkPe9SF7krmFYRZcs+VJsELKOsAMSE2DtYv1NT1AbCA1LqR+ZSwOsfR4YjR x37XhuWXWEpNB2xsjXCS7/veZ3s116BBwc57y4hPTDUQGXGq1hEql2M3NWSyzfUToVmBtT84kG6lP /mLIMY6Gg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kUoQj-0005KF-3N; Tue, 20 Oct 2020 09:59:45 +0000 Received: from mail-pg1-x542.google.com ([2607:f8b0:4864:20::542]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kUoQf-0005Iv-Uc for linux-arm-kernel@lists.infradead.org; Tue, 20 Oct 2020 09:59:43 +0000 Received: by mail-pg1-x542.google.com with SMTP id n9so765076pgt.8 for ; Tue, 20 Oct 2020 02:59:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=NENYQ/eLjN+kod9n/Z7W2983/x5NgkU6/c+e1AeVxFs=; b=CBFdSEfJP5VkIIITqJlKx4yDwQWRMUByg7hRU3V6oQnIZFayB9saU8yPWEeqqVarA7 Svg2TyX6boRcM9lNiOQmUR3MO1lysPy/JwSRhGTjgy1mfseoHM4waskxFWVxxpvq0mrC e0fXiVkRLhvyOqzBfor+B/yYUYjPMbMA+bwuOSgWaND1nQFCUqfql7XI6pSu/WraFedX 4TXma4aAGudK6Nl0lri5gQdkFxVAo50aktjFPDcshE1wvhdweeWbi56L+t23seEjF1Nq YnlOmDc+LlD590ZPWEnWPd0zlSJ82h4gzkhJq0YZHy1+J+vCnic325VPjAahqqPkYKTV uKZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=NENYQ/eLjN+kod9n/Z7W2983/x5NgkU6/c+e1AeVxFs=; b=c+DUzcGUd6O/Q1hq88kvTX2zqOKdaAkjKIZhdeWAB6MLVbNglC3BkRzcBE561IHi4X 6UIYM7OPnW7zW/JwzBgQx5vPRBC7vAnYAaOpvkLqRjaWK+6/QEunC5oHwsbVsqSdIfEx 1Y6RIG0e63olYeFO/wHe0kMQuo+9nzTp+cjFt6EhhMUmcDPjW4QYC+xK3H/fmj0mVBQE obL26yt+RVbVy7nlsb7ZXLB3w1mnNudMt/Y8sbyGiqvcGqhWq5dMvP/vjkciNMELx9dw giCsHi21tO4aTKJkTJAd2K6UzZEMAfMHORxwxL3zwCkwqIBBEqfBKfEHavJlXopODPaB gOag== X-Gm-Message-State: AOAM532O2hximjbMH4ED4YzsoywcGoZRwP/MLUaL8AJtgliyFSsyifNL nPpSNRJTV/nxaVR+gnQln2YwGQ== X-Google-Smtp-Source: ABdhPJxzVYB15h5YaGeEL9se/fR4WCYPH/ZQqp3XJb26uBr6gmCf2vPkZ3wlfY2tWdVPgvsG2FFQfQ== X-Received: by 2002:a63:ea0b:: with SMTP id c11mr2013473pgi.213.1603187978786; Tue, 20 Oct 2020 02:59:38 -0700 (PDT) Received: from localhost ([122.181.54.133]) by smtp.gmail.com with ESMTPSA id m3sm1407008pjv.52.2020.10.20.02.59.37 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 Oct 2020 02:59:37 -0700 (PDT) Date: Tue, 20 Oct 2020 15:29:35 +0530 From: Viresh Kumar To: Sudeep Holla Subject: Re: [PATCH V2 1/2] opp: Allow dev_pm_opp_get_opp_table() to return -EPROBE_DEFER Message-ID: <20201020095935.2ttoked5tozvcr24@vireshk-i7> References: <20201019091723.GA12087@bogus> <20201019092411.b3znjxebay3puq2j@vireshk-i7> <20201019101241.GB12908@bogus> <20201019103535.ksp5ackoihamam4g@vireshk-i7> <20201019141007.GA6358@bogus> <20201020050557.a3b2nk33eeyxnvl2@vireshk-i7> <20201020055431.ln7d57x76f7z6j5k@vireshk-i7> <20201020093745.GA10604@bogus> <20201020094134.natqnyp4zpfw3p5p@vireshk-i7> <20201020095205.GB10604@bogus> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201020095205.GB10604@bogus> User-Agent: NeoMutt/20180716-391-311a52 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201020_055941_990723_EEA5AFA2 X-CRM114-Status: GOOD ( 29.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nishanth Menon , Len Brown , ulf.hansson@linaro.org, linux-samsung-soc@vger.kernel.org, Vincent Guittot , Stephan Gerhold , Kevin Hilman , Stephen Boyd , Greg Kroah-Hartman , linux-pm@vger.kernel.org, "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , nks@flawful.org, Kukjin Kim , Pavel Machek , Viresh Kumar , georgi.djakov@linaro.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 20-10-20, 10:52, Sudeep Holla wrote: > On Tue, Oct 20, 2020 at 03:11:34PM +0530, Viresh Kumar wrote: > > On 20-10-20, 10:37, Sudeep Holla wrote: > > > On Tue, Oct 20, 2020 at 11:24:32AM +0530, Viresh Kumar wrote: > > > > On 20-10-20, 10:35, Viresh Kumar wrote: > > > > > On 19-10-20, 15:10, Sudeep Holla wrote: > > > > > > On Mon, Oct 19, 2020 at 04:05:35PM +0530, Viresh Kumar wrote: > > > > > > > On 19-10-20, 11:12, Sudeep Holla wrote: > > > > > > > > Yes it has clocks property but used by SCMI(for CPUFreq/DevFreq) and not > > > > > > > > by any clock provider driver. E.g. the issue you will see if "clocks" > > > > > > > > property is used instead of "qcom,freq-domain" on Qcom parts. > > > > > > > > > > > > > > Okay, I understand. But what I still don't understand is why it fails > > > > > > > for you. You have a clocks property in DT for the CPU, the OPP core > > > > > > > tries to get it and will get deferred-probed, which will try probing > > > > > > > at a later point of time and it shall work then. Isn't it ? > > > > > > > > > > > > > > > > > > > Nope unfortunately. We don't have clock provider, so clk_get will > > > > > > never succeed and always return -EPROBE_DEFER. > > > > > > > > > > Now this is really bad, you have a fake clocks property, how is the > > > > > OPP core supposed to know it ? Damn. > > > > > > > > What about instead of fixing the OPP core, which really is doing the > > > > right thing, we fix your driver (as you can't fix the DT) and add a > > > > dummy CPU clk to make it all work ? > > > > > > > > > > I really would avoid that. I would rather change the binding as there is > > > no single official users of that binding in the upstream tree. > > > > But how will you solve backward compatibility thing then ? > > > > I am just betting on the fact that no users upstream means no backward > compatibility needed. If someone raises issue we need to add backward > compatibility with dummy clk as you suggested. Okay. I would have done a change in the OPP core to fix the issue, but the current code looks correct and we shouldn't change it to satisfy buggy users. I hope that makes sense. -- viresh _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel