From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F260C433E7 for ; Tue, 20 Oct 2020 10:40:27 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D700422283 for ; Tue, 20 Oct 2020 10:40:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WYYbI/b3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D700422283 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1HiMiIBFGjs6VtnazTA1NMVeKgNY49M2/6EEKRH1Tbg=; b=WYYbI/b3CYkAozV/8I/RYEbTV SMhyaLKY6yG7FgJffgRBT7xyqJZOeuuuN+DDKPHckLUOLqb0G1W8LCtdPxNOVho00JT4WW8ybsbQo OR8XgUfOVBU1r9ci5UTFdAatd8Hg2v8OSRILIY46mP3hWDLdi/71s6kbgQ88fl/lBIgnixlyllkqn uqwB+uyHlGulE0w+TLmGHlPki3k10E+H0RL+dHoWqKqttyWpjA4Jq5GDzYic4iAyGzj01X1I7XYlU IaHY4zIBYhiC9KrRwxIjY7EDOLR1C75F++HwJRjHgcYOmKe/ZbjxwpArkyrJUhqFIH8Ef7XjCXNXI 7Ny6FstkA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kUp2W-0002Q5-RQ; Tue, 20 Oct 2020 10:38:48 +0000 Received: from mga05.intel.com ([192.55.52.43]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kUp2T-0002PH-VP for linux-arm-kernel@lists.infradead.org; Tue, 20 Oct 2020 10:38:46 +0000 IronPort-SDR: 5ae9dbDCmglOGrzmkCZqw84UvbZ1Hjc3g/HBqVMl7AllgDmYyHlpUhanl3ISqUGvst3Z866Ipc Ed6ZFueET/0w== X-IronPort-AV: E=McAfee;i="6000,8403,9779"; a="251882298" X-IronPort-AV: E=Sophos;i="5.77,396,1596524400"; d="scan'208";a="251882298" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Oct 2020 03:38:38 -0700 IronPort-SDR: nMQbRZD4Q4/nC6JYt/ZopTnm264ux7lyhK+5oY2af1Ds8fse9tbcxwsczWMFHkSn0yqCMeLNw8 +ibolxJIUZcA== X-IronPort-AV: E=Sophos;i="5.77,396,1596524400"; d="scan'208";a="347815287" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Oct 2020 03:38:35 -0700 Received: by paasikivi.fi.intel.com (Postfix, from userid 1000) id 307A12062D; Tue, 20 Oct 2020 13:38:33 +0300 (EEST) Date: Tue, 20 Oct 2020 13:38:33 +0300 From: Sakari Ailus To: Krzysztof Kozlowski Subject: Re: [PATCH v5 1/4] dt-bindings: media: imx258: add bindings for IMX258 sensor Message-ID: <20201020103833.GT13341@paasikivi.fi.intel.com> References: <20201019170247.92002-1-krzk@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201019170247.92002-1-krzk@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201020_063846_158325_0660D7F4 X-CRM114-Status: GOOD ( 19.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Rob Herring , Stephen Boyd , Shawn Guo , Sascha Hauer , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, Rob Herring , NXP Linux Team , Pengutronix Kernel Team , Mauro Carvalho Chehab , Fabio Estevam , Michael Turquette , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Krzysztof, On Mon, Oct 19, 2020 at 07:02:44PM +0200, Krzysztof Kozlowski wrote: > Add bindings for the IMX258 camera sensor. The bindings, just like the > driver, are quite limited, e.g. do not support regulator supplies. > > Signed-off-by: Krzysztof Kozlowski > Reviewed-by: Rob Herring > > --- > > Changes since v4: > 1. Add clock-lanes, > 2. Add Rob's review, > 3. Add one more example and extend existing one, > 4. Add common clock properties (assigned-*). Using the assigned-* clock properties may be workable for this driver at the moment. But using these properties does not guarantee the external clock frequency intended to be used on the hardware. Using other frequencies *is not* expected to work. That applies to this driver as well. This, instead of the clock-frequency property, effectively removes the ability to set the correct frequency from the driver, at least with current set of the used APIs. I suppose you could add a function to set the assigned clock frequency and keep it, just as clk_set_rate_exclusive does? Cc the common clock framework list + maintainers. -- Regards, Sakari Ailus _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel