From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AAE3C433E7 for ; Tue, 20 Oct 2020 12:49:02 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AFE5B22242 for ; Tue, 20 Oct 2020 12:49:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="w6V/ac1D" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AFE5B22242 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tDIklGigcUaZ6QZYac+vZAS5XxGDbfsS81pFrmjCNvE=; b=w6V/ac1DkBByTPP+lpj9JjqwA Ityr20Xaet223lGVxieWeXB3p8CVE3rkvxXRM5yNDfVLr2dmGrKoaVh2BEyWDPWoqa23FVCk5ws4Q DDUjxLa0PeVXgsobcINac02XZjA0KM7sA0srUJhAIu8qCd0foAOM+cHHIuH0Yvoz59O3W0sztMlpn G2HZK4ukVJvAzcFMMwJ4JC428AA2TN9UHS4XDISVmUCpbR1XKeRO8wUhPyFZEID0qW8A9uNHfTJdt WLHuxKLACbyX66pYAeY7Hak08mZcBvSCj/AD5hRoU5YJj8ijk55KCRGL2qCieoKkj6VvTQU6d7qHk 54+hL5/aQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kUr32-0004fY-QY; Tue, 20 Oct 2020 12:47:28 +0000 Received: from mga02.intel.com ([134.134.136.20]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kUr2d-0004UJ-Pm for linux-arm-kernel@lists.infradead.org; Tue, 20 Oct 2020 12:47:08 +0000 IronPort-SDR: L6WF+0B2ub9ev6d3bVJ2phAQ314GzXE/CVHQ8X64DnH4LQ/Q/kuQJGklv5ubnpaT/Z26ZbdCbG 8UqvPrtF/b1Q== X-IronPort-AV: E=McAfee;i="6000,8403,9779"; a="154142653" X-IronPort-AV: E=Sophos;i="5.77,397,1596524400"; d="scan'208";a="154142653" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Oct 2020 05:47:00 -0700 IronPort-SDR: nNSm2JVctSzKdcN0Bx3T1hXrWB06XwSKxLzAWM0LkIEAaiTvVv7OhYcAwVvK5H1LlBuxr+b/7B NRyoCDTczOxg== X-IronPort-AV: E=Sophos;i="5.77,397,1596524400"; d="scan'208";a="522367367" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Oct 2020 05:46:56 -0700 Received: by paasikivi.fi.intel.com (Postfix, from userid 1000) id E28062062D; Tue, 20 Oct 2020 15:46:54 +0300 (EEST) Date: Tue, 20 Oct 2020 15:46:54 +0300 From: Sakari Ailus To: Krzysztof Kozlowski Subject: Re: [PATCH v5 1/4] dt-bindings: media: imx258: add bindings for IMX258 sensor Message-ID: <20201020124654.GX13341@paasikivi.fi.intel.com> References: <20201019170247.92002-1-krzk@kernel.org> <20201020103833.GT13341@paasikivi.fi.intel.com> <20201020120058.GU13341@paasikivi.fi.intel.com> <20201020122621.GA126891@kozik-lap> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201020122621.GA126891@kozik-lap> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201020_084704_044787_03509415 X-CRM114-Status: GOOD ( 42.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Rob Herring , Stephen Boyd , Shawn Guo , Sascha Hauer , "linux-kernel@vger.kernel.org" , linux-clk@vger.kernel.org, Rob Herring , NXP Linux Team , Pengutronix Kernel Team , Mauro Carvalho Chehab , Fabio Estevam , Michael Turquette , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Oct 20, 2020 at 02:26:21PM +0200, Krzysztof Kozlowski wrote: > On Tue, Oct 20, 2020 at 03:00:58PM +0300, Sakari Ailus wrote: > > Hi Krzysztof, > > > > On Tue, Oct 20, 2020 at 12:54:09PM +0200, Krzysztof Kozlowski wrote: > > > On Tue, 20 Oct 2020 at 12:38, Sakari Ailus wrote: > > > > > > > > Hi Krzysztof, > > > > > > > > On Mon, Oct 19, 2020 at 07:02:44PM +0200, Krzysztof Kozlowski wrote: > > > > > Add bindings for the IMX258 camera sensor. The bindings, just like the > > > > > driver, are quite limited, e.g. do not support regulator supplies. > > > > > > > > > > Signed-off-by: Krzysztof Kozlowski > > > > > Reviewed-by: Rob Herring > > > > > > > > > > --- > > > > > > > > > > Changes since v4: > > > > > 1. Add clock-lanes, > > > > > 2. Add Rob's review, > > > > > 3. Add one more example and extend existing one, > > > > > 4. Add common clock properties (assigned-*). > > > > > > > > Using the assigned-* clock properties may be workable for this driver at > > > > the moment. But using these properties does not guarantee the external > > > > clock frequency intended to be used on the hardware. > > > > > > It guarantees it. The clock frequency will be as expected (except if > > > someone misconfigures the DTS). > > > > Is that guaranteed? > > > > I'm not saying no to the approach, but if we change how camera sensor DT > > bindings are defined, I'd prefer an informed decision is made on the > > matter. > > > > > > > > > Using other > > > > frequencies *is not* expected to work. That applies to this driver as well. > > > > > > This is the binding which is HW description. According to HW datasheet > > > other frequencies from described range are accepted and expected to > > > work. > > > > As per datasheet, yes, different external clock frequencies can be used. > > But the link frequency is still not independent of the external clock > > frequency. > > > > The properties of the sensor's PLL tree determines what can be achieved > > given a certain external clock frequency. So picking a wrong external clock > > frequency quite possibly means that none of the designated link frequencies > > are available, rendering the sensor inoperable. > > The driver then controls the HW and knows exactly what is needed. If > link frequency (which has its own DT property) requires some clock > frequency, the driver will configure the clock to that value. The same Well it doesn't if it doesn't get that information from DT. The frequency is usually a range, and looking at these bindings, it's from 6 MHz to 27 MHz. That'd be a lot of frequencies for a driver to try. > going other direction. Driver has the knowledge about both its input > clock and link frequency, therefore it can make the best decision. Again you're assuming a particular driver implementation. Typically only a few frequencies are really available on platforms, so a in practice a driver would not be able to get any requested frequency. I wouldn't start hard-coding every possible frequency to camera sensor drivers. > > > > This, instead of the clock-frequency property, effectively removes the > > > > ability to set the correct frequency from the driver, at least with current > > > > set of the used APIs. > > > > > > It seems you confuse DT bindings with some specific driver > > > implementation. Bindings do not describe the driver behavior but the > > > HW. The ability to set the correct frequency from the driver is not > > > removed. It was never part of the bindings and never should. It is > > > part of the driver. > > > > > > > > > > > I suppose you could add a function to set the assigned clock frequency and > > > > keep it, just as clk_set_rate_exclusive does? > > I did not reply to this comment, so let me know. Of course, one could > add such functions. It's not a job for DT bindings, though. I'm not suggesting to add it to DT binding patch. What I'm saying that with this approach is looks like it may well be needed. -- Regards, Sakari Ailus _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel