From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4C1BC4363A for ; Wed, 21 Oct 2020 11:27:37 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3973921741 for ; Wed, 21 Oct 2020 11:27:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="kBz3uuqG"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="hcl5x8aa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3973921741 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JXRI3z/nTC+qXJsMVxCkSruTuOPGl9H4hZgjXMYDroU=; b=kBz3uuqG9hhlxiGQ2JitOryhQ yj7zQKvOfawGgNtyJsdasdUNEA32WB+OMMDIUdr1jX8e0I5+XbzNqeXSDO3/9e3kQO6AZNCgi4kJO PpYkMQ6LB277YMSzwABE/s/8tQaWcWnKBxUtPVXSRzWdZl3Q8ZmU9w/iCJYqu9dfmFxs1XTalFd3l lzOSNEfODSEXmFxzRig8RhuVj1GK8CGGrtxMc4dd4Ns2ohW4Djzt9qJ3b1qpn/iTnuBz3J9XrJz1A GvKvE5V+4bu/bu3z3enqOuKs6BE6u1cRJbNzm9TFwJY6mmRTjGXSawjnPPgyDZPAtcTCv4u+DNWD8 mMWE4+OYg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kVCG5-00043L-19; Wed, 21 Oct 2020 11:26:21 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kVCG1-00042A-Rx for linux-arm-kernel@lists.infradead.org; Wed, 21 Oct 2020 11:26:19 +0000 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2BE1C21741; Wed, 21 Oct 2020 11:26:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603279576; bh=VXtH8gX2MQuBeBFSIfYu/3zWvbmK40hrN2v57eUoa8A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hcl5x8aaA3tCxlJNW7prkjkUgiZXeSY4LpWNXZY5f/h6bLH4cW8dlqW61aZwME7kh dHyNMxBLE3iXuo+DkwczVXSTWI9y8IfyPutP511lduH4gk/xUWw5N8/9g47c1oScuj LXCRIavplSAugm82IANJDNBwhcJm/3JuNv8SwnSM= Date: Wed, 21 Oct 2020 13:26:56 +0200 From: Greg Kroah-Hartman To: Qais Yousef Subject: Re: [RFC PATCH v2 0/4] Add support for Asymmetric AArch32 systems Message-ID: <20201021112656.GB1141598@kroah.com> References: <20201021104611.2744565-1-qais.yousef@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201021104611.2744565-1-qais.yousef@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201021_072618_049680_8F6CBD37 X-CRM114-Status: GOOD ( 20.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, Will Deacon , "Peter Zijlstra \(Intel\)" , Catalin Marinas , James Morse , Marc Zyngier , Linus Torvalds , Morten Rasmussen , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Oct 21, 2020 at 11:46:07AM +0100, Qais Yousef wrote: > This series adds basic support for Asymmetric AArch32 systems. Full rationale > is in v1's cover letter. > > https://lore.kernel.org/linux-arch/20201008181641.32767-1-qais.yousef@arm.com/ That is not good, provide full rational in each place, not everyone has web access at all time. Also, you forgot to document this in Documentation/ABI/ like is required for sysfs files, and I thought I asked for last time. > Changes in v2: > > * We now reset vcpu->arch.target to force re-initialized for KVM patch. > (Marc) > > * Fix a bug where this_cpu_has_cap() must be called with preemption > disabled in check_aarch32_cpumask(). > > * Add new sysctl.enable_asym_32bit. (Catalin) > > * Export id_aar64fpr0 register in sysfs which allows user space to > discover which cpus support 32bit@EL0. The sysctl must be enabled for > the user space to discover the asymmetry. (Will/Catalin) > > * Fixing up affinity in the kernel approach was dropped. The support > assumes the user space that wants to enable this support knows how to > guarantee correct affinities for 32bit apps by using cpusets. I asked you to work with Intel to come up with an agreement of how this is going to be represented in userspace. Why did you not do that? Without even looking at the patch set, this is not ok... greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel