From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E0AFC388F9 for ; Wed, 21 Oct 2020 13:02:31 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1C05122249 for ; Wed, 21 Oct 2020 13:02:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="pHMZokDr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1C05122249 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mUt1AIwd7HJRxHXKywjHkV9muX0NgD2Mn6n04QEKZms=; b=pHMZokDrNebaNwbqTCCS87Ysw HlCs7mv2BhzB3kusV/sRLryeWNE9T9QZyZfd5ObtNIVhVzi27r/kpJ0ZZtFVzJTqjvpaz9cM7+28A RqZ2w6s2GPfKFVewrFDCCl5nxH5HDDk8PVt+kHlaO+1K3OamtGZIC5ygUTQT+ffiOxkzCxhbGuRt4 q7Rn/B7q0FDM4baMfvTX6yGezhzPSImOEJQ6/hH9CJNGWdpTbcDKYsPNVhhJCoOdJqpQayCIkXXvj MNfm9jV/gFzXet3ohkwmyV1wZx91AVcyHycdkLhXAv+UmSbONz/7Rpb32XcLcNDBCoA8Lm1JfQXdW moYDIxYXw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kVDjj-00027H-UI; Wed, 21 Oct 2020 13:01:03 +0000 Received: from mga14.intel.com ([192.55.52.115]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kVDjh-00026M-6Z for linux-arm-kernel@lists.infradead.org; Wed, 21 Oct 2020 13:01:02 +0000 IronPort-SDR: G3frLODMOcxyQcq2+OhGFtHa1P2KB7QUar1j4z/f/M+X0eUWBDTGSX4XP0e0ZGiiiuW87yhaF/ n/GWNmrxskuw== X-IronPort-AV: E=McAfee;i="6000,8403,9780"; a="166584723" X-IronPort-AV: E=Sophos;i="5.77,401,1596524400"; d="scan'208";a="166584723" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Oct 2020 06:00:58 -0700 IronPort-SDR: lM5wSd6+wT4tggVCLwdGbIPibdst4g5SbujPDO31XcaiYsSmH6OSi9IHSmujusMtC9jZyu4c8a HvaYv53wmvcQ== X-IronPort-AV: E=Sophos;i="5.77,401,1596524400"; d="scan'208";a="522735609" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Oct 2020 06:00:55 -0700 Received: by paasikivi.fi.intel.com (Postfix, from userid 1000) id 4CB9020815; Wed, 21 Oct 2020 16:00:33 +0300 (EEST) Date: Wed, 21 Oct 2020 16:00:33 +0300 From: Sakari Ailus To: Hugues Fruchet Subject: Re: [PATCH v4 2/2] media: dt-bindings: media: st,stm32-dcmi: Add support of BT656 Message-ID: <20201021130033.GI2703@paasikivi.fi.intel.com> References: <1603188889-23664-1-git-send-email-hugues.fruchet@st.com> <1603188889-23664-3-git-send-email-hugues.fruchet@st.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1603188889-23664-3-git-send-email-hugues.fruchet@st.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201021_090101_397036_328C404E X-CRM114-Status: GOOD ( 21.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Alexandre Torgue , linux-kernel@vger.kernel.org, Philippe CORNU , Hans Verkuil , Alain Volmat , Rob Herring , Yannick Fertre , Mauro Carvalho Chehab , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Hugues, On Tue, Oct 20, 2020 at 12:14:49PM +0200, Hugues Fruchet wrote: > Add support of BT656 parallel bus mode in DCMI. > This mode is enabled when hsync-active & vsync-active > fields are not specified. > > Signed-off-by: Hugues Fruchet > --- > .../devicetree/bindings/media/st,stm32-dcmi.yaml | 30 ++++++++++++++++++++++ > 1 file changed, 30 insertions(+) > > diff --git a/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml b/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml > index 3fe778c..1ee521a 100644 > --- a/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml > +++ b/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml > @@ -44,6 +44,36 @@ properties: > bindings defined in > Documentation/devicetree/bindings/media/video-interfaces.txt. > > + properties: > + endpoint: > + type: object > + > + properties: > + bus-width: true > + > + hsync-active: > + description: > + If both HSYNC and VSYNC polarities are not specified, BT656 > + embedded synchronization is selected. > + default: 0 > + > + vsync-active: > + description: > + If both HSYNC and VSYNC polarities are not specified, BT656 > + embedded synchronization is selected. > + default: 0 Should I understand this as if the polarities were not specified, BT.656 will be used? The bindings previously documented BT.601 (parallel) only, so it was somewhat ambigious to begin with. Is there a risk of interpreting old BT.601 bindings as BT.656? With bus-type property, I believe you could avoid at least that risk. Also not specifying at least one of the default values leads to BT.656 without bus-type. That could be addressed by removing the defaults. > + > + pclk-sample: true > + > + remote-endpoint: true > + > + required: > + - remote-endpoint > + > + additionalProperties: false > + > + additionalProperties: false > + > required: > - compatible > - reg -- Regards, Sakari Ailus _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel