From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E3BFC388F9 for ; Wed, 21 Oct 2020 13:26:12 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C3AF8221FC for ; Wed, 21 Oct 2020 13:26:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qym12uw/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C3AF8221FC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qQqxwYPE7a6FGETXDIF7RDw6xcybWpLdws4AjVi8cew=; b=qym12uw/VRh0zdWRgJMhtgZrT ploh1tmLsoeast8fRhQh/RxebP4MvmJ4AAwKxXl7DtjsWe5T4MRmJ9qylyFylCLdmvYKu6rF8NuoO I38TMwwbPyJLntsED1u8Xo+k5zPvhXqol7nw9/2CEzfO39T2lOgakzKAK9uy7WzLft0BBT8hJ9kk9 hy9VqItVQRmhemRL5zqDEFI7QbQjwpC9NloL9XnzFvMXnt+kpVYtjd6Cxv1kZzeIfx4XWkGajtvzU BPU1plhVHSgpWQudHtzfGRdIRVZiQFbpmef1kD8p9/y0y1udLICW7l/DZTtKQjd2Z4nHWTaEBspXT HSWY1jWbg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kVE6j-0005mo-0R; Wed, 21 Oct 2020 13:24:49 +0000 Received: from mail-ej1-f68.google.com ([209.85.218.68]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kVE6g-0005lO-23 for linux-arm-kernel@lists.infradead.org; Wed, 21 Oct 2020 13:24:47 +0000 Received: by mail-ej1-f68.google.com with SMTP id o26so3201976ejc.8 for ; Wed, 21 Oct 2020 06:24:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=sgvb0QermxEsfEaijdapUaWIAXlaPvAunzMG259XAK4=; b=i9SkGHiryumDTXsNsb9EQGVTNar/fnQZ3aHDmuYTdA7dX/oEmjOLU4oE+etsTJJbBE APrhttMIQVdjorBEwNNsHAPO4ml7WDfhQv9s3QinUiPsy1Cyj3a/OS1XOdJ94MgIRyse qHQaDh/dqbXAz7sZIxAiwkg1KstblPdx5rmCJKNVW7H+JZAZ2TlCOg5qRUAwhuSfZ0zb NptgjfdSnhW4J0VHKMmLVUtWoBXY1wqsU1kGOEaNstYDjet1zLjVSc7A3DsUG7Fbd5/d VxXC54W4rkd9yAKg4wbUKSL0/rjug7Ym1VupBdZ0BU8vxXnRb7Dr+WQ2g241SDm3ql73 k6ig== X-Gm-Message-State: AOAM533DLHVoLlwmUfJvaGDAHcifswt1edpGMRfUS/BQMltduVND0zPp /1ixQeNNZzBx9R2TTskEHz4= X-Google-Smtp-Source: ABdhPJzZ0VS+w0Io2P+whf5pAsfzwgyVyr3Ys/5PCfxFI7R+o6xgd8FZrEL10EVZyI4zajpMcZjVWw== X-Received: by 2002:a17:906:360b:: with SMTP id q11mr3635507ejb.259.1603286681576; Wed, 21 Oct 2020 06:24:41 -0700 (PDT) Received: from kozik-lap ([194.230.155.171]) by smtp.googlemail.com with ESMTPSA id y32sm2044311edy.4.2020.10.21.06.24.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Oct 2020 06:24:40 -0700 (PDT) Date: Wed, 21 Oct 2020 15:24:31 +0200 From: Krzysztof Kozlowski To: Oleksij Rempel Subject: Re: [PATCH v2 3/3] ARM: dts: add Van der Laan LANMCU board Message-ID: <20201021132431.GA31878@kozik-lap> References: <20201015090924.6185-1-o.rempel@pengutronix.de> <20201015090924.6185-4-o.rempel@pengutronix.de> <20201020102355.GB118941@kozik-lap> <20201021124825.yjbcdyy7dyuhvexl@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201021124825.yjbcdyy7dyuhvexl@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201021_092446_105083_6BB78BC2 X-CRM114-Status: GOOD ( 26.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Pengutronix Kernel Team , Robin van der Gracht , Sascha Hauer , linux-kernel@vger.kernel.org, Rob Herring , NXP Linux Team , Fabio Estevam , David Jander , Shawn Guo , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Oct 21, 2020 at 02:48:25PM +0200, Oleksij Rempel wrote: > Hello Krzysztof, > > On Tue, Oct 20, 2020 at 12:23:55PM +0200, Krzysztof Kozlowski wrote: > > On Thu, Oct 15, 2020 at 11:09:24AM +0200, Oleksij Rempel wrote: > > > Van der Laan LANMCU is a module for the food storage rooms to control > > > proper gas composition. > > > > > > Co-Developed-by: Robin van der Gracht > > > Signed-off-by: Robin van der Gracht > > > Signed-off-by: Oleksij Rempel > > > --- > > > arch/arm/boot/dts/Makefile | 1 + > > > arch/arm/boot/dts/imx6dl-lanmcu.dts | 469 ++++++++++++++++++++++++++++ > > > 2 files changed, 470 insertions(+) > > > create mode 100644 arch/arm/boot/dts/imx6dl-lanmcu.dts > > > > > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > > > index 2289a28c0ff6..dc2543a7b7e9 100644 > > > --- a/arch/arm/boot/dts/Makefile > > > +++ b/arch/arm/boot/dts/Makefile > > > @@ -447,6 +447,7 @@ dtb-$(CONFIG_SOC_IMX6Q) += \ > > > imx6dl-icore.dtb \ > > > imx6dl-icore-mipi.dtb \ > > > imx6dl-icore-rqs.dtb \ > > > + imx6dl-lanmcu.dtb \ > > > imx6dl-mamoj.dtb \ > > > imx6dl-nit6xlite.dtb \ > > > imx6dl-nitrogen6x.dtb \ > > > diff --git a/arch/arm/boot/dts/imx6dl-lanmcu.dts b/arch/arm/boot/dts/imx6dl-lanmcu.dts > > > new file mode 100644 > > > index 000000000000..36c029dcc832 > > > --- /dev/null > > > +++ b/arch/arm/boot/dts/imx6dl-lanmcu.dts > > > @@ -0,0 +1,469 @@ > > > +// SPDX-License-Identifier: GPL-2.0-or-later > > > +/* > > > + * Copyright (c) 2019 Protonic Holland > > > + * Copyright (c) 2020 Oleksij Rempel , Pengutronix > > > + */ > > > + > > > +/dts-v1/; > > > +#include > > > +#include > > > +#include "imx6dl.dtsi" > > > + > > > +/ { > > > + model = "Van der Laan LANMCU"; > > > + compatible = "vdl,lanmcu", "fsl,imx6dl"; > > > + > > > + chosen { > > > + stdout-path = &uart4; > > > + }; > > > + > > > + clock_ksz8081: clock-ksz8081 { > > > + compatible = "fixed-clock"; > > > + #clock-cells = <0>; > > > + clock-frequency = <50000000>; > > > + }; > > > + > > > + backlight: backlight { > > > + compatible = "pwm-backlight"; > > > + pwms = <&pwm1 0 5000000 0>; > > > + brightness-levels = <0 1000>; > > > + num-interpolated-steps = <20>; > > > + default-brightness-level = <19>; > > > + }; > > > + > > > + display { > > > + compatible = "fsl,imx-parallel-display"; > > > + pinctrl-0 = <&pinctrl_ipu1_disp>; > > > + pinctrl-names = "default"; > > > + #address-cells = <1>; > > > + #size-cells = <0>; > > > + > > > + port@0 { > > > + reg = <0>; > > > + > > > + display_in: endpoint { > > > + remote-endpoint = <&ipu1_di0_disp0>; > > > + }; > > > + }; > > > + > > > + port@1 { > > > + reg = <1>; > > > + > > > + display_out: endpoint { > > > + remote-endpoint = <&panel_in>; > > > + }; > > > + }; > > > + }; > > > + > > > + leds { > > > + compatible = "gpio-leds"; > > > + pinctrl-names = "default"; > > > + pinctrl-0 = <&pinctrl_leds>; > > > + > > > + led-debug { > > > > led-0 (dt spec naming requirement, upcomming dtschema as well) and add a > > label if you want it to be nicely labeled for user-space. > > ok, done > > > > + function = LED_FUNCTION_STATUS; > > > + gpios = <&gpio1 8 GPIO_ACTIVE_HIGH>; > > > + linux,default-trigger = "heartbeat"; > > > + }; > > > + }; > > > + > > > + panel { > > > + compatible = "edt,etm0700g0bdh6"; > > > + backlight = <&backlight>; > > > + > > > + port { > > > + panel_in: endpoint { > > > + remote-endpoint = <&display_out>; > > > + }; > > > + }; > > > + }; > > > + > > > + reg_otg_vbus: regulator-otg-vbus { > > > + compatible = "regulator-fixed"; > > > + regulator-name = "otg-vbus"; > > > + regulator-min-microvolt = <5000000>; > > > + regulator-max-microvolt = <5000000>; > > > + gpio = <&gpio3 22 GPIO_ACTIVE_HIGH>; > > > + enable-active-high; > > > + }; > > > + > > > + usdhc2_wifi_pwrseq: usdhc2-wifi-pwrseq { > > > + compatible = "mmc-pwrseq-simple"; > > > + pinctrl-names = "default"; > > > + pinctrl-0 = <&pinctrl_wifi_npd>; > > > + reset-gpios = <&gpio6 10 GPIO_ACTIVE_LOW>; > > > + }; > > > + > > > +}; > > > + > > > +&can1 { > > > + pinctrl-names = "default"; > > > + pinctrl-0 = <&pinctrl_can1>; > > > + status = "okay"; > > > +}; > > > + > > > +&can2 { > > > + pinctrl-names = "default"; > > > + pinctrl-0 = <&pinctrl_can2>; > > > + status = "okay"; > > > +}; > > > + > > > +&fec { > > > + pinctrl-names = "default"; > > > + pinctrl-0 = <&pinctrl_enet>; > > > + phy-mode = "rmii"; > > > + clocks = <&clks IMX6QDL_CLK_ENET>, > > > + <&clks IMX6QDL_CLK_ENET>, > > > + <&clock_ksz8081>; > > > + clock-names = "ipg", "ahb", "ptp"; > > > + phy-handle = <&rgmii_phy>; > > > + status = "okay"; > > > + > > > + mdio { > > > + #address-cells = <1>; > > > + #size-cells = <0>; > > > + > > > + /* Microchip KSZ8081RNA PHY */ > > > + rgmii_phy: ethernet-phy@0 { > > > + reg = <0>; > > > + interrupts-extended = <&gpio5 23 IRQ_TYPE_LEVEL_LOW>; > > > + reset-gpios = <&gpio5 22 GPIO_ACTIVE_LOW>; > > > + reset-assert-us = <10000>; > > > + reset-deassert-us = <300>; > > > + }; > > > + }; > > > +}; > > > + > > > +&gpio1 { > > > + gpio-line-names = > > > + "", "SD1_CD", "", "", "", "", "", "", > > > + "DEBUG_0", "BL_PWM", "", "", "", "", "", "", > > > + "", "", "", "", "", "", "", "ENET_LED_GREEN", > > > + "", "", "", "", "", "", "", ""; > > > +}; > > > + > > > +&gpio3 { > > > + gpio-line-names = > > > + "", "", "", "", "", "", "", "", > > > + "", "", "", "", "", "", "", "", > > > + "", "", "", "", "TS_INT", "USB_OTG1_OC", "USB_OTG1_PWR", "", > > > + "", "", "", "", "UART2_CTS", "", "UART3_CTS", ""; > > > +}; > > > + > > > +&gpio5 { > > > + gpio-line-names = > > > + "", "", "", "", "", "", "", "", > > > + "", "", "", "", "", "", "", "", > > > + "", "", "", "", "", "", "ENET_RST", "ENET_INT", > > > + "", "", "I2C1_SDA", "I2C1_SCL", "", "", "", ""; > > > +}; > > > + > > > +&gpio6 { > > > + gpio-line-names = > > > + "", "", "", "", "", "", "", "", > > > + "", "", "WLAN_REG_ON", "", "", "", "", "", > > > + "", "", "", "", "", "", "", "", > > > + "", "", "", "", "", "", "", ""; > > > +}; > > > + > > > +&gpio7 { > > > + gpio-line-names = > > > + "", "", "", "", "", "", "", "", > > > + "EMMC_RST", "", "", "", "", "", "", "", > > > + "", "", "", "", "", "", "", "", > > > + "", "", "", "", "", "", "", ""; > > > +}; > > > + > > > +&i2c1 { > > > + clock-frequency = <100000>; > > > + pinctrl-names = "default"; > > > + pinctrl-0 = <&pinctrl_i2c1>; > > > + status = "okay"; > > > + > > > + /* additional i2c devices are added automatically by the boot loader */ > > > +}; > > > + > > > +&i2c3 { > > > + clock-frequency = <100000>; > > > + pinctrl-names = "default"; > > > + pinctrl-0 = <&pinctrl_i2c3>; > > > + status = "okay"; > > > + > > > + touchscreen@38 { > > > + compatible = "edt,edt-ft5406"; > > > + reg = <0x38>; > > > + pinctrl-names = "default"; > > > + pinctrl-0 = <&pinctrl_ts_edt>; > > > + interrupts-extended = <&gpio3 20 IRQ_TYPE_EDGE_FALLING>; > > > + > > > + touchscreen-size-x = <1792>; > > > + touchscreen-size-y = <1024>; > > > + > > > + touchscreen-fuzz-x = <0>; > > > + touchscreen-fuzz-y = <0>; > > > + > > > + /* Touch screen calibration */ > > > + threshold = <50>; > > > + gain = <5>; > > > + offset = <10>; > > > + }; > > > + > > > + rtc@51 { > > > + compatible = "nxp,pcf8563"; > > > + reg = <0x51>; > > > + }; > > > +}; > > > + > > > +&ipu1_di0_disp0 { > > > + remote-endpoint = <&display_in>; > > > +}; > > > + > > > +&pwm1 { > > > + pinctrl-names = "default"; > > > + pinctrl-0 = <&pinctrl_pwm1>; > > > + status = "okay"; > > > +}; > > > + > > > +&uart2 { > > > + pinctrl-names = "default"; > > > + pinctrl-0 = <&pinctrl_uart2>; > > > + linux,rs485-enabled-at-boot-time; > > > + uart-has-rtscts; > > > + status = "okay"; > > > +}; > > > + > > > +&uart3 { > > > + pinctrl-names = "default"; > > > + pinctrl-0 = <&pinctrl_uart3>; > > > + linux,rs485-enabled-at-boot-time; > > > + uart-has-rtscts; > > > + status = "okay"; > > > +}; > > > + > > > +&uart4 { > > > + pinctrl-names = "default"; > > > + pinctrl-0 = <&pinctrl_uart4>; > > > + status = "okay"; > > > +}; > > > + > > > +&usbotg { > > > + vbus-supply = <®_otg_vbus>; > > > + pinctrl-names = "default"; > > > + pinctrl-0 = <&pinctrl_usbotg>; > > > + phy_type = "utmi"; > > > + dr_mode = "host"; > > > + status = "okay"; > > > +}; > > > + > > > +&usdhc1 { > > > + pinctrl-names = "default"; > > > + pinctrl-0 = <&pinctrl_usdhc1>; > > > + cd-gpios = <&gpio1 1 GPIO_ACTIVE_LOW>; > > > + no-1-8-v; > > > + disable-wp; > > > + cap-sd-highspeed; > > > + no-mmc; > > > + no-sdio; > > > + status = "okay"; > > > +}; > > > + > > > +&usdhc2 { > > > + pinctrl-names = "default"; > > > + pinctrl-0 = <&pinctrl_usdhc2>; > > > + no-1-8-v; > > > + non-removable; > > > + mmc-pwrseq = <&usdhc2_wifi_pwrseq>; > > > + #address-cells = <1>; > > > + #size-cells = <0>; > > > + status = "okay"; > > > + > > > + brcmf: bcrmf@1 { > > > > node name "wifi"? Or "wifi-bt"? DT spec requires nodes to have more or > > less generic names. > > I'll take wifi@ it is mostly used pattern. > > > Best regards, > > Krzysztof > > Thx for review, > > should I add your Reviewed-by? With the changes, can be: Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel