From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E262C4363A for ; Wed, 21 Oct 2020 18:32:02 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B285C25420 for ; Wed, 21 Oct 2020 18:32:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="EeGsuFT2"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="K0hxncsi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B285C25420 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tGwNXEbSsTLSwYytwU2ypbVaaWBvRb5RDgwWQg736Wg=; b=EeGsuFT2/PTMRAawDQdFrDP9j e3W+TOg2yScIiRMKvEkPypLnu6ERJ+kXusKH5V4sVzZ0J75aO/8hsSQgtHvUqu0UbGdrCIKxY9Xp/ dzqxVZ+XVUmIL3MZOYomnrdJUIPpCDnjP+pPCaSaa4jPVpUzsspw6E6sPFh5K40W3riQu6iCm94Pf BPpZREGmHFwMU2ri887Nu8Er6xrd+wLFmACYaJoUOxOL8pA1Ymg9EI/m8ER9FfS0qrerKWQJUpVsX JNfwZ7HTLBIC16BdaCbraYPHYwugl1RjlxGe60fXWXqmSHMm/8bJ3Uvui8Q7fub8rTqBLlAp0arVJ nmR7eAWTQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kVIsd-0002rD-Ib; Wed, 21 Oct 2020 18:30:35 +0000 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kVIsb-0002qF-AA for linux-arm-kernel@lists.infradead.org; Wed, 21 Oct 2020 18:30:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603305031; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SWk1HmGPS11z1lVFpxCdMWGo2d19IWvUVpCVt8eeJUo=; b=K0hxncsiy+HgGCxhfcSEQ728NKPSWrS27WL03a3faeiWdJEBw2eaSspuidUxI+2Bep6gTm ZM8V0EHLAaPAg/hPyOUTrbNMO4oirTiy+skAO3BRcimkL8MvmrG7pWG6uPpcOulzXl8nK3 nbZ6VjJttYz4iQbVSRN2r/TOj+UF9sg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-267-ts4ydIjKNra8FmPa6CjVIA-1; Wed, 21 Oct 2020 14:30:26 -0400 X-MC-Unique: ts4ydIjKNra8FmPa6CjVIA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 51CD0101962B; Wed, 21 Oct 2020 18:30:24 +0000 (UTC) Received: from treble (ovpn-117-195.rdu2.redhat.com [10.10.117.195]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 912706EF42; Wed, 21 Oct 2020 18:30:14 +0000 (UTC) Date: Wed, 21 Oct 2020 13:30:09 -0500 From: Josh Poimboeuf To: Peter Zijlstra Subject: Re: [PATCH v6 22/25] x86/asm: annotate indirect jumps Message-ID: <20201021183009.qbvhz7hsrm46vksn@treble> References: <20201013003203.4168817-1-samitolvanen@google.com> <20201013003203.4168817-23-samitolvanen@google.com> <20201015102216.GB2611@hirez.programming.kicks-ass.net> <20201015203942.f3kwcohcwwa6lagd@treble> <20201020185217.ilg6w5l7ujau2246@treble> <20201021095133.GA2628@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201021095133.GA2628@hirez.programming.kicks-ass.net> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201021_143033_403608_8F8FC0A6 X-CRM114-Status: GOOD ( 15.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch , Kees Cook , "Paul E. McKenney" , Jann Horn , Greg Kroah-Hartman , Masahiro Yamada , the arch/x86 maintainers , Nick Desaulniers , kernel list , Steven Rostedt , linux-kbuild , clang-built-linux , Sami Tolvanen , linux-pci@vger.kernel.org, Kernel Hardening , Will Deacon , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Oct 21, 2020 at 11:51:33AM +0200, Peter Zijlstra wrote: > On Tue, Oct 20, 2020 at 01:52:17PM -0500, Josh Poimboeuf wrote: > > > arch/x86/lib/retpoline.S: > > > __x86_retpoline_rdi()+0x10: return with modified stack frame > > > __x86_retpoline_rdi()+0x0: stack state mismatch: cfa1=7+32 cfa2=7+8 > > > __x86_retpoline_rdi()+0x0: stack state mismatch: cfa1=7+32 cfa2=-1+0 > > > > Is this with upstream? I thought we fixed that with > > UNWIND_HINT_RET_OFFSET. > > I can't reproduce this one either; but I do get different warnings: > > gcc (Debian 10.2.0-13) 10.2.0, x86_64-defconfig: > > defconfig-build/vmlinux.o: warning: objtool: __x86_indirect_thunk_rax() falls through to next function __x86_retpoline_rax() > defconfig-build/vmlinux.o: warning: objtool: .altinstr_replacement+0x1063: (branch) > defconfig-build/vmlinux.o: warning: objtool: __x86_indirect_thunk_rax()+0x0: (alt) > defconfig-build/vmlinux.o: warning: objtool: __x86_indirect_thunk_rax()+0x0: <=== (sym) > > (for every single register, not just rax) > > Which is daft as well, because the retpoline.o run is clean. It also > doesn't make sense because __x86_retpoline_rax isn't in fact STT_FUNC, > so WTH ?! It is STT_FUNC: SYM_FUNC_START_NOALIGN(__x86_retpoline_\reg) $ readelf -s vmlinux.o |grep __x86_retpoline_rax 129749: 0000000000000005 17 FUNC GLOBAL DEFAULT 39 __x86_retpoline_rax -- Josh _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel