From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2C4FC4363A for ; Thu, 22 Oct 2020 07:27:38 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 250FE20848 for ; Thu, 22 Oct 2020 07:27:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jq+xe1Z+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 250FE20848 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=japb7TYKLYCp1FDfyciBkcqAkcWP7v9tzePKDJTv0cA=; b=jq+xe1Z+lHUhi98PJOCs8ABt/ uOXIh7rnPJBffld41ZE9Ng533p5JUnuKg7vJQdFVxLaERHukQyzrV81llZwzY7K4vMqd0FW5KQ+Lc s3QfcpZDjOh07WJFKLRMoGVnxh2QXbZiS9OUq9m77f6ftwCBb9PtCI/iMYHMqp6K8STgh4xBrTXMR 8JPpxAoMhD+K01zYppOEAK7FEbsWmJk7KO5b6tG2Z8VuSdXAdLg2PXuHNIn6kHzOXTejPndhzyzVv AHkKA9LuF/ThvPY7M7hKa5GJ9h6WHreScS/7zbxN+Bb90n0MTgmII0i7DZJEPbonzQe1Dd+9IuBGy VW28H/+zg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kVUz1-0002dp-51; Thu, 22 Oct 2020 07:25:59 +0000 Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1kVUyy-0002dT-Ax; Thu, 22 Oct 2020 07:25:56 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 8E3203010D2; Thu, 22 Oct 2020 09:25:53 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 7DE3B21463180; Thu, 22 Oct 2020 09:25:53 +0200 (CEST) Date: Thu, 22 Oct 2020 09:25:53 +0200 From: Peter Zijlstra To: Josh Poimboeuf Subject: Re: [PATCH v6 22/25] x86/asm: annotate indirect jumps Message-ID: <20201022072553.GN2628@hirez.programming.kicks-ass.net> References: <20201013003203.4168817-23-samitolvanen@google.com> <20201015102216.GB2611@hirez.programming.kicks-ass.net> <20201015203942.f3kwcohcwwa6lagd@treble> <20201020185217.ilg6w5l7ujau2246@treble> <20201021085606.GZ2628@hirez.programming.kicks-ass.net> <20201021093213.GV2651@hirez.programming.kicks-ass.net> <20201021212747.ofk74lugt4hhjdzg@treble> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201021212747.ofk74lugt4hhjdzg@treble> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch , Kees Cook , "Paul E. McKenney" , Jann Horn , Greg Kroah-Hartman , Masahiro Yamada , the arch/x86 maintainers , Nick Desaulniers , kernel list , Steven Rostedt , linux-kbuild , clang-built-linux , Sami Tolvanen , linux-pci@vger.kernel.org, Kernel Hardening , Will Deacon , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Oct 21, 2020 at 04:27:47PM -0500, Josh Poimboeuf wrote: > On Wed, Oct 21, 2020 at 11:32:13AM +0200, Peter Zijlstra wrote: > > On Wed, Oct 21, 2020 at 10:56:06AM +0200, Peter Zijlstra wrote: > > > > > I do not see these in particular, although I do see a lot of: > > > > > > "sibling call from callable instruction with modified stack frame" > > > > defconfig-build/vmlinux.o: warning: objtool: msr_write()+0x10a: sibling call from callable instruction with modified stack frame > > defconfig-build/vmlinux.o: warning: objtool: msr_write()+0x99: (branch) > > defconfig-build/vmlinux.o: warning: objtool: msr_write()+0x3e: (branch) > > defconfig-build/vmlinux.o: warning: objtool: msr_write()+0x0: <=== (sym) > > > > $ nm defconfig-build/vmlinux.o | grep msr_write > > 0000000000043250 t msr_write > > 00000000004289c0 T msr_write > > 0000000000003056 t msr_write.cold > > > > Below 'fixes' it. So this is also caused by duplicate symbols. > > There's a new linker flag for renaming duplicates: > > https://sourceware.org/bugzilla/show_bug.cgi?id=26391 > > But I guess that doesn't help us now. Well, depends a bit if clang can do it; we only need this for LTO builds for now. > I don't have access to GCC 10 at the moment so I can't recreate it. > Does this fix it? Doesn't seem to do the trick :/ I'll try and have a poke later. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel