Re: [RFC PATCH v2 0/4] Add support for Asymmetric AArch32 systems

Greg Kroah-Hartman
2020-10-21T11:27:37Z

On Wed, Oct 21, 2020 at 11:46:07AM +0100, Qais Yousef wrote:
> This series adds basic support for Asymmetric AArch32 systems. Full rationale
> is in v1's cover letter.
>
> https://lore.kernel.org/linux-arch/20201008181641.32767-1-qais.yousef@arm.com/

That is not good, provide full rational in each place, not everyone has
web access at all time.

Also, you forgot to document this in Documentation/ABI/ like is required
for sysfs files, and I thought I asked for last time.

> Changes in v2:
>
> * We now reset vcpu->arch.target to force re-initialized for KVM patch.
> (Marc)
>
> * Fix a bug where this_cpu_has_cap() must be called with preemption
> disabled in check_aarch32_cpumask().
>
> * Add new sysctl.enable_asym_32bit. (Catalin)
>
> * Export id_aar64fpr0 register in sysfs which allows user space to
> discover which cpus support 32bit@EL0. The sysctl must be enabled for
> the user space to discover the asymmetry. (Will/Catalin)
>
> * Fixing up affinity in the kernel approach was dropped. The support
> assumes the user space that wants to enable this support knows how to
> guarantee correct affinities for 32bit apps by using cpusets.

I asked you to work with Intel to come up with an agreement of how this
is going to be represented in userspace. Why did you not do that?

Without even looking at the patch set, this is not ok...

greg k-h